1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec

gua.guo@intel.com posted 1 patch 1 year, 10 months ago
Failed in applying to current master (apply log)
UefiPayloadPkg/UniversalPayloadBuild.py | 1 +
1 file changed, 1 insertion(+)
[edk2-devel] [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
Posted by gua.guo@intel.com 1 year, 10 months ago 
From: Gua Guo <gua.guo@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3963

Based on UPL spec 2.12.2. Universal Payload Information Section,
it defines item "Attribute" on UPLD_INFO_HEADER for Debug build
should be "1", and Release build should be "0".

Currently, The value of item "Attribute" is always "0"

Cc: Guo Dong <guo.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: James Lu <james.lu@intel.com>
Signed-off-by: Gua Guo <gua.guo@intel.com>
---
 UefiPayloadPkg/UniversalPayloadBuild.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/UefiPayloadPkg/UniversalPayloadBuild.py b/UefiPayloadPkg/UniversalPayloadBuild.py
index ab4c977ba5..6003de36d1 100644
--- a/UefiPayloadPkg/UniversalPayloadBuild.py
+++ b/UefiPayloadPkg/UniversalPayloadBuild.py
@@ -111,6 +111,7 @@ def BuildUniversalPayload(Args, MacroList):
     #
     upld_info_hdr = UPLD_INFO_HEADER()
     upld_info_hdr.ImageId = Args.ImageId.encode()[:16]
+    upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
     fp = open(UpldInfoFile, 'wb')
     fp.write(bytearray(upld_info_hdr))
     fp.close()
-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90800): https://edk2.groups.io/g/devel/message/90800
Mute This Topic: https://groups.io/mt/92013929/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
Posted by Ni, Ray 1 year, 10 months ago 
> +    upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0


I am not python expert. Above statement might be interpreted as:
1. (upld_info.hdr.Attribute |= 1) if BuildTarget == "DEBUG" else 0
2. upld_info_hdr.Attribute |= (1 if BuildTarget == "DEBUG" else 0)

Are we sure that the #2 is chosen in by the python interpreter?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90764): https://edk2.groups.io/g/devel/message/90764
Mute This Topic: https://groups.io/mt/92013929/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
Posted by Guo, Gua 1 year, 10 months ago 
The python logic will like for below

> upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
=========>
> if BuildTarget == "DEBUG":
>   upld_info_hdr.Attribute |= 1
> else:
>   upld_info_hdr.Attribute |= 0

Thanks,
Gua

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Monday, June 27, 2022 11:44 AM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec

> +    upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0


I am not python expert. Above statement might be interpreted as:
1. (upld_info.hdr.Attribute |= 1) if BuildTarget == "DEBUG" else 0 2. upld_info_hdr.Attribute |= (1 if BuildTarget == "DEBUG" else 0)

Are we sure that the #2 is chosen in by the python interpreter?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90801): https://edk2.groups.io/g/devel/message/90801
Mute This Topic: https://groups.io/mt/92013929/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
Posted by Guo, Gua 1 year, 10 months ago 
Yes, #2 is chosen in by the python interpreter.

-----Original Message-----
From: Guo, Gua 
Sent: Monday, June 27, 2022 12:07 PM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec

The python logic will like for below

> upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
=========>
> if BuildTarget == "DEBUG":
>   upld_info_hdr.Attribute |= 1
> else:
>   upld_info_hdr.Attribute |= 0

Thanks,
Gua

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Monday, June 27, 2022 11:44 AM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec

> +    upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0


I am not python expert. Above statement might be interpreted as:
1. (upld_info.hdr.Attribute |= 1) if BuildTarget == "DEBUG" else 0 2. upld_info_hdr.Attribute |= (1 if BuildTarget == "DEBUG" else 0)

Are we sure that the #2 is chosen in by the python interpreter?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90802): https://edk2.groups.io/g/devel/message/90802
Mute This Topic: https://groups.io/mt/92013929/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
Posted by Ni, Ray 1 year, 10 months ago 
Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Guo, Gua <gua.guo@intel.com>
> Sent: Monday, June 27, 2022 1:03 PM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
> 
> Yes, #2 is chosen in by the python interpreter.
> 
> -----Original Message-----
> From: Guo, Gua
> Sent: Monday, June 27, 2022 12:07 PM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
> 
> The python logic will like for below
> 
> > upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
> =========>
> > if BuildTarget == "DEBUG":
> >   upld_info_hdr.Attribute |= 1
> > else:
> >   upld_info_hdr.Attribute |= 0
> 
> Thanks,
> Gua
> 
> -----Original Message-----
> From: Ni, Ray <ray.ni@intel.com>
> Sent: Monday, June 27, 2022 11:44 AM
> To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io
> Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
> 
> > +    upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0
> 
> 
> I am not python expert. Above statement might be interpreted as:
> 1. (upld_info.hdr.Attribute |= 1) if BuildTarget == "DEBUG" else 0 2. upld_info_hdr.Attribute |= (1 if BuildTarget ==
> "DEBUG" else 0)
> 
> Are we sure that the #2 is chosen in by the python interpreter?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90781): https://edk2.groups.io/g/devel/message/90781
Mute This Topic: https://groups.io/mt/92013929/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec
Posted by Guo, Gua 1 year, 10 months ago 
@Ni, Ray<mailto:ray.ni@intel.com>

Below url is pull request link.  May I get your help to add push label ? Have any concern, please also share for me.

URL: https://github.com/tianocore/edk2/pull/3015

Thanks,
Gua



-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, June 27, 2022 2:53 PM
To: Guo, Gua <gua.guo@intel.com>; devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Lu, James <james.lu@intel.com>
Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL spec



Reviewed-by: Ray Ni <ray.ni@intel.com<mailto:ray.ni@intel.com>>



> -----Original Message-----

> From: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>

> Sent: Monday, June 27, 2022 1:03 PM

> To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>

> Cc: Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>>; Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>

> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL

> spec

>

> Yes, #2 is chosen in by the python interpreter.

>

> -----Original Message-----

> From: Guo, Gua

> Sent: Monday, June 27, 2022 12:07 PM

> To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>

> Cc: Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>>; Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>

> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL

> spec

>

> The python logic will like for below

>

> > upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0

> =========>

> > if BuildTarget == "DEBUG":

> >   upld_info_hdr.Attribute |= 1

> > else:

> >   upld_info_hdr.Attribute |= 0

>

> Thanks,

> Gua

>

> -----Original Message-----

> From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>

> Sent: Monday, June 27, 2022 11:44 AM

> To: Guo, Gua <gua.guo@intel.com<mailto:gua.guo@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io>

> Cc: Dong, Guo <guo.dong@intel.com<mailto:guo.dong@intel.com>>; Lu, James <james.lu@intel.com<mailto:james.lu@intel.com>>

> Subject: RE: [PATCH] UefiPayloadPkg: Align Attribute value with UPL

> spec

>

> > +    upld_info_hdr.Attribute |= 1 if BuildTarget == "DEBUG" else 0

>

>

> I am not python expert. Above statement might be interpreted as:

> 1. (upld_info.hdr.Attribute |= 1) if BuildTarget == "DEBUG" else 0 2.

> upld_info_hdr.Attribute |= (1 if BuildTarget == "DEBUG" else 0)

>

> Are we sure that the #2 is chosen in by the python interpreter?


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90803): https://edk2.groups.io/g/devel/message/90803
Mute This Topic: https://groups.io/mt/92013929/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.