1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'

Fan, ZhijuX posted 1 patch 4 years, 8 months ago
Failed in applying to current master (apply log)
BaseTools/Source/Python/build/BuildReport.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'
Posted by Fan, ZhijuX 4 years, 8 months ago 
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2093

The PlatformAutoGen object has a DataPipe property but no DataPile property
So change the variable name 'DataPile' to 'DataPipe' in BuildReport.py

This patch is going to fix that issue.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
 BaseTools/Source/Python/build/BuildReport.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
index 9c12c01d2a..6b26f1c3b0 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -2142,7 +2142,7 @@ class PlatformReport(object):
                         INFList = GlobalData.gFdfParser.Profile.InfDict[Pa.Arch]
                         for InfName in INFList:
                             InfClass = PathClass(NormPath(InfName), Wa.WorkspaceDir, Pa.Arch)
-                            Ma = ModuleAutoGen(Wa, InfClass, Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile,Pa.DataPile)
+                            Ma = ModuleAutoGen(Wa, InfClass, Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile, Pa.DataPipe)
                             if Ma is None:
                                 continue
                             if Ma not in ModuleAutoGenList:
-- 
2.14.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46063): https://edk2.groups.io/g/devel/message/46063
Mute This Topic: https://groups.io/mt/32962507/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'
Posted by Bob Feng 4 years, 8 months ago 
Reviewed-by: Bob Feng <bob.c.feng@intel.com>

-----Original Message-----
From: Fan, ZhijuX 
Sent: Tuesday, August 20, 2019 8:49 AM
To: devel@edk2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
Subject: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2093

The PlatformAutoGen object has a DataPipe property but no DataPile property So change the variable name 'DataPile' to 'DataPipe' in BuildReport.py

This patch is going to fix that issue.

Cc: Liming Gao <liming.gao@intel.com>
Cc: Bob Feng <bob.c.feng@intel.com>
Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
---
 BaseTools/Source/Python/build/BuildReport.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/build/BuildReport.py b/BaseTools/Source/Python/build/BuildReport.py
index 9c12c01d2a..6b26f1c3b0 100644
--- a/BaseTools/Source/Python/build/BuildReport.py
+++ b/BaseTools/Source/Python/build/BuildReport.py
@@ -2142,7 +2142,7 @@ class PlatformReport(object):
                         INFList = GlobalData.gFdfParser.Profile.InfDict[Pa.Arch]
                         for InfName in INFList:
                             InfClass = PathClass(NormPath(InfName), Wa.WorkspaceDir, Pa.Arch)
-                            Ma = ModuleAutoGen(Wa, InfClass, Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile,Pa.DataPile)
+                            Ma = ModuleAutoGen(Wa, InfClass, 
+ Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile, Pa.DataPipe)
                             if Ma is None:
                                 continue
                             if Ma not in ModuleAutoGenList:
--
2.14.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46072): https://edk2.groups.io/g/devel/message/46072
Mute This Topic: https://groups.io/mt/32962507/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'
Posted by Liming Gao 4 years, 8 months ago 
Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Feng, Bob C
>Sent: Tuesday, August 20, 2019 10:05 AM
>To: Fan, ZhijuX <zhijux.fan@intel.com>; devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: RE: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect
>variable name 'DataPile'
>
>Reviewed-by: Bob Feng <bob.c.feng@intel.com>
>
>-----Original Message-----
>From: Fan, ZhijuX
>Sent: Tuesday, August 20, 2019 8:49 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable
>name 'DataPile'
>
>BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2093
>
>The PlatformAutoGen object has a DataPipe property but no DataPile
>property So change the variable name 'DataPile' to 'DataPipe' in
>BuildReport.py
>
>This patch is going to fix that issue.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index 9c12c01d2a..6b26f1c3b0 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -2142,7 +2142,7 @@ class PlatformReport(object):
>                         INFList = GlobalData.gFdfParser.Profile.InfDict[Pa.Arch]
>                         for InfName in INFList:
>                             InfClass = PathClass(NormPath(InfName), Wa.WorkspaceDir,
>Pa.Arch)
>-                            Ma = ModuleAutoGen(Wa, InfClass, Pa.BuildTarget,
>Pa.ToolChain, Pa.Arch, Wa.MetaFile,Pa.DataPile)
>+                            Ma = ModuleAutoGen(Wa, InfClass,
>+ Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile, Pa.DataPipe)
>                             if Ma is None:
>                                 continue
>                             if Ma not in ModuleAutoGenList:
>--
>2.14.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46080): https://edk2.groups.io/g/devel/message/46080
Mute This Topic: https://groups.io/mt/32962507/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'
Posted by Bob Feng 4 years, 8 months ago 
Pushed at 0970a80583a9a0595eb357f380e604b57136fa26

Thanks,
Bob

-----Original Message-----
From: Gao, Liming 
Sent: Tuesday, August 20, 2019 2:24 PM
To: Feng, Bob C <bob.c.feng@intel.com>; Fan, ZhijuX <zhijux.fan@intel.com>; devel@edk2.groups.io
Subject: RE: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile'

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Feng, Bob C
>Sent: Tuesday, August 20, 2019 10:05 AM
>To: Fan, ZhijuX <zhijux.fan@intel.com>; devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>
>Subject: RE: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect 
>variable name 'DataPile'
>
>Reviewed-by: Bob Feng <bob.c.feng@intel.com>
>
>-----Original Message-----
>From: Fan, ZhijuX
>Sent: Tuesday, August 20, 2019 8:49 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C 
><bob.c.feng@intel.com>
>Subject: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect 
>variable name 'DataPile'
>
>BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2093
>
>The PlatformAutoGen object has a DataPipe property but no DataPile 
>property So change the variable name 'DataPile' to 'DataPipe' in 
>BuildReport.py
>
>This patch is going to fix that issue.
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Bob Feng <bob.c.feng@intel.com>
>Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
>---
> BaseTools/Source/Python/build/BuildReport.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/BaseTools/Source/Python/build/BuildReport.py
>b/BaseTools/Source/Python/build/BuildReport.py
>index 9c12c01d2a..6b26f1c3b0 100644
>--- a/BaseTools/Source/Python/build/BuildReport.py
>+++ b/BaseTools/Source/Python/build/BuildReport.py
>@@ -2142,7 +2142,7 @@ class PlatformReport(object):
>                         INFList = GlobalData.gFdfParser.Profile.InfDict[Pa.Arch]
>                         for InfName in INFList:
>                             InfClass = PathClass(NormPath(InfName), 
>Wa.WorkspaceDir,
>Pa.Arch)
>-                            Ma = ModuleAutoGen(Wa, InfClass, Pa.BuildTarget,
>Pa.ToolChain, Pa.Arch, Wa.MetaFile,Pa.DataPile)
>+                            Ma = ModuleAutoGen(Wa, InfClass, 
>+ Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile, Pa.DataPipe)
>                             if Ma is None:
>                                 continue
>                             if Ma not in ModuleAutoGenList:
>--
>2.14.1.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46081): https://edk2.groups.io/g/devel/message/46081
Mute This Topic: https://groups.io/mt/32962507/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.