[edk2-devel] MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort

Anbazhagan, Baraneedharan via groups.io posted 1 patch 5 years, 2 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort
Posted by Anbazhagan, Baraneedharan via groups.io 5 years, 2 months ago
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3085

Coding error in converting memset call to SetMem - Length and Value
is not swapped on calling SetMem

Signed-off-by: Baraneedharan Anbazhagan <anbazhagan@hp.com>
---
MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c
index 2b2b0d420d..9aa7b0a68e 100644
--- a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c
+++ b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c
@@ -93,6 +93,6 @@ void* memcpy (void *dest, const void *src, unsigned int count)
 void* memset (void *dest, char ch, unsigned int count)
{
-  return SetMem (dest, ch, count);
+  return SetMem (dest, count, ch);
}
--
2.29.2.windows.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68609): https://edk2.groups.io/g/devel/message/68609
Mute This Topic: https://groups.io/mt/78843697/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


回复: [edk2-devel] MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort
Posted by gaoliming 5 years, 2 months ago
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

 

发件人: bounce+27952+68609+4905953+8761045@groups.io
<bounce+27952+68609+4905953+8761045@groups.io> 代表 Anbazhagan,
Baraneedharan via groups.io
发送时间: 2020年12月10日 8:21
收件人: devel@edk2.groups.io
抄送: gaoliming@byosoft.com.cn; jian.j.wang@intel.com; hao.a.wu@intel.com
主题: [edk2-devel] MdeModulePkg: Fix SetMem parameter in OnigurumaUefiPort

 

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3085

 

Coding error in converting memset call to SetMem - Length and Value

is not swapped on calling SetMem

 

Signed-off-by: Baraneedharan Anbazhagan <anbazhagan@hp.com
<mailto:anbazhagan@hp.com> >

---

MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

 

diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c
b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

index 2b2b0d420d..9aa7b0a68e 100644

--- a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

+++ b/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefiPort.c

@@ -93,6 +93,6 @@ void* memcpy (void *dest, const void *src, unsigned int
count)

 

 void* memset (void *dest, char ch, unsigned int count)

{

-  return SetMem (dest, ch, count);

+  return SetMem (dest, count, ch);

}

 

-- 

2.29.2.windows.3

 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#68612): https://edk2.groups.io/g/devel/message/68612
Mute This Topic: https://groups.io/mt/78845058/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-