1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs

Jeff Brasen via groups.io posted 1 patch 1 year, 10 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c    | 3 ++-
MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
[edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
Posted by Jeff Brasen via groups.io 1 year, 10 months ago 
Add support for getting disk info from UFS devices.

Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
 MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c    | 3 ++-
 MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
index fac33b9ee9..87b82f299f 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
@@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
 

       BmEliminateExtraSpaces (Description);

     }

-  } else if (CompareGuid (&DiskInfo->Interface, &gEfiDiskInfoScsiInterfaceGuid)) {

+  } else if (CompareGuid (&DiskInfo->Interface, &gEfiDiskInfoScsiInterfaceGuid) ||

+             CompareGuid (&DiskInfo->Interface, &gEfiDiskInfoUfsInterfaceGuid)) {

     BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);

     Status     = DiskInfo->Inquiry (

                              DiskInfo,

diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
index fe05d5f1cc..2fc0a80a4e 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
+++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
@@ -85,6 +85,7 @@
   gEfiDiskInfoIdeInterfaceGuid                  ## SOMETIMES_CONSUMES ## GUID

   gEfiDiskInfoScsiInterfaceGuid                 ## SOMETIMES_CONSUMES ## GUID

   gEfiDiskInfoSdMmcInterfaceGuid                ## SOMETIMES_CONSUMES ## GUID

+  gEfiDiskInfoUfsInterfaceGuid                  ## SOMETIMES_CONSUMES ## GUID

 

 [Protocols]

   gEfiPciRootBridgeIoProtocolGuid               ## CONSUMES

-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#90519): https://edk2.groups.io/g/devel/message/90519
Mute This Topic: https://groups.io/mt/91755004/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
回复: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
Posted by gaoliming via groups.io 1 year, 9 months ago 
Jeff:
  I want to confirm why UFS apply the same rule to SCSI. Does UFS follows
SCSI spec?

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jeff Brasen
> via groups.io
> 发送时间: 2022年6月15日 1:54
> 收件人: devel@edk2.groups.io
> 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen <jbrasen@nvidia.com>
> 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk
> Info support for Ufs
> 
> Add support for getting disk info from UFS devices.
> 
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
>  MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c    | 3
> ++-
>  MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> index fac33b9ee9..87b82f299f 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> 
> 
>        BmEliminateExtraSpaces (Description);
> 
>      }
> 
> -  } else if (CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoScsiInterfaceGuid)) {
> 
> +  } else if (CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoScsiInterfaceGuid) ||
> 
> +             CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoUfsInterfaceGuid)) {
> 
>      BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> 
>      Status     = DiskInfo->Inquiry (
> 
>                               DiskInfo,
> 
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> index fe05d5f1cc..2fc0a80a4e 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -85,6 +85,7 @@
>    gEfiDiskInfoIdeInterfaceGuid                  ##
> SOMETIMES_CONSUMES ## GUID
> 
>    gEfiDiskInfoScsiInterfaceGuid                 ##
> SOMETIMES_CONSUMES ## GUID
> 
>    gEfiDiskInfoSdMmcInterfaceGuid                ##
> SOMETIMES_CONSUMES ## GUID
> 
> +  gEfiDiskInfoUfsInterfaceGuid                  ##
> SOMETIMES_CONSUMES ## GUID
> 
> 
> 
>  [Protocols]
> 
>    gEfiPciRootBridgeIoProtocolGuid               ## CONSUMES
> 
> --
> 2.25.1
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91512): https://edk2.groups.io/g/devel/message/91512
Mute This Topic: https://groups.io/mt/92474575/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
Posted by Jeff Brasen via groups.io 1 year, 9 months ago 
Yes, Universal Flash Storage is based on the SCSI architectural model and installs gEfiExtScsiPassThruProtocolGuid to function.

Thanks,
Jeff

> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, July 18, 2022 7:44 PM
> To: devel@edk2.groups.io; Jeff Brasen <jbrasen@nvidia.com>
> Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com
> Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib:
> Add Disk Info support for Ufs
> 
> External email: Use caution opening links or attachments
> 
> 
> Jeff:
>   I want to confirm why UFS apply the same rule to SCSI. Does UFS follows
> SCSI spec?
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jeff Brasen
> via
> > groups.io
> > 发送时间: 2022年6月15日 1:54
> > 收件人: devel@edk2.groups.io
> > 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen
> > <jbrasen@nvidia.com>
> > 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add
> Disk
> > Info support for Ufs
> >
> > Add support for getting disk info from UFS devices.
> >
> > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > ---
> >  MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c    | 3
> > ++-
> >  MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1
> +
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > index fac33b9ee9..87b82f299f 100644
> > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> >
> >
> >        BmEliminateExtraSpaces (Description);
> >
> >      }
> >
> > -  } else if (CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoScsiInterfaceGuid)) {
> >
> > +  } else if (CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoScsiInterfaceGuid) ||
> >
> > +             CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoUfsInterfaceGuid)) {
> >
> >      BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> >
> >      Status     = DiskInfo->Inquiry (
> >
> >                               DiskInfo,
> >
> > diff --git
> > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > index fe05d5f1cc..2fc0a80a4e 100644
> > ---
> a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > +++
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > @@ -85,6 +85,7 @@
> >    gEfiDiskInfoIdeInterfaceGuid                  ##
> > SOMETIMES_CONSUMES ## GUID
> >
> >    gEfiDiskInfoScsiInterfaceGuid                 ##
> > SOMETIMES_CONSUMES ## GUID
> >
> >    gEfiDiskInfoSdMmcInterfaceGuid                ##
> > SOMETIMES_CONSUMES ## GUID
> >
> > +  gEfiDiskInfoUfsInterfaceGuid                  ##
> > SOMETIMES_CONSUMES ## GUID
> >
> >
> >
> >  [Protocols]
> >
> >    gEfiPciRootBridgeIoProtocolGuid               ## CONSUMES
> >
> > --
> > 2.25.1
> >
> >
> >
> > 
> >
> >
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91535): https://edk2.groups.io/g/devel/message/91535
Mute This Topic: https://groups.io/mt/92484604/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
Posted by Jeff Brasen via groups.io 1 year, 6 months ago 
Any additional thoughts on this patch?

> -----Original Message-----
> From: Jeff Brasen
> Sent: Tuesday, July 19, 2022 9:14 AM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib:
> Add Disk Info support for Ufs
> 
> Yes, Universal Flash Storage is based on the SCSI architectural model and
> installs gEfiExtScsiPassThruProtocolGuid to function.
> 
> Thanks,
> Jeff
> 
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Monday, July 18, 2022 7:44 PM
> > To: devel@edk2.groups.io; Jeff Brasen <jbrasen@nvidia.com>
> > Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com
> > Subject: 回复: [edk2-devel] [PATCH]
> MdeModulePkg/UefiBootManagerLib:
> > Add Disk Info support for Ufs
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Jeff:
> >   I want to confirm why UFS apply the same rule to SCSI. Does UFS
> > follows SCSI spec?
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jeff
> Brasen
> > via
> > > groups.io
> > > 发送时间: 2022年6月15日 1:54
> > > 收件人: devel@edk2.groups.io
> > > 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen
> > > <jbrasen@nvidia.com>
> > > 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add
> > Disk
> > > Info support for Ufs
> > >
> > > Add support for getting disk info from UFS devices.
> > >
> > > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > > ---
> > >  MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c    | 3
> > > ++-
> > >  MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf |
> 1
> > +
> > >  2 files changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > index fac33b9ee9..87b82f299f 100644
> > > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > +++
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> > >
> > >
> > >        BmEliminateExtraSpaces (Description);
> > >
> > >      }
> > >
> > > -  } else if (CompareGuid (&DiskInfo->Interface,
> > > &gEfiDiskInfoScsiInterfaceGuid)) {
> > >
> > > +  } else if (CompareGuid (&DiskInfo->Interface,
> > > &gEfiDiskInfoScsiInterfaceGuid) ||
> > >
> > > +             CompareGuid (&DiskInfo->Interface,
> > > &gEfiDiskInfoUfsInterfaceGuid)) {
> > >
> > >      BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> > >
> > >      Status     = DiskInfo->Inquiry (
> > >
> > >                               DiskInfo,
> > >
> > > diff --git
> > > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > index fe05d5f1cc..2fc0a80a4e 100644
> > > ---
> > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > +++
> > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > @@ -85,6 +85,7 @@
> > >    gEfiDiskInfoIdeInterfaceGuid                  ##
> > > SOMETIMES_CONSUMES ## GUID
> > >
> > >    gEfiDiskInfoScsiInterfaceGuid                 ##
> > > SOMETIMES_CONSUMES ## GUID
> > >
> > >    gEfiDiskInfoSdMmcInterfaceGuid                ##
> > > SOMETIMES_CONSUMES ## GUID
> > >
> > > +  gEfiDiskInfoUfsInterfaceGuid                  ##
> > > SOMETIMES_CONSUMES ## GUID
> > >
> > >
> > >
> > >  [Protocols]
> > >
> > >    gEfiPciRootBridgeIoProtocolGuid               ## CONSUMES
> > >
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > > 
> > >
> > >
> >
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94793): https://edk2.groups.io/g/devel/message/94793
Mute This Topic: https://groups.io/mt/92484604/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
Posted by Ard Biesheuvel 1 year, 6 months ago 
On Thu, 6 Oct 2022 at 16:23, Jeff Brasen via groups.io
<jbrasen=nvidia.com@groups.io> wrote:
>
> Any additional thoughts on this patch?
>

If you resend it using a mail client that doesn't corrupt all the
whitespace, I can merge it for you (with Zhichao's ack).


> > -----Original Message-----
> > From: Jeff Brasen
> > Sent: Tuesday, July 19, 2022 9:14 AM
> > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com
> > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib:
> > Add Disk Info support for Ufs
> >
> > Yes, Universal Flash Storage is based on the SCSI architectural model and
> > installs gEfiExtScsiPassThruProtocolGuid to function.
> >
> > Thanks,
> > Jeff
> >
> > > -----Original Message-----
> > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > Sent: Monday, July 18, 2022 7:44 PM
> > > To: devel@edk2.groups.io; Jeff Brasen <jbrasen@nvidia.com>
> > > Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com
> > > Subject: 回复: [edk2-devel] [PATCH]
> > MdeModulePkg/UefiBootManagerLib:
> > > Add Disk Info support for Ufs
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > Jeff:
> > >   I want to confirm why UFS apply the same rule to SCSI. Does UFS
> > > follows SCSI spec?
> > >
> > > Thanks
> > > Liming
> > > > -----邮件原件-----
> > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jeff
> > Brasen
> > > via
> > > > groups.io
> > > > 发送时间: 2022年6月15日 1:54
> > > > 收件人: devel@edk2.groups.io
> > > > 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > > > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen
> > > > <jbrasen@nvidia.com>
> > > > 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add
> > > Disk
> > > > Info support for Ufs
> > > >
> > > > Add support for getting disk info from UFS devices.
> > > >
> > > > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > > > ---
> > > >  MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c    | 3
> > > > ++-
> > > >  MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf |
> > 1
> > > +
> > > >  2 files changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git
> > > > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > > index fac33b9ee9..87b82f299f 100644
> > > > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > > +++
> > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> > > >
> > > >
> > > >        BmEliminateExtraSpaces (Description);
> > > >
> > > >      }
> > > >
> > > > -  } else if (CompareGuid (&DiskInfo->Interface,
> > > > &gEfiDiskInfoScsiInterfaceGuid)) {
> > > >
> > > > +  } else if (CompareGuid (&DiskInfo->Interface,
> > > > &gEfiDiskInfoScsiInterfaceGuid) ||
> > > >
> > > > +             CompareGuid (&DiskInfo->Interface,
> > > > &gEfiDiskInfoUfsInterfaceGuid)) {
> > > >
> > > >      BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> > > >
> > > >      Status     = DiskInfo->Inquiry (
> > > >
> > > >                               DiskInfo,
> > > >
> > > > diff --git
> > > > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > > index fe05d5f1cc..2fc0a80a4e 100644
> > > > ---
> > > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > > +++
> > > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > > @@ -85,6 +85,7 @@
> > > >    gEfiDiskInfoIdeInterfaceGuid                  ##
> > > > SOMETIMES_CONSUMES ## GUID
> > > >
> > > >    gEfiDiskInfoScsiInterfaceGuid                 ##
> > > > SOMETIMES_CONSUMES ## GUID
> > > >
> > > >    gEfiDiskInfoSdMmcInterfaceGuid                ##
> > > > SOMETIMES_CONSUMES ## GUID
> > > >
> > > > +  gEfiDiskInfoUfsInterfaceGuid                  ##
> > > > SOMETIMES_CONSUMES ## GUID
> > > >
> > > >
> > > >
> > > >  [Protocols]
> > > >
> > > >    gEfiPciRootBridgeIoProtocolGuid               ## CONSUMES
> > > >
> > > > --
> > > > 2.25.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
>
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94795): https://edk2.groups.io/g/devel/message/94795
Mute This Topic: https://groups.io/mt/92484604/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
Posted by Jeff Brasen via groups.io 1 year, 9 months ago 
Just following up on my outstanding edk2 patches to check on status/review feedback.

Thanks,
Jeff

> -----Original Message-----
> From: Jeff Brasen <jbrasen@nvidia.com>
> Sent: Tuesday, June 14, 2022 11:54 AM
> To: devel@edk2.groups.io
> Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen
> <jbrasen@nvidia.com>
> Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info
> support for Ufs
> 
> Add support for getting disk info from UFS devices.
> 
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
>  MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c    | 3 ++-
>  MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> index fac33b9ee9..87b82f299f 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> 
> 
>        BmEliminateExtraSpaces (Description);
> 
>      }
> 
> -  } else if (CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoScsiInterfaceGuid)) {
> 
> +  } else if (CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoScsiInterfaceGuid) ||
> 
> +             CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoUfsInterfaceGuid)) {
> 
>      BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> 
>      Status     = DiskInfo->Inquiry (
> 
>                               DiskInfo,
> 
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> index fe05d5f1cc..2fc0a80a4e 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> +++
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -85,6 +85,7 @@
>    gEfiDiskInfoIdeInterfaceGuid                  ## SOMETIMES_CONSUMES ## GUID
> 
>    gEfiDiskInfoScsiInterfaceGuid                 ## SOMETIMES_CONSUMES ## GUID
> 
>    gEfiDiskInfoSdMmcInterfaceGuid                ## SOMETIMES_CONSUMES ##
> GUID
> 
> +  gEfiDiskInfoUfsInterfaceGuid                  ## SOMETIMES_CONSUMES ##
> GUID
> 
> 
> 
>  [Protocols]
> 
>    gEfiPciRootBridgeIoProtocolGuid               ## CONSUMES
> 
> --
> 2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91160): https://edk2.groups.io/g/devel/message/91160
Mute This Topic: https://groups.io/mt/91755004/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
Posted by Gao, Zhichao 1 year, 9 months ago 
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jeff
> Brasen via groups.io
> Sent: Friday, July 8, 2022 2:15 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Gao, Zhichao <zhichao.gao@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib:
> Add Disk Info support for Ufs
> 
> Just following up on my outstanding edk2 patches to check on status/review
> feedback.
> 
> Thanks,
> Jeff
> 
> > -----Original Message-----
> > From: Jeff Brasen <jbrasen@nvidia.com>
> > Sent: Tuesday, June 14, 2022 11:54 AM
> > To: devel@edk2.groups.io
> > Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen
> > <jbrasen@nvidia.com>
> > Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info
> > support for Ufs
> >
> > Add support for getting disk info from UFS devices.
> >
> > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > ---
> >  MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c    | 3
> ++-
> >  MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1
> +
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > index fac33b9ee9..87b82f299f 100644
> > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> >
> >
> >        BmEliminateExtraSpaces (Description);
> >
> >      }
> >
> > -  } else if (CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoScsiInterfaceGuid)) {
> >
> > +  } else if (CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoScsiInterfaceGuid) ||
> >
> > +             CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoUfsInterfaceGuid)) {
> >
> >      BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> >
> >      Status     = DiskInfo->Inquiry (
> >
> >                               DiskInfo,
> >
> > diff --git
> > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > index fe05d5f1cc..2fc0a80a4e 100644
> > ---
> a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > +++
> > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > @@ -85,6 +85,7 @@
> >    gEfiDiskInfoIdeInterfaceGuid                  ## SOMETIMES_CONSUMES ##
> GUID
> >
> >    gEfiDiskInfoScsiInterfaceGuid                 ## SOMETIMES_CONSUMES ##
> GUID
> >
> >    gEfiDiskInfoSdMmcInterfaceGuid                ## SOMETIMES_CONSUMES ##
> > GUID
> >
> > +  gEfiDiskInfoUfsInterfaceGuid                  ## SOMETIMES_CONSUMES ##
> > GUID
> >
> >
> >
> >  [Protocols]
> >
> >    gEfiPciRootBridgeIoProtocolGuid               ## CONSUMES
> >
> > --
> > 2.25.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#91440): https://edk2.groups.io/g/devel/message/91440
Mute This Topic: https://groups.io/mt/91755004/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.