[v1] Bug 3898 - S3 Resume result in executing garbage address

[edk2-devel] [PATCH] Bug 3898 - S3 Resume result in executing garbage address

Posted by cbduggap 2 years ago

In Release Build, Trying to execute ppi Function even after
Locate ppi failed.

Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
---
 MdeModulePkg/Core/DxeIplPeim/DxeLoad.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c b/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
index 2c19f1a507..d7f02df5f5 100644
--- a/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
+++ b/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
@@ -288,6 +288,7 @@ DxeLoadCore (
         EFI_ERROR_CODE | EFI_ERROR_MAJOR,
         (EFI_SOFTWARE_PEI_MODULE | EFI_SW_PEI_EC_S3_RESUME_PPI_NOT_FOUND)
         );
+      CpuDeadLoop ();
     }
 
     ASSERT_EFI_ERROR (Status);
-- 
2.36.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89252): https://edk2.groups.io/g/devel/message/89252
Mute This Topic: https://groups.io/mt/90678471/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Bug 3898 - S3 Resume result in executing garbage address

Posted by Wang, Jian J 2 years ago

Reviewed-by: Jian J Wang <jian.j.wang@intel.com>

Regards,
Jian

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of cbduggap
> Sent: Monday, April 25, 2022 12:39 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] Bug 3898 - S3 Resume result in executing garbage
> address
> 
> In Release Build, Trying to execute ppi Function even after
> Locate ppi failed.
> 
> Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
> ---
>  MdeModulePkg/Core/DxeIplPeim/DxeLoad.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> b/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> index 2c19f1a507..d7f02df5f5 100644
> --- a/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> +++ b/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> @@ -288,6 +288,7 @@ DxeLoadCore (
>          EFI_ERROR_CODE | EFI_ERROR_MAJOR,
> 
>          (EFI_SOFTWARE_PEI_MODULE |
> EFI_SW_PEI_EC_S3_RESUME_PPI_NOT_FOUND)
> 
>          );
> 
> +      CpuDeadLoop ();
> 
>      }
> 
> 
> 
>      ASSERT_EFI_ERROR (Status);
> 
> --
> 2.36.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#89252): https://edk2.groups.io/g/devel/message/89252
> Mute This Topic: https://groups.io/mt/90678471/1768734
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [jian.j.wang@intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89325): https://edk2.groups.io/g/devel/message/89325
Mute This Topic: https://groups.io/mt/90678471/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Bug 3898 - S3 Resume result in executing garbage address

Posted by Ni, Ray 2 years ago

Reviewed-by: Ray Ni <ray.ni@intel.com>
+ @Wang, Jian J

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of cbduggap
> Sent: Monday, April 25, 2022 12:39 PM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH] Bug 3898 - S3 Resume result in executing garbage address
> 
> In Release Build, Trying to execute ppi Function even after
> Locate ppi failed.
> 
> Signed-off-by: cbduggap <chinni.b.duggapu@intel.com>
> ---
>  MdeModulePkg/Core/DxeIplPeim/DxeLoad.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c b/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> index 2c19f1a507..d7f02df5f5 100644
> --- a/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> +++ b/MdeModulePkg/Core/DxeIplPeim/DxeLoad.c
> @@ -288,6 +288,7 @@ DxeLoadCore (
>          EFI_ERROR_CODE | EFI_ERROR_MAJOR,
> 
>          (EFI_SOFTWARE_PEI_MODULE | EFI_SW_PEI_EC_S3_RESUME_PPI_NOT_FOUND)
> 
>          );
> 
> +      CpuDeadLoop ();
> 
>      }
> 
> 
> 
>      ASSERT_EFI_ERROR (Status);
> 
> --
> 2.36.0.windows.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#89252): https://edk2.groups.io/g/devel/message/89252
> Mute This Topic: https://groups.io/mt/90678471/1712937
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#89253): https://edk2.groups.io/g/devel/message/89253
Mute This Topic: https://groups.io/mt/90678471/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-