[edk2-devel] [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py

Bjorge, Erik C posted 1 patch 4 years, 2 months ago
Failed in applying to current master (apply log)
build-scripts/build_linux_installer.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py
Posted by Bjorge, Erik C 4 years, 2 months ago
On Ubuntu the script final_copy.py was not able to run without
prepending ./ to the script name.

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 build-scripts/build_linux_installer.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build-scripts/build_linux_installer.py b/build-scripts/build_linux_installer.py
index 4501dec..0130552 100755
--- a/build-scripts/build_linux_installer.py
+++ b/build-scripts/build_linux_installer.py
@@ -55,7 +55,7 @@ def main():
 
     # Step 4: Package installer files
     try:
-        subprocess.run('final_copy.py', check=True)
+        subprocess.run(os.path.join('.', 'final_copy.py'), check=True)
     except:
         print('Failed to generate installer package')
         return 1
-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53434): https://edk2.groups.io/g/devel/message/53434
Mute This Topic: https://groups.io/mt/69995553/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py
Posted by Desimone, Ashley E 4 years, 2 months ago
Reviewed-by: Ashley Desimone <ashley.e.desimone@intel.com>

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bjorge, Erik C
Sent: Wednesday, January 22, 2020 1:55 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [edk2-devel] [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py

On Ubuntu the script final_copy.py was not able to run without prepending ./ to the script name.

Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
---
 build-scripts/build_linux_installer.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/build-scripts/build_linux_installer.py b/build-scripts/build_linux_installer.py
index 4501dec..0130552 100755
--- a/build-scripts/build_linux_installer.py
+++ b/build-scripts/build_linux_installer.py
@@ -55,7 +55,7 @@ def main():
 
     # Step 4: Package installer files
     try:
-        subprocess.run('final_copy.py', check=True)
+        subprocess.run(os.path.join('.', 'final_copy.py'), check=True)
     except:
         print('Failed to generate installer package')
         return 1
--
2.21.0.windows.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53455): https://edk2.groups.io/g/devel/message/53455
Mute This Topic: https://groups.io/mt/69995553/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/EdkRepo][PATCH v1] EdkRepo: Fixed execution of final_copy.py
Posted by Nate DeSimone 4 years, 2 months ago
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

On 1/22/20, 1:55 PM, "devel@edk2.groups.io on behalf of Bjorge, Erik C" <devel@edk2.groups.io on behalf of erik.c.bjorge@intel.com> wrote:

    On Ubuntu the script final_copy.py was not able to run without
    prepending ./ to the script name.
    
    Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
    Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
    Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
    Cc: Puja Pandya <puja.pandya@intel.com>
    Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
    ---
     build-scripts/build_linux_installer.py | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/build-scripts/build_linux_installer.py b/build-scripts/build_linux_installer.py
    index 4501dec..0130552 100755
    --- a/build-scripts/build_linux_installer.py
    +++ b/build-scripts/build_linux_installer.py
    @@ -55,7 +55,7 @@ def main():
     
         # Step 4: Package installer files
         try:
    -        subprocess.run('final_copy.py', check=True)
    +        subprocess.run(os.path.join('.', 'final_copy.py'), check=True)
         except:
             print('Failed to generate installer package')
             return 1
    -- 
    2.21.0.windows.1
    
    
    
    
    


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53594): https://edk2.groups.io/g/devel/message/53594
Mute This Topic: https://groups.io/mt/69995553/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-