[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Add timing for commands

Bjorge, Erik C posted 1 patch 3 years, 6 months ago
Failed in applying to current master (apply log)
edkrepo/edkrepo_entry_point.py | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Add timing for commands
Posted by Bjorge, Erik C 3 years, 6 months ago
Added command timing in the entry point.

Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
---
 edkrepo/edkrepo_entry_point.py | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/edkrepo/edkrepo_entry_point.py b/edkrepo/edkrepo_entry_point.py
index dd2b36e..e944b7a 100644
--- a/edkrepo/edkrepo_entry_point.py
+++ b/edkrepo/edkrepo_entry_point.py
@@ -82,8 +82,11 @@ if __name__ == "__main__" or run_via_launcher_script:
                     sys.exit(1)
 
 from edkrepo.config.config_factory import GlobalConfig
+import datetime as dt
+
 
 def main():
+    start = dt.datetime.now()
     cfg_file = GlobalConfig()
     pref_entry = (cfg_file.preferred_entry[0]).replace('.py', '')
     pref_entry_func = cfg_file.preferred_entry[1]
@@ -91,12 +94,15 @@ def main():
     try:
         mod = importlib.import_module(pref_entry)
         func = getattr(mod, pref_entry_func)
-        return(func())
-    except Exception as e:
+        ret_code = func()
+    except Exception:
         print('Unable to launch preferred entry point. Launching default entry point edkrepo.edkrepo_cli.py')
         traceback.print_exc()
         import edkrepo.edkrepo_cli
-        return edkrepo.edkrepo_cli.main()
+        ret_code = edkrepo.edkrepo_cli.main()
+    print('\nExecution Time: {}'.format(dt.datetime.now() - start))
+    return ret_code
+
 
 if __name__ == "__main__":
     try:
-- 
2.21.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65850): https://edk2.groups.io/g/devel/message/65850
Mute This Topic: https://groups.io/mt/77267822/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Add timing for commands
Posted by Nate DeSimone 3 years, 6 months ago
I don't think we should print execution time every time. Maybe a --performance flag or something to that effect?

> -----Original Message-----
> From: Erik Bjorge <erik.c.bjorge@intel.com>
> Sent: Friday, October 2, 2020 11:21 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone,
> Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja
> <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>;
> Agyeman, Prince <prince.agyeman@intel.com>
> Subject: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Add timing for
> commands
> 
> Added command timing in the entry point.
> 
> Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Puja Pandya <puja.pandya@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Cc: Erik Bjorge <erik.c.bjorge@intel.com>
> Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
> ---
>  edkrepo/edkrepo_entry_point.py | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/edkrepo/edkrepo_entry_point.py
> b/edkrepo/edkrepo_entry_point.py index dd2b36e..e944b7a 100644
> --- a/edkrepo/edkrepo_entry_point.py
> +++ b/edkrepo/edkrepo_entry_point.py
> @@ -82,8 +82,11 @@ if __name__ == "__main__" or
> run_via_launcher_script:
>                      sys.exit(1)
> 
>  from edkrepo.config.config_factory import GlobalConfig
> +import datetime as dt
> +
> 
>  def main():
> +    start = dt.datetime.now()
>      cfg_file = GlobalConfig()
>      pref_entry = (cfg_file.preferred_entry[0]).replace('.py', '')
>      pref_entry_func = cfg_file.preferred_entry[1] @@ -91,12 +94,15 @@ def
> main():
>      try:
>          mod = importlib.import_module(pref_entry)
>          func = getattr(mod, pref_entry_func)
> -        return(func())
> -    except Exception as e:
> +        ret_code = func()
> +    except Exception:
>          print('Unable to launch preferred entry point. Launching default entry
> point edkrepo.edkrepo_cli.py')
>          traceback.print_exc()
>          import edkrepo.edkrepo_cli
> -        return edkrepo.edkrepo_cli.main()
> +        ret_code = edkrepo.edkrepo_cli.main()
> +    print('\nExecution Time: {}'.format(dt.datetime.now() - start))
> +    return ret_code
> +
> 
>  if __name__ == "__main__":
>      try:
> --
> 2.21.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65851): https://edk2.groups.io/g/devel/message/65851
Mute This Topic: https://groups.io/mt/77267822/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-