1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.

Bjorge, Erik C posted 1 patch 3 years, 10 months ago
Failed in applying to current master (apply log)
edkrepo/commands/checkout_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.
Posted by Bjorge, Erik C 3 years, 10 months ago 
Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
---
 edkrepo/commands/checkout_command.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edkrepo/commands/checkout_command.py b/edkrepo/commands/checkout_command.py
index f4483d4..0169f30 100644
--- a/edkrepo/commands/checkout_command.py
+++ b/edkrepo/commands/checkout_command.py
@@ -44,4 +44,4 @@ class CheckoutCommand(EdkrepoCommand):
         if combination_is_in_manifest(args.Combination, get_workspace_manifest()):
             checkout(args.Combination, args.verbose, args.override)
         else:
-            raise EdkrepoInvalidParametersException(humble.NO_COMBO)
+            raise EdkrepoInvalidParametersException(humble.NO_COMBO.format(args.Combination))
-- 
2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61097): https://edk2.groups.io/g/devel/message/61097
Mute This Topic: https://groups.io/mt/74807241/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.
Posted by Ashley E Desimone 3 years, 10 months ago 
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>

-----Original Message-----
From: Bjorge, Erik C <erik.c.bjorge@intel.com> 
Sent: Wednesday, June 10, 2020 3:07 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.

Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
---
 edkrepo/commands/checkout_command.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edkrepo/commands/checkout_command.py b/edkrepo/commands/checkout_command.py
index f4483d4..0169f30 100644
--- a/edkrepo/commands/checkout_command.py
+++ b/edkrepo/commands/checkout_command.py
@@ -44,4 +44,4 @@ class CheckoutCommand(EdkrepoCommand):
         if combination_is_in_manifest(args.Combination, get_workspace_manifest()):

             checkout(args.Combination, args.verbose, args.override)

         else:

-            raise EdkrepoInvalidParametersException(humble.NO_COMBO)

+            raise EdkrepoInvalidParametersException(humble.NO_COMBO.format(args.Combination))

-- 
2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61104): https://edk2.groups.io/g/devel/message/61104
Mute This Topic: https://groups.io/mt/74807241/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.
Posted by Nate DeSimone 3 years, 10 months ago 
Pushed: https://github.com/tianocore/edk2-staging/commit/3e6b805a

-----Original Message-----
From: Bjorge, Erik C <erik.c.bjorge@intel.com> 
Sent: Wednesday, June 10, 2020 3:07 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.

Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
---
 edkrepo/commands/checkout_command.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edkrepo/commands/checkout_command.py b/edkrepo/commands/checkout_command.py
index f4483d4..0169f30 100644
--- a/edkrepo/commands/checkout_command.py
+++ b/edkrepo/commands/checkout_command.py
@@ -44,4 +44,4 @@ class CheckoutCommand(EdkrepoCommand):
         if combination_is_in_manifest(args.Combination, get_workspace_manifest()):

             checkout(args.Combination, args.verbose, args.override)

         else:

-            raise EdkrepoInvalidParametersException(humble.NO_COMBO)

+            raise EdkrepoInvalidParametersException(humble.NO_COMBO.format(args.Combination))

-- 
2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61346): https://edk2.groups.io/g/devel/message/61346
Mute This Topic: https://groups.io/mt/74807241/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.
Posted by Nate DeSimone 3 years, 10 months ago 
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Bjorge, Erik C <erik.c.bjorge@intel.com> 
Sent: Wednesday, June 10, 2020 3:07 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.

Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
---
 edkrepo/commands/checkout_command.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edkrepo/commands/checkout_command.py b/edkrepo/commands/checkout_command.py
index f4483d4..0169f30 100644
--- a/edkrepo/commands/checkout_command.py
+++ b/edkrepo/commands/checkout_command.py
@@ -44,4 +44,4 @@ class CheckoutCommand(EdkrepoCommand):
         if combination_is_in_manifest(args.Combination, get_workspace_manifest()):

             checkout(args.Combination, args.verbose, args.override)

         else:

-            raise EdkrepoInvalidParametersException(humble.NO_COMBO)

+            raise EdkrepoInvalidParametersException(humble.NO_COMBO.format(args.Combination))

-- 
2.27.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#61345): https://edk2.groups.io/g/devel/message/61345
Mute This Topic: https://groups.io/mt/74807241/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.