1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid

GuoMinJ posted 1 patch 5 years, 11 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
MdeModulePkg/MdeModulePkg.ci.yaml             | 1 -
MdeModulePkg/MdeModulePkg.dec                 | 1 -
MdePkg/MdePkg.ci.yaml                         | 1 -
4 files changed, 4 deletions(-)
[edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid
Posted by GuoMinJ 5 years, 11 months ago 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145

Replace the gEfiFormBrowserExProtocolGuid with
gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration.

Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
---
 MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
 MdeModulePkg/MdeModulePkg.ci.yaml             | 1 -
 MdeModulePkg/MdeModulePkg.dec                 | 1 -
 MdePkg/MdePkg.ci.yaml                         | 1 -
 4 files changed, 4 deletions(-)

diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
index c36aa6bdf1..e7e7cd18ab 100644
--- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
+++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
@@ -143,7 +143,6 @@ struct _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL {
   SAVE_REMINDER          SaveReminder;
 };
 
-extern EFI_GUID gEfiFormBrowserExProtocolGuid;
 extern EFI_GUID gEdkiiFormBrowserExProtocolGuid;
 
 #endif
diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePkg.ci.yaml
index 3b6e747075..d8cd13b384 100644
--- a/MdeModulePkg/MdeModulePkg.ci.yaml
+++ b/MdeModulePkg/MdeModulePkg.ci.yaml
@@ -53,7 +53,6 @@
         "IgnoreGuidValue": ["00000000-0000-0000-0000-000000000000"],
         "IgnoreFoldersAndFiles": [],
         "IgnoreDuplicates": [
-            "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
             "gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
             "gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid",
         ]
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 91a3c60823..73ff177434 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -526,7 +526,6 @@
   gEfiLockBoxProtocolGuid        = { 0xbd445d79, 0xb7ad, 0x4f04, { 0x9a, 0xd8, 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }}
 
   ## Include/Protocol/FormBrowserEx.h
-  gEfiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1, 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
   gEdkiiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1, 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
 
   ## Include/Protocol/EbcVmTest.h
diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
index 88e490fcb6..3268f15354 100644
--- a/MdePkg/MdePkg.ci.yaml
+++ b/MdePkg/MdePkg.ci.yaml
@@ -81,7 +81,6 @@
             "gEfiDebugPortProtocolGuid=gEfiDebugPortVariableGuid=gEfiDebugPortDevicePathGuid", ## is this a bug
             "gEfiProcessorSpecificErrorSectionGuid=gEfiIa32X64ProcessorErrorSectionGuid",  ## is this a bug
             "gEfiSmmPeriodicTimerDispatch2ProtocolGuid=gEfiMmPeriodicTimerDispatchProtocolGuid",
-            "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
             "gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
             "gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid"
             ]
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54708): https://edk2.groups.io/g/devel/message/54708
Mute This Topic: https://groups.io/mt/71448064/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid
Posted by Wu, Hao A 5 years, 10 months ago 
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Friday, February 21, 2020 6:11 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ
> Subject: [edk2-devel] [PATCH] MdeModulePkg: Remove
> gEfiFormBrowserExProtocolGuid Protocol Guid
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
> 
> Replace the gEfiFormBrowserExProtocolGuid with
> gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration.
> 
> Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> ---
>  MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
>  MdeModulePkg/MdeModulePkg.ci.yaml             | 1 -
>  MdeModulePkg/MdeModulePkg.dec                 | 1 -
>  MdePkg/MdePkg.ci.yaml                         | 1 -
>  4 files changed, 4 deletions(-)
> 
> diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> index c36aa6bdf1..e7e7cd18ab 100644
> --- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> +++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> @@ -143,7 +143,6 @@ struct
> _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL {
>    SAVE_REMINDER          SaveReminder;
>  };
> 
> -extern EFI_GUID gEfiFormBrowserExProtocolGuid;
>  extern EFI_GUID gEdkiiFormBrowserExProtocolGuid;
> 
>  #endif
> diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml
> b/MdeModulePkg/MdeModulePkg.ci.yaml
> index 3b6e747075..d8cd13b384 100644
> --- a/MdeModulePkg/MdeModulePkg.ci.yaml
> +++ b/MdeModulePkg/MdeModulePkg.ci.yaml
> @@ -53,7 +53,6 @@
>          "IgnoreGuidValue": ["00000000-0000-0000-0000-000000000000"],
>          "IgnoreFoldersAndFiles": [],
>          "IgnoreDuplicates": [
> -            "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
>              "gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
>              "gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid",
>          ]
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index 91a3c60823..73ff177434 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -526,7 +526,6 @@
>    gEfiLockBoxProtocolGuid        = { 0xbd445d79, 0xb7ad, 0x4f04, { 0x9a, 0xd8,
> 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }}
> 
>    ## Include/Protocol/FormBrowserEx.h
> -  gEfiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1,
> 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
>    gEdkiiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1,
> 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
> 
>    ## Include/Protocol/EbcVmTest.h
> diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
> index 88e490fcb6..3268f15354 100644
> --- a/MdePkg/MdePkg.ci.yaml
> +++ b/MdePkg/MdePkg.ci.yaml
> @@ -81,7 +81,6 @@
> 
> "gEfiDebugPortProtocolGuid=gEfiDebugPortVariableGuid=gEfiDebugPortDevice
> PathGuid", ## is this a bug
> 
> "gEfiProcessorSpecificErrorSectionGuid=gEfiIa32X64ProcessorErrorSectionGuid
> ",  ## is this a bug
> 
> "gEfiSmmPeriodicTimerDispatch2ProtocolGuid=gEfiMmPeriodicTimerDispatchP
> rotocolGuid",
> -            "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",


Acked-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


>              "gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
>              "gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid"
>              ]
> --
> 2.17.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56431): https://edk2.groups.io/g/devel/message/56431
Mute This Topic: https://groups.io/mt/71448064/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid Protocol Guid
Posted by Wu, Hao A 5 years, 10 months ago 
> -----Original Message-----
> From: Wu, Hao A
> Sent: Friday, March 27, 2020 8:48 AM
> To: devel@edk2.groups.io; newexplorerj@gmail.com
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg: Remove
> gEfiFormBrowserExProtocolGuid Protocol Guid
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > GuoMinJ
> > Sent: Friday, February 21, 2020 6:11 PM
> > To: devel@edk2.groups.io
> > Cc: GuoMinJ
> > Subject: [edk2-devel] [PATCH] MdeModulePkg: Remove
> > gEfiFormBrowserExProtocolGuid Protocol Guid
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145
> >
> > Replace the gEfiFormBrowserExProtocolGuid with
> > gEdkiiFormBrowserExProtocolGuid, remove the unnecessary declaration.
> >
> > Signed-off-by: GuoMinJ <newexplorerj@gmail.com>
> > ---
> >  MdeModulePkg/Include/Protocol/FormBrowserEx.h | 1 -
> >  MdeModulePkg/MdeModulePkg.ci.yaml             | 1 -
> >  MdeModulePkg/MdeModulePkg.dec                 | 1 -
> >  MdePkg/MdePkg.ci.yaml                         | 1 -
> >  4 files changed, 4 deletions(-)
> >
> > diff --git a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> > b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> > index c36aa6bdf1..e7e7cd18ab 100644
> > --- a/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> > +++ b/MdeModulePkg/Include/Protocol/FormBrowserEx.h
> > @@ -143,7 +143,6 @@ struct
> > _EDKII_FORM_BROWSER_EXTENSION_PROTOCOL {
> >    SAVE_REMINDER          SaveReminder;
> >  };
> >
> > -extern EFI_GUID gEfiFormBrowserExProtocolGuid;
> >  extern EFI_GUID gEdkiiFormBrowserExProtocolGuid;
> >
> >  #endif
> > diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml
> > b/MdeModulePkg/MdeModulePkg.ci.yaml
> > index 3b6e747075..d8cd13b384 100644
> > --- a/MdeModulePkg/MdeModulePkg.ci.yaml
> > +++ b/MdeModulePkg/MdeModulePkg.ci.yaml
> > @@ -53,7 +53,6 @@
> >          "IgnoreGuidValue": ["00000000-0000-0000-0000-000000000000"],
> >          "IgnoreFoldersAndFiles": [],
> >          "IgnoreDuplicates": [
> > -
> "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
> >              "gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
> >              "gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid",
> >          ]
> > diff --git a/MdeModulePkg/MdeModulePkg.dec
> > b/MdeModulePkg/MdeModulePkg.dec
> > index 91a3c60823..73ff177434 100644
> > --- a/MdeModulePkg/MdeModulePkg.dec
> > +++ b/MdeModulePkg/MdeModulePkg.dec
> > @@ -526,7 +526,6 @@
> >    gEfiLockBoxProtocolGuid        = { 0xbd445d79, 0xb7ad, 0x4f04, { 0x9a, 0xd8,
> > 0x29, 0xbd, 0x20, 0x40, 0xeb, 0x3c }}
> >
> >    ## Include/Protocol/FormBrowserEx.h
> > -  gEfiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1,
> > 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
> >    gEdkiiFormBrowserExProtocolGuid = { 0x1f73b18d, 0x4630, 0x43c1, { 0xa1,
> > 0xde, 0x6f, 0x80, 0x85, 0x5d, 0x7d, 0xa4 } }
> >
> >    ## Include/Protocol/EbcVmTest.h
> > diff --git a/MdePkg/MdePkg.ci.yaml b/MdePkg/MdePkg.ci.yaml
> > index 88e490fcb6..3268f15354 100644
> > --- a/MdePkg/MdePkg.ci.yaml
> > +++ b/MdePkg/MdePkg.ci.yaml
> > @@ -81,7 +81,6 @@
> >
> >
> "gEfiDebugPortProtocolGuid=gEfiDebugPortVariableGuid=gEfiDebugPortDevice
> > PathGuid", ## is this a bug
> >
> >
> "gEfiProcessorSpecificErrorSectionGuid=gEfiIa32X64ProcessorErrorSectionGuid
> > ",  ## is this a bug
> >
> >
> "gEfiSmmPeriodicTimerDispatch2ProtocolGuid=gEfiMmPeriodicTimerDispatchP
> > rotocolGuid",
> > -
> "gEdkiiFormBrowserExProtocolGuid=gEfiFormBrowserExProtocolGuid",
> 
> 
> Acked-by: Hao A Wu <hao.a.wu@intel.com>


Patch pushed via commit d4e2909bfc.

Best Regards,
Hao Wu


> 
> Best Regards,
> Hao Wu
> 
> 
> >              "gEfiPeiMmAccessPpiGuid=gPeiSmmAccessPpiGuid",
> >              "gPeiSmmControlPpiGuid=gEfiPeiMmControlPpiGuid"
> >              ]
> > --
> > 2.17.1
> >
> >
> > 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56583): https://edk2.groups.io/g/devel/message/56583
Mute This Topic: https://groups.io/mt/71448064/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.