ArmPlatformPkg/Ds5: Increase path length to 400

[edk2-devel] [PATCH] ArmPlatformPkg/Ds5: Increase path length to 400

Posted by Jeff Brasen 4 years, 2 months ago

Increase length of path that can be read from system from 200 to 400 to
allow for longer build paths.

Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
 ArmPlatformPkg/Scripts/Ds5/firmware_volume.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py b/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
index 9c06835776..c6d1ca830a 100644
--- a/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
+++ b/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
@@ -81,7 +81,7 @@ class EfiSectionTE:
             filename = self.base_te + debug_rva + 0xc
         else:
             filename = self.base_te + debug_rva + 0x10
-        filename = struct.unpack("200s", self.ec.getMemoryService().read(filename, 200, 32))[0]
+        filename = struct.unpack("400s", self.ec.getMemoryService().read(filename, 400, 32))[0]
         return filename[0:string.find(filename,'\0')]
 
     def get_debug_elfbase(self):
@@ -119,7 +119,7 @@ class EfiSectionPE32:
             filename = self.base_pe32 + debug_rva + 0xc
         else:
             filename = self.base_pe32 + debug_rva + 0x10
-        filename = struct.unpack("200s", self.ec.getMemoryService().read(str(filename), 200, 32))[0]
+        filename = struct.unpack("400s", self.ec.getMemoryService().read(str(filename), 400, 32))[0]
         return filename[0:string.find(filename,'\0')]
 
     def get_debug_elfbase(self):
@@ -154,7 +154,7 @@ class EfiSectionPE64:
             filename = self.base_pe64 + debug_rva + 0xc
         else:
             filename = self.base_pe64 + debug_rva + 0x10
-        filename = struct.unpack("200s", self.ec.getMemoryService().read(str(filename), 200, 32))[0]
+        filename = struct.unpack("400s", self.ec.getMemoryService().read(str(filename), 400, 32))[0]
         return filename[0:string.find(filename,'\0')]
 
     def get_debug_elfbase(self):
-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54090): https://edk2.groups.io/g/devel/message/54090
Mute This Topic: https://groups.io/mt/71065323/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] ArmPlatformPkg/Ds5: Increase path length to 400

Posted by Ard Biesheuvel 4 years, 2 months ago

On Fri, 7 Feb 2020 at 21:32, Jeff Brasen <jbrasen@nvidia.com> wrote:
>
> Increase length of path that can be read from system from 200 to 400 to
> allow for longer build paths.
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>

Thanks Jeff

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed to EDK2 master


> ---
>  ArmPlatformPkg/Scripts/Ds5/firmware_volume.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py b/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
> index 9c06835776..c6d1ca830a 100644
> --- a/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
> +++ b/ArmPlatformPkg/Scripts/Ds5/firmware_volume.py
> @@ -81,7 +81,7 @@ class EfiSectionTE:
>              filename = self.base_te + debug_rva + 0xc
>          else:
>              filename = self.base_te + debug_rva + 0x10
> -        filename = struct.unpack("200s", self.ec.getMemoryService().read(filename, 200, 32))[0]
> +        filename = struct.unpack("400s", self.ec.getMemoryService().read(filename, 400, 32))[0]
>          return filename[0:string.find(filename,'\0')]
>
>      def get_debug_elfbase(self):
> @@ -119,7 +119,7 @@ class EfiSectionPE32:
>              filename = self.base_pe32 + debug_rva + 0xc
>          else:
>              filename = self.base_pe32 + debug_rva + 0x10
> -        filename = struct.unpack("200s", self.ec.getMemoryService().read(str(filename), 200, 32))[0]
> +        filename = struct.unpack("400s", self.ec.getMemoryService().read(str(filename), 400, 32))[0]
>          return filename[0:string.find(filename,'\0')]
>
>      def get_debug_elfbase(self):
> @@ -154,7 +154,7 @@ class EfiSectionPE64:
>              filename = self.base_pe64 + debug_rva + 0xc
>          else:
>              filename = self.base_pe64 + debug_rva + 0x10
> -        filename = struct.unpack("200s", self.ec.getMemoryService().read(str(filename), 200, 32))[0]
> +        filename = struct.unpack("400s", self.ec.getMemoryService().read(str(filename), 400, 32))[0]
>          return filename[0:string.find(filename,'\0')]
>
>      def get_debug_elfbase(self):
> --
> 2.17.1
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54094): https://edk2.groups.io/g/devel/message/54094
Mute This Topic: https://groups.io/mt/71065323/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-