ShellPkg/PrintInfo.c:Add two additional DWORD show for smbios 3.3.0 type17

[edk2-devel] [PATCH] ShellPkg/PrintInfo.c:Add two additional DWORD show for smbios 3.3.0 type17

Posted by Enze Zhu 5 years, 3 months ago

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2952

In MdePkg/SmBios.h,there are two additional DWORD added
for type 17,but these two DWORD do not show in SmbiosView,
So add them.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
Reviewed-by: Liming Gao <liming.gao@intel.com>
---
 .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c      | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index 7517465ddd..4dd029d6b4 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -795,6 +795,13 @@ SmbiosPrintStructure (
         PRINT_STRUCT_VALUE_LH (Struct, Type17, LogicalSize);
       }
     }
+    //
+    // Add for smbios 3.3.0
+    //
+    if (AE_SMBIOS_VERSION (0x3, 0x3) && (Struct->Hdr->Length > 0x54)) {
+      PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedSpeed);
+      PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedConfiguredMemorySpeed);
+    }
     break;
 
   //
-- 
2.27.0.windows.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66729): https://edk2.groups.io/g/devel/message/66729
Mute This Topic: https://groups.io/mt/77881887/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

回复: [edk2-devel] [PATCH] ShellPkg/PrintInfo.c:Add two additional DWORD show for smbios 3.3.0 type17

Posted by gaoliming 5 years, 3 months ago

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: bounce+27952+66729+4905953+8761045@groups.io
> <bounce+27952+66729+4905953+8761045@groups.io> 代表 Enze Zhu
> 发送时间: 2020年10月29日 14:14
> 收件人: devel@edk2.groups.io
> 抄送: Ray Ni <ray.ni@intel.com>; Zhichao Gao <zhichao.gao@intel.com>;
> Liming Gao <liming.gao@intel.com>
> 主题: [edk2-devel] [PATCH] ShellPkg/PrintInfo.c:Add two additional DWORD
> show for smbios 3.3.0 type17
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2952
> 
> In MdePkg/SmBios.h,there are two additional DWORD added
> for type 17,but these two DWORD do not show in SmbiosView,
> So add them.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Enze Zhu <zhuenze@byosoft.com.cn>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> ---
>  .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c      | 7
> +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index 7517465ddd..4dd029d6b4 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -795,6 +795,13 @@ SmbiosPrintStructure (
>          PRINT_STRUCT_VALUE_LH (Struct, Type17, LogicalSize);
>        }
>      }
> +    //
> +    // Add for smbios 3.3.0
> +    //
> +    if (AE_SMBIOS_VERSION (0x3, 0x3) && (Struct->Hdr->Length > 0x54)) {
> +      PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedSpeed);
> +      PRINT_STRUCT_VALUE_H (Struct, Type17,
> ExtendedConfiguredMemorySpeed);
> +    }
>      break;
> 
>    //
> --
> 2.27.0.windows.1
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#66888): https://edk2.groups.io/g/devel/message/66888
Mute This Topic: https://groups.io/mt/77996896/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-