UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array

[edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array

Posted by Lendacky, Thomas 2 years, 11 months ago

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3373

An update to expand the mExceptionNameStr array failed to add a comma
after original last entry, therefore causing the #CP name to have extra
incorrect characters and the remaining entries to be indexed incorrectly
(off by 1).

Add a comma after the "#CP" entry to resolve this issue.

Fixes: 5277540e37e88a1a69f9517c4ad895051b4b3ed3
Cc: Allen Wynn <Allen_Wynn@Dell.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
 UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
index c9003b10e552..49d0041e2ff3 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
@@ -44,7 +44,7 @@ CONST CHAR8 *mExceptionNameStr[] = {
   "#MC - Machine-Check",
   "#XM - SIMD floating-point",
   "#VE - Virtualization",
-  "#CP - Control Protection"
+  "#CP - Control Protection",
   "Reserved",
   "Reserved",
   "Reserved",
-- 
2.31.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75097): https://edk2.groups.io/g/devel/message/75097
Mute This Topic: https://groups.io/mt/82801916/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array

Posted by Laszlo Ersek 2 years, 11 months ago

On 05/13/21 17:26, Lendacky, Thomas wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3373
> 
> An update to expand the mExceptionNameStr array failed to add a comma
> after original last entry, therefore causing the #CP name to have extra
> incorrect characters and the remaining entries to be indexed incorrectly
> (off by 1).
> 
> Add a comma after the "#CP" entry to resolve this issue.
> 
> Fixes: 5277540e37e88a1a69f9517c4ad895051b4b3ed3
> Cc: Allen Wynn <Allen_Wynn@Dell.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> index c9003b10e552..49d0041e2ff3 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> @@ -44,7 +44,7 @@ CONST CHAR8 *mExceptionNameStr[] = {
>    "#MC - Machine-Check",
>    "#XM - SIMD floating-point",
>    "#VE - Virtualization",
> -  "#CP - Control Protection"
> +  "#CP - Control Protection",
>    "Reserved",
>    "Reserved",
>    "Reserved",
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75114): https://edk2.groups.io/g/devel/message/75114
Mute This Topic: https://groups.io/mt/82801916/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array

Posted by Laszlo Ersek 2 years, 11 months ago

On 05/13/21 17:26, Lendacky, Thomas wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3373
> 
> An update to expand the mExceptionNameStr array failed to add a comma
> after original last entry, therefore causing the #CP name to have extra
> incorrect characters and the remaining entries to be indexed incorrectly
> (off by 1).
> 
> Add a comma after the "#CP" entry to resolve this issue.
> 
> Fixes: 5277540e37e88a1a69f9517c4ad895051b4b3ed3
> Cc: Allen Wynn <Allen_Wynn@Dell.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
>  UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> index c9003b10e552..49d0041e2ff3 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> @@ -44,7 +44,7 @@ CONST CHAR8 *mExceptionNameStr[] = {
>    "#MC - Machine-Check",
>    "#XM - SIMD floating-point",
>    "#VE - Virtualization",
> -  "#CP - Control Protection"
> +  "#CP - Control Protection",
>    "Reserved",
>    "Reserved",
>    "Reserved",
> 

Merged as commit 32928415e36b, via
<https://github.com/tianocore/edk2/pull/1644>.

Thanks,
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75115): https://edk2.groups.io/g/devel/message/75115
Mute This Topic: https://groups.io/mt/82801916/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-