edkrepo/commands/sync_command.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
The repo name was being passed in instead of the path the repo. This
caused all commit templates to be flagged as warnings.
Cc: Ashley E Desimone <ashley.e.desimone@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com>
---
edkrepo/commands/sync_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/sync_command.py b/edkrepo/commands/sync_command.py
index da99397..02e915d 100644
--- a/edkrepo/commands/sync_command.py
+++ b/edkrepo/commands/sync_command.py
@@ -200,7 +200,7 @@ class SyncCommand(EdkrepoCommand):
# Perform submodule updates and url redirection
maintain_submodules(repo_to_sync, repo)
# Update commit message templates
- update_repo_commit_template(workspace_path, repo, repo_to_sync, config, source_global_manifest_repo)
+ update_repo_commit_template(workspace_path, repo, repo_to_sync, config, global_manifest_directory)
if sync_error:
print(SYNC_ERROR)
--
2.21.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#59721): https://edk2.groups.io/g/devel/message/59721
Mute This Topic: https://groups.io/mt/74282759/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com> -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bjorge, Erik C Sent: Sunday, May 17, 2020 5:51 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com> Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings The repo name was being passed in instead of the path the repo. This caused all commit templates to be flagged as warnings. Cc: Ashley E Desimone <ashley.e.desimone@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Puja Pandya <puja.pandya@intel.com> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> Cc: Prince Agyeman <prince.agyeman@intel.com> Cc: Erik Bjorge <erik.c.bjorge@intel.com> Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com> --- edkrepo/commands/sync_command.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edkrepo/commands/sync_command.py b/edkrepo/commands/sync_command.py index da99397..02e915d 100644 --- a/edkrepo/commands/sync_command.py +++ b/edkrepo/commands/sync_command.py @@ -200,7 +200,7 @@ class SyncCommand(EdkrepoCommand): # Perform submodule updates and url redirection maintain_submodules(repo_to_sync, repo) # Update commit message templates - update_repo_commit_template(workspace_path, repo, repo_to_sync, config, source_global_manifest_repo) + update_repo_commit_template(workspace_path, repo, + repo_to_sync, config, global_manifest_directory) if sync_error: print(SYNC_ERROR) -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59768): https://edk2.groups.io/g/devel/message/59768 Mute This Topic: https://groups.io/mt/74282759/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Pushed: 39c498261c -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bjorge, Erik C Sent: Sunday, May 17, 2020 5:51 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Agyeman, Prince <prince.agyeman@intel.com> Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed incorrect commit template warnings The repo name was being passed in instead of the path the repo. This caused all commit templates to be flagged as warnings. Cc: Ashley E Desimone <ashley.e.desimone@intel.com> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Puja Pandya <puja.pandya@intel.com> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com> Cc: Prince Agyeman <prince.agyeman@intel.com> Cc: Erik Bjorge <erik.c.bjorge@intel.com> Signed-off-by: Erik Bjorge <erik.c.bjorge@intel.com> --- edkrepo/commands/sync_command.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edkrepo/commands/sync_command.py b/edkrepo/commands/sync_command.py index da99397..02e915d 100644 --- a/edkrepo/commands/sync_command.py +++ b/edkrepo/commands/sync_command.py @@ -200,7 +200,7 @@ class SyncCommand(EdkrepoCommand): # Perform submodule updates and url redirection maintain_submodules(repo_to_sync, repo) # Update commit message templates - update_repo_commit_template(workspace_path, repo, repo_to_sync, config, source_global_manifest_repo) + update_repo_commit_template(workspace_path, repo, + repo_to_sync, config, global_manifest_directory) if sync_error: print(SYNC_ERROR) -- 2.21.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59769): https://edk2.groups.io/g/devel/message/59769 Mute This Topic: https://groups.io/mt/74282759/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.