[edk2-devel] [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build

Wenxing Hou posted 1 patch 1 month ago
Failed in applying to current master (apply log)
CryptoPkg/CryptoPkg.ci.yaml          | 1 +
CryptoPkg/Library/Include/inttypes.h | 9 +++++++++
2 files changed, 10 insertions(+)
create mode 100644 CryptoPkg/Library/Include/inttypes.h
[edk2-devel] [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build
Posted by Wenxing Hou 1 month ago
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4642

When use Mbedtls, there is a clang build error.
Add dummy inttypes header to fix clang build.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Yi Li <yi1.li@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
---
 CryptoPkg/CryptoPkg.ci.yaml          | 1 +
 CryptoPkg/Library/Include/inttypes.h | 9 +++++++++
 2 files changed, 10 insertions(+)
 create mode 100644 CryptoPkg/Library/Include/inttypes.h

diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml
index f961d85927..b601bcf85c 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -44,6 +44,7 @@
             # This has Mbedtls interfaces that aren't UEFI spec compliant
             "Library/Include/stdint.h",
             "Library/Include/stubs-32.h",
+            "Library/Include/inttypes.h",
             # These directories contain auto-generated OpenSSL content
             "Library/OpensslLib",
             "Library/IntrinsicLib",
diff --git a/CryptoPkg/Library/Include/inttypes.h b/CryptoPkg/Library/Include/inttypes.h
new file mode 100644
index 0000000000..3d44d8201d
--- /dev/null
+++ b/CryptoPkg/Library/Include/inttypes.h
@@ -0,0 +1,9 @@
+/** @file
+  Include file to support building the third-party cryptographic library.
+
+Copyright (c) 2024, Intel Corporation. All rights reserved.<BR>
+SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#include <CrtLibSupport.h>
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114115): https://edk2.groups.io/g/devel/message/114115
Mute This Topic: https://groups.io/mt/103849296/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build
Posted by Li, Yi 1 month ago

Looks good to me.
Reviewed-by: Yi Li <yi1.li@intel.com>


-----Original Message-----
From: Hou, Wenxing <wenxing.hou@intel.com> 
Sent: Saturday, January 20, 2024 9:45 PM
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Li, Yi1 <yi1.li@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Subject: [PATCH] CryptoPkg: Add dummy inttypes header to fix clang build

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4642

When use Mbedtls, there is a clang build error.
Add dummy inttypes header to fix clang build.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Yi Li <yi1.li@intel.com>
Cc: Guomin Jiang <guomin.jiang@intel.com>
Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
---
 CryptoPkg/CryptoPkg.ci.yaml          | 1 +
 CryptoPkg/Library/Include/inttypes.h | 9 +++++++++
 2 files changed, 10 insertions(+)
 create mode 100644 CryptoPkg/Library/Include/inttypes.h

diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml index f961d85927..b601bcf85c 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -44,6 +44,7 @@
             # This has Mbedtls interfaces that aren't UEFI spec compliant             "Library/Include/stdint.h",             "Library/Include/stubs-32.h",+            "Library/Include/inttypes.h",             # These directories contain auto-generated OpenSSL content             "Library/OpensslLib",             "Library/IntrinsicLib",diff --git a/CryptoPkg/Library/Include/inttypes.h b/CryptoPkg/Library/Include/inttypes.h
new file mode 100644
index 0000000000..3d44d8201d
--- /dev/null
+++ b/CryptoPkg/Library/Include/inttypes.h
@@ -0,0 +1,9 @@
+/** @file+  Include file to support building the third-party 
+cryptographic library.++Copyright (c) 2024, Intel Corporation. All 
+rights reserved.<BR>+SPDX-License-Identifier: 
+BSD-2-Clause-Patent++**/++#include <CrtLibSupport.h>--
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114123): https://edk2.groups.io/g/devel/message/114123
Mute This Topic: https://groups.io/mt/103849296/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-