UefiCpuPkg/Include/Library/MpInitLib.h | 2 ++ UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 ++ UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 20 ++++++++++++-------- UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf | 1 + 4 files changed, 17 insertions(+), 8 deletions(-)
Please ignore the V2 PATCH set. No other change except adding BaseMemoryLib headfile and lib instance in .inf to pass build since ZeroMem() is used. Comparing to the V1 patch set: In "set EXTENDED_PROCESSOR_INFORMATION to 0", set EXTENDED_PROCESSOR_INFORMATION to 0 in API MpInitLibGetProcessorInfo() of MpInitLibUp. This commit use ZeroMem() to set all fileds in output EFI_PROCESSOR_INFORMATION to 0 before StatusFlag field is reassigned. In "Check lower 24 bits of ProcessorNumber", use BIT24 instead of CPU_V2_EXTENDED_TOPOLOGY to clearly tell that processor number only occupies the lower 24 bits. Dun Tan (2): UefiCpuPkg: set EXTENDED_PROCESSOR_INFORMATION to 0 UefiCpuPkg: Check lower 24 bits of ProcessorNumber UefiCpuPkg/Include/Library/MpInitLib.h | 2 ++ UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 ++ UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 20 ++++++++++++-------- UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf | 1 + 4 files changed, 17 insertions(+), 8 deletions(-) -- 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113354): https://edk2.groups.io/g/devel/message/113354 Mute This Topic: https://groups.io/mt/103592277/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 1/8/24 06:08, duntan wrote: > Please ignore the V2 PATCH set. No other change except adding BaseMemoryLib headfile and lib instance in .inf to pass build since ZeroMem() is used. > > Comparing to the V1 patch set: > In "set EXTENDED_PROCESSOR_INFORMATION to 0", set EXTENDED_PROCESSOR_INFORMATION to 0 in API MpInitLibGetProcessorInfo() of MpInitLibUp. This commit use ZeroMem() to set all fileds in output EFI_PROCESSOR_INFORMATION to 0 before StatusFlag field is reassigned. > > In "Check lower 24 bits of ProcessorNumber", use BIT24 instead of CPU_V2_EXTENDED_TOPOLOGY to clearly tell that processor number only occupies the lower 24 bits. > > Dun Tan (2): > UefiCpuPkg: set EXTENDED_PROCESSOR_INFORMATION to 0 > UefiCpuPkg: Check lower 24 bits of ProcessorNumber > > UefiCpuPkg/Include/Library/MpInitLib.h | 2 ++ > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 ++ > UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 20 ++++++++++++-------- > UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf | 1 + > 4 files changed, 17 insertions(+), 8 deletions(-) > Merged as commit range f2b074398ca0..08a6528bac38, via <https://github.com/tianocore/edk2/pull/5240> (first two commits in the PR). BR Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113483): https://edk2.groups.io/g/devel/message/113483 Mute This Topic: https://groups.io/mt/103592277/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thank you so much! Thanks, Dun -----Original Message----- From: Laszlo Ersek <lersek@redhat.com> Sent: Wednesday, January 10, 2024 12:35 AM To: devel@edk2.groups.io; Tan, Dun <dun.tan@intel.com> Subject: Re: [edk2-devel] [Patch V3 0/2] Change the usage of input parameter ProcessorNumber in MpInitLibGetProcessorInfo() of MpInitLibUp On 1/8/24 06:08, duntan wrote: > Please ignore the V2 PATCH set. No other change except adding BaseMemoryLib headfile and lib instance in .inf to pass build since ZeroMem() is used. > > Comparing to the V1 patch set: > In "set EXTENDED_PROCESSOR_INFORMATION to 0", set EXTENDED_PROCESSOR_INFORMATION to 0 in API MpInitLibGetProcessorInfo() of MpInitLibUp. This commit use ZeroMem() to set all fileds in output EFI_PROCESSOR_INFORMATION to 0 before StatusFlag field is reassigned. > > In "Check lower 24 bits of ProcessorNumber", use BIT24 instead of CPU_V2_EXTENDED_TOPOLOGY to clearly tell that processor number only occupies the lower 24 bits. > > Dun Tan (2): > UefiCpuPkg: set EXTENDED_PROCESSOR_INFORMATION to 0 > UefiCpuPkg: Check lower 24 bits of ProcessorNumber > > UefiCpuPkg/Include/Library/MpInitLib.h | 2 ++ > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 ++ > UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 20 ++++++++++++-------- > UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf | 1 + > 4 files changed, 17 insertions(+), 8 deletions(-) > Merged as commit range f2b074398ca0..08a6528bac38, via <https://github.com/tianocore/edk2/pull/5240> (first two commits in the PR). BR Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113498): https://edk2.groups.io/g/devel/message/113498 Mute This Topic: https://groups.io/mt/103592277/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 1/8/24 06:08, duntan wrote: > Please ignore the V2 PATCH set. No other change except adding BaseMemoryLib headfile and lib instance in .inf to pass build since ZeroMem() is used. Reviewed-by: Laszlo Ersek <lersek@redhat.com> > > Comparing to the V1 patch set: > In "set EXTENDED_PROCESSOR_INFORMATION to 0", set EXTENDED_PROCESSOR_INFORMATION to 0 in API MpInitLibGetProcessorInfo() of MpInitLibUp. This commit use ZeroMem() to set all fileds in output EFI_PROCESSOR_INFORMATION to 0 before StatusFlag field is reassigned. > > In "Check lower 24 bits of ProcessorNumber", use BIT24 instead of CPU_V2_EXTENDED_TOPOLOGY to clearly tell that processor number only occupies the lower 24 bits. > > Dun Tan (2): > UefiCpuPkg: set EXTENDED_PROCESSOR_INFORMATION to 0 > UefiCpuPkg: Check lower 24 bits of ProcessorNumber > > UefiCpuPkg/Include/Library/MpInitLib.h | 2 ++ > UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 ++ > UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 20 ++++++++++++-------- > UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf | 1 + > 4 files changed, 17 insertions(+), 8 deletions(-) > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113388): https://edk2.groups.io/g/devel/message/113388 Mute This Topic: https://groups.io/mt/103592277/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.