This patch set contains minor fixes. diff from v1: original patch 4/4 with change related to BIOS resources provisioning removed. PR: https://github.com/tianocore/edk2-redfish-client/pull/64 Cc: Abner Chang <abner.chang@amd.com> Cc: Igor Kulchytskyy <igork@ami.com> Cc: Nickle Wang <nicklew@nvidia.com> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112657): https://edk2.groups.io/g/devel/message/112657 Mute This Topic: https://groups.io/mt/103255134/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
[AMD Official Use Only - General] Hi Mike, is https://bugzilla.tianocore.org/show_bug.cgi?id=4625 BZ ticket for this patch set? Abner > -----Original Message----- > From: Mike Maslenkin <mike.maslenkin@gmail.com> > Sent: Tuesday, December 19, 2023 9:00 AM > To: devel@edk2.groups.io > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com> > Subject: [edk2-redfish-client][PATCH v2 0/3] change method for provisioning > + minor fixes > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > This patch set contains minor fixes. > > diff from v1: > original patch 4/4 with change related to BIOS resources provisioning > removed. > > PR: https://github.com/tianocore/edk2-redfish-client/pull/64 > > Cc: Abner Chang <abner.chang@amd.com> > Cc: Igor Kulchytskyy <igork@ami.com> > Cc: Nickle Wang <nicklew@nvidia.com> > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113061): https://edk2.groups.io/g/devel/message/113061 Mute This Topic: https://groups.io/mt/103255134/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
[AMD Official Use Only - General] Hi Mike, According the conversation I had with Rebecca, please update your copyright that follow below format on the later patches you send; as you use the individual contributor copyright. Copyright (c) FIRST - LAST, Contributor <Contributor's email > <BR> Thanks Abner > -----Original Message----- > From: Mike Maslenkin <mike.maslenkin@gmail.com> > Sent: Tuesday, December 19, 2023 9:00 AM > To: devel@edk2.groups.io > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com; > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com> > Subject: [edk2-redfish-client][PATCH v2 0/3] change method for provisioning > + minor fixes > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > This patch set contains minor fixes. > > diff from v1: > original patch 4/4 with change related to BIOS resources provisioning > removed. > > PR: https://github.com/tianocore/edk2-redfish-client/pull/64 > > Cc: Abner Chang <abner.chang@amd.com> > Cc: Igor Kulchytskyy <igork@ami.com> > Cc: Nickle Wang <nicklew@nvidia.com> > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112663): https://edk2.groups.io/g/devel/message/112663 Mute This Topic: https://groups.io/mt/103255134/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=- Hmm, ok, thanks Rebecca. So that would be: Copyright (c) FIRST - LAST, Contributor <Contributor’s email > <BR> Thanks Abner > -----Original Message----- > From: Rebecca Cran <rebecca@bsdio.com> > Sent: Monday, December 18, 2023 1:37 PM > To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com> > Subject: Re: [edk2-devel] Copyright for an individual contributor > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 12/17/23 20:01, Chang, Abner via groups.io wrote: > > > > [AMD Official Use Only - General] > > > > > > Hi all, > > > > How do we have the copyright for the contribution from an individual? > > I don’t see the formatting defined in edk2 C coding standard. Is the > > below format ok? > > > > Copyright (c) 2023, Contributor <Contributor’s email > > > > > I think to follow the style guide, it should have a "<BR>" at the end, > though most files with copyrights from individuals don't have that. > > > -- > > Rebecca Cran
Hi Abner, Ok. I've already done it. But copyright change mentioned is for another patchset to edk2's RedfishPkg. Whereas you mentioned FIRST - LAST, would you like me to add copyrights for these changes? I guess LAST is not required for the new added code. I didn't add any copyrights previously, so for my case it would be: Copyright (c) 2023, Contributor <Contributor's email > <BR> in any place. Regard, Mike. On Tue, Dec 19, 2023 at 5:04 AM Chang, Abner <Abner.Chang@amd.com> wrote: > > [AMD Official Use Only - General] > > Hi Mike, > According the conversation I had with Rebecca, please update your copyright that follow below format on the later patches you send; as you use the individual contributor copyright. > > Copyright (c) FIRST - LAST, Contributor <Contributor's email > <BR> > > Thanks > Abner > > > -----Original Message----- > > From: Mike Maslenkin <mike.maslenkin@gmail.com> > > Sent: Tuesday, December 19, 2023 9:00 AM > > To: devel@edk2.groups.io > > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com; > > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com> > > Subject: [edk2-redfish-client][PATCH v2 0/3] change method for provisioning > > + minor fixes > > > > Caution: This message originated from an External Source. Use proper caution > > when opening attachments, clicking links, or responding. > > > > > > This patch set contains minor fixes. > > > > diff from v1: > > original patch 4/4 with change related to BIOS resources provisioning > > removed. > > > > PR: https://github.com/tianocore/edk2-redfish-client/pull/64 > > > > Cc: Abner Chang <abner.chang@amd.com> > > Cc: Igor Kulchytskyy <igork@ami.com> > > Cc: Nickle Wang <nicklew@nvidia.com> > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com> > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112666): https://edk2.groups.io/g/devel/message/112666 Mute This Topic: https://groups.io/mt/103255134/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
[AMD Official Use Only - General] Yes, Copyright (c) 2023, Contributor <Contributor's email > <BR> is good for you now. Abner > -----Original Message----- > From: Mike Maslenkin <mike.maslenkin@gmail.com> > Sent: Tuesday, December 19, 2023 10:40 AM > To: Chang, Abner <Abner.Chang@amd.com> > Cc: devel@edk2.groups.io; nicklew@nvidia.com; igork@ami.com > Subject: Re: [edk2-redfish-client][PATCH v2 0/3] change method for > provisioning + minor fixes > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Hi Abner, > > Ok. I've already done it. But copyright change mentioned is for > another patchset to edk2's RedfishPkg. > Whereas you mentioned FIRST - LAST, would you like me to add > copyrights for these changes? > I guess LAST is not required for the new added code. > I didn't add any copyrights previously, so for my case it would be: > Copyright (c) 2023, Contributor <Contributor's email > <BR> > in any place. > > Regard, > Mike. > > > > On Tue, Dec 19, 2023 at 5:04 AM Chang, Abner <Abner.Chang@amd.com> > wrote: > > > > [AMD Official Use Only - General] > > > > Hi Mike, > > According the conversation I had with Rebecca, please update your > copyright that follow below format on the later patches you send; as you use > the individual contributor copyright. > > > > Copyright (c) FIRST - LAST, Contributor <Contributor's email > <BR> > > > > Thanks > > Abner > > > > > -----Original Message----- > > > From: Mike Maslenkin <mike.maslenkin@gmail.com> > > > Sent: Tuesday, December 19, 2023 9:00 AM > > > To: devel@edk2.groups.io > > > Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com; > > > igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com> > > > Subject: [edk2-redfish-client][PATCH v2 0/3] change method for > provisioning > > > + minor fixes > > > > > > Caution: This message originated from an External Source. Use proper > caution > > > when opening attachments, clicking links, or responding. > > > > > > > > > This patch set contains minor fixes. > > > > > > diff from v1: > > > original patch 4/4 with change related to BIOS resources provisioning > > > removed. > > > > > > PR: https://github.com/tianocore/edk2-redfish-client/pull/64 > > > > > > Cc: Abner Chang <abner.chang@amd.com> > > > Cc: Igor Kulchytskyy <igork@ami.com> > > > Cc: Nickle Wang <nicklew@nvidia.com> > > > Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com> > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112673): https://edk2.groups.io/g/devel/message/112673 Mute This Topic: https://groups.io/mt/103255134/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.