[edk2-devel] [PATCH 4/4] ArmVirtPkg: Sync debug level comments in ArmVirt.dsc.inc

Rebecca Cran via groups.io posted 4 patches 2 years, 2 months ago
[edk2-devel] [PATCH 4/4] ArmVirtPkg: Sync debug level comments in ArmVirt.dsc.inc
Posted by Rebecca Cran via groups.io 2 years, 2 months ago
Update the debug level comments in ArmVirt.dsc.inc to sync with
MdePkg/Include/Library/DebugLib.h.

Signed-off-by: Rebecca Cran <rebecca@os.amperecomputing.com>
---
 ArmVirtPkg/ArmVirt.dsc.inc | 42 ++++++++++----------
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
index 6bc72f1decbd..9b23ef97ec5f 100644
--- a/ArmVirtPkg/ArmVirt.dsc.inc
+++ b/ArmVirtPkg/ArmVirt.dsc.inc
@@ -315,26 +315,28 @@ [PcdsFixedAtBuild.common]
   gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2f
 !endif
 
-  #  DEBUG_INIT      0x00000001  // Initialization
-  #  DEBUG_WARN      0x00000002  // Warnings
-  #  DEBUG_LOAD      0x00000004  // Load events
-  #  DEBUG_FS        0x00000008  // EFI File system
-  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)
-  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)
-  #  DEBUG_INFO      0x00000040  // Informational debug messages
-  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE/SMM Dispatchers
-  #  DEBUG_VARIABLE  0x00000100  // Variable
-  #  DEBUG_BM        0x00000400  // Boot Manager
-  #  DEBUG_BLKIO     0x00001000  // BlkIo Driver
-  #  DEBUG_NET       0x00004000  // SNP Driver
-  #  DEBUG_UNDI      0x00010000  // UNDI Driver
-  #  DEBUG_LOADFILE  0x00020000  // LoadFile
-  #  DEBUG_EVENT     0x00080000  // Event messages
-  #  DEBUG_GCD       0x00100000  // Global Coherency Database changes
-  #  DEBUG_CACHE     0x00200000  // Memory range cachability changes
-  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may
-  #                              // significantly impact boot performance
-  #  DEBUG_ERROR     0x80000000  // Error
+  #  DEBUG_INIT           0x00000001  // Initialization
+  #  DEBUG_WARN           0x00000002  // Warnings
+  #  DEBUG_LOAD           0x00000004  // Load events
+  #  DEBUG_FS             0x00000008  // EFI File system
+  #  DEBUG_POOL           0x00000010  // Alloc & Free (pool)
+  #  DEBUG_PAGE           0x00000020  // Alloc & Free (page)
+  #  DEBUG_INFO           0x00000040  // Informational debug messages
+  #  DEBUG_DISPATCH       0x00000080  // PEI/DXE/SMM Dispatchers
+  #  DEBUG_VARIABLE       0x00000100  // Variable
+  #  DEBUG_BM             0x00000400  // Boot Manager
+  #  DEBUG_BLKIO          0x00001000  // BlkIo Driver
+  #  DEBUG_NET            0x00004000  // Network Io Driver
+  #  DEBUG_UNDI           0x00010000  // UNDI Driver
+  #  DEBUG_LOADFILE       0x00020000  // LoadFile
+  #  DEBUG_EVENT          0x00080000  // Event messages
+  #  DEBUG_GCD            0x00100000  // Global Coherency Database changes
+  #  DEBUG_CACHE          0x00200000  // Memory range cachability changes
+  #  DEBUG_VERBOSE        0x00400000  // Detailed debug messages that may
+  #                                   // significantly impact boot performance
+  #  DEBUG_MANAGEABILITY  0x00800000  // Detailed debug and payload manageability messages
+  #                                   // related to modules such as Redfish, IPMI, MCTP etc.
+  #  DEBUG_ERROR          0x80000000  // Error
 !if $(TARGET) != RELEASE
   gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|$(DEBUG_PRINT_ERROR_LEVEL)
 !endif
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112245): https://edk2.groups.io/g/devel/message/112245
Mute This Topic: https://groups.io/mt/103066386/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 4/4] ArmVirtPkg: Sync debug level comments in ArmVirt.dsc.inc
Posted by Ard Biesheuvel 2 years, 2 months ago
On Sat, 9 Dec 2023 at 01:20, Rebecca Cran
<rebecca@os.amperecomputing.com> wrote:
>
> Update the debug level comments in ArmVirt.dsc.inc to sync with
> MdePkg/Include/Library/DebugLib.h.
>
> Signed-off-by: Rebecca Cran <rebecca@os.amperecomputing.com>

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>  ArmVirtPkg/ArmVirt.dsc.inc | 42 ++++++++++----------
>  1 file changed, 22 insertions(+), 20 deletions(-)
>
> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
> index 6bc72f1decbd..9b23ef97ec5f 100644
> --- a/ArmVirtPkg/ArmVirt.dsc.inc
> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
> @@ -315,26 +315,28 @@ [PcdsFixedAtBuild.common]
>    gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x2f
>  !endif
>
> -  #  DEBUG_INIT      0x00000001  // Initialization
> -  #  DEBUG_WARN      0x00000002  // Warnings
> -  #  DEBUG_LOAD      0x00000004  // Load events
> -  #  DEBUG_FS        0x00000008  // EFI File system
> -  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)
> -  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)
> -  #  DEBUG_INFO      0x00000040  // Informational debug messages
> -  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE/SMM Dispatchers
> -  #  DEBUG_VARIABLE  0x00000100  // Variable
> -  #  DEBUG_BM        0x00000400  // Boot Manager
> -  #  DEBUG_BLKIO     0x00001000  // BlkIo Driver
> -  #  DEBUG_NET       0x00004000  // SNP Driver
> -  #  DEBUG_UNDI      0x00010000  // UNDI Driver
> -  #  DEBUG_LOADFILE  0x00020000  // LoadFile
> -  #  DEBUG_EVENT     0x00080000  // Event messages
> -  #  DEBUG_GCD       0x00100000  // Global Coherency Database changes
> -  #  DEBUG_CACHE     0x00200000  // Memory range cachability changes
> -  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may
> -  #                              // significantly impact boot performance
> -  #  DEBUG_ERROR     0x80000000  // Error
> +  #  DEBUG_INIT           0x00000001  // Initialization
> +  #  DEBUG_WARN           0x00000002  // Warnings
> +  #  DEBUG_LOAD           0x00000004  // Load events
> +  #  DEBUG_FS             0x00000008  // EFI File system
> +  #  DEBUG_POOL           0x00000010  // Alloc & Free (pool)
> +  #  DEBUG_PAGE           0x00000020  // Alloc & Free (page)
> +  #  DEBUG_INFO           0x00000040  // Informational debug messages
> +  #  DEBUG_DISPATCH       0x00000080  // PEI/DXE/SMM Dispatchers
> +  #  DEBUG_VARIABLE       0x00000100  // Variable
> +  #  DEBUG_BM             0x00000400  // Boot Manager
> +  #  DEBUG_BLKIO          0x00001000  // BlkIo Driver
> +  #  DEBUG_NET            0x00004000  // Network Io Driver
> +  #  DEBUG_UNDI           0x00010000  // UNDI Driver
> +  #  DEBUG_LOADFILE       0x00020000  // LoadFile
> +  #  DEBUG_EVENT          0x00080000  // Event messages
> +  #  DEBUG_GCD            0x00100000  // Global Coherency Database changes
> +  #  DEBUG_CACHE          0x00200000  // Memory range cachability changes
> +  #  DEBUG_VERBOSE        0x00400000  // Detailed debug messages that may
> +  #                                   // significantly impact boot performance
> +  #  DEBUG_MANAGEABILITY  0x00800000  // Detailed debug and payload manageability messages
> +  #                                   // related to modules such as Redfish, IPMI, MCTP etc.
> +  #  DEBUG_ERROR          0x80000000  // Error
>  !if $(TARGET) != RELEASE
>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|$(DEBUG_PRINT_ERROR_LEVEL)
>  !endif
> --
> 2.34.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112250): https://edk2.groups.io/g/devel/message/112250
Mute This Topic: https://groups.io/mt/103066386/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-