.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 ++++++++++++------ .../RedfishDiscoverInternal.h | 4 + 2 files changed, 158 insertions(+), 71 deletions(-)
Igor Kulchytskyy (2):
RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after
RestEx
RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 ++++++++++++------
.../RedfishDiscoverInternal.h | 4 +
2 files changed, 158 insertions(+), 71 deletions(-)
--
2.37.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111292): https://edk2.groups.io/g/devel/message/111292
Mute This Topic: https://groups.io/mt/102615650/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
On 11/15/23 23:12, Igor Kulchytskyy via groups.io wrote: > Igor Kulchytskyy (2): > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > RestEx > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 ++++++++++++------ > .../RedfishDiscoverInternal.h | 4 + > 2 files changed, 158 insertions(+), 71 deletions(-) Should this patch series be highlighted in the release plan? Is there a BZ? Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111344): https://edk2.groups.io/g/devel/message/111344 Mute This Topic: https://groups.io/mt/102615650/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
[AMD Official Use Only - General] Yes Laszlo, we need one for this. Hi Igor, do you have an account on Bugzilla? We need a ticket for this issue. Thnaks Abner > -----Original Message----- > From: Laszlo Ersek <lersek@redhat.com> > Sent: Friday, November 17, 2023 5:11 PM > To: devel@edk2.groups.io; igork@ami.com; Chang, Abner > <Abner.Chang@amd.com> > Subject: Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 > installed after RestEx > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 11/15/23 23:12, Igor Kulchytskyy via groups.io wrote: > > Igor Kulchytskyy (2): > > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > > RestEx > > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 ++++++++++++------ > > .../RedfishDiscoverInternal.h | 4 + > > 2 files changed, 158 insertions(+), 71 deletions(-) > > Should this patch series be highlighted in the release plan? Is there a BZ? > > Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111452): https://edk2.groups.io/g/devel/message/111452 Mute This Topic: https://groups.io/mt/102615650/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Abner, I have an account. I will create a ticket. Thank you, Igor Get Outlook for Android<https://aka.ms/AAb9ysg> ________________________________ From: Chang, Abner <Abner.Chang@amd.com> Sent: Sunday, November 19, 2023 11:31:37 PM To: Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Igor Kulchytskyy <igork@ami.com> Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Yes Laszlo, we need one for this. Hi Igor, do you have an account on Bugzilla? We need a ticket for this issue. Thnaks Abner > -----Original Message----- > From: Laszlo Ersek <lersek@redhat.com> > Sent: Friday, November 17, 2023 5:11 PM > To: devel@edk2.groups.io; igork@ami.com; Chang, Abner > <Abner.Chang@amd.com> > Subject: Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 > installed after RestEx > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 11/15/23 23:12, Igor Kulchytskyy via groups.io wrote: > > Igor Kulchytskyy (2): > > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > > RestEx > > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 ++++++++++++------ > > .../RedfishDiscoverInternal.h | 4 + > > 2 files changed, 158 insertions(+), 71 deletions(-) > > Should this patch series be highlighted in the release plan? Is there a BZ? > > Laszlo -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111480): https://edk2.groups.io/g/devel/message/111480 Mute This Topic: https://groups.io/mt/102615650/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hello, I created a ticket. https://bugzilla.tianocore.org/show_bug.cgi?id=4602 Since it is my first ticket, could you please check it and tell if it is what we need? Thank you, Igor From: Igor Kulchytskyy <igork@ami.com> Sent: Monday, November 20, 2023 8:50 AM To: Chang, Abner <Abner.Chang@amd.com>; Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io Subject: Re: [EXTERNAL] RE: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx Hi Abner, I have an account. I will create a ticket. Thank you, Igor Get Outlook for Android<https://aka.ms/AAb9ysg> ________________________________ From: Chang, Abner <Abner.Chang@amd.com<mailto:Abner.Chang@amd.com>> Sent: Sunday, November 19, 2023 11:31:37 PM To: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>> Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Yes Laszlo, we need one for this. Hi Igor, do you have an account on Bugzilla? We need a ticket for this issue. Thnaks Abner > -----Original Message----- > From: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>> > Sent: Friday, November 17, 2023 5:11 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; igork@ami.com<mailto:igork@ami.com>; Chang, Abner > <Abner.Chang@amd.com<mailto:Abner.Chang@amd.com>> > Subject: Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 > installed after RestEx > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 11/15/23 23:12, Igor Kulchytskyy via groups.io wrote: > > Igor Kulchytskyy (2): > > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > > RestEx > > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 ++++++++++++------ > > .../RedfishDiscoverInternal.h | 4 + > > 2 files changed, 158 insertions(+), 71 deletions(-) > > Should this patch series be highlighted in the release plan? Is there a BZ? > > Laszlo -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111510): https://edk2.groups.io/g/devel/message/111510 Mute This Topic: https://groups.io/mt/102615650/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
[AMD Official Use Only - General] Hi Igor, You can update the commit message with this BZ# information in this commit and resend the PR. https://github.com/tianocore/edk2/pull/5052/commits/45fbed1e540f902ee21eebeb0752ba24911e445e Also, let Liming knows you have this update. Thanks Abner From: Igor Kulchytskyy <igork@ami.com> Sent: Tuesday, November 21, 2023 11:04 AM To: Chang, Abner <Abner.Chang@amd.com>; Laszlo Ersek <lersek@redhat.com>; devel@edk2.groups.io Subject: RE: [EXTERNAL] RE: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx [AMD Official Use Only - General] Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Hello, I created a ticket. https://bugzilla.tianocore.org/show_bug.cgi?id=4602 Since it is my first ticket, could you please check it and tell if it is what we need? Thank you, Igor From: Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>> Sent: Monday, November 20, 2023 8:50 AM To: Chang, Abner <Abner.Chang@amd.com<mailto:Abner.Chang@amd.com>>; Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [EXTERNAL] RE: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx Hi Abner, I have an account. I will create a ticket. Thank you, Igor Get Outlook for Android<https://aka.ms/AAb9ysg> ________________________________ From: Chang, Abner <Abner.Chang@amd.com<mailto:Abner.Chang@amd.com>> Sent: Sunday, November 19, 2023 11:31:37 PM To: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>>; Igor Kulchytskyy <igork@ami.com<mailto:igork@ami.com>> Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Yes Laszlo, we need one for this. Hi Igor, do you have an account on Bugzilla? We need a ticket for this issue. Thnaks Abner > -----Original Message----- > From: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>> > Sent: Friday, November 17, 2023 5:11 PM > To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; igork@ami.com<mailto:igork@ami.com>; Chang, Abner > <Abner.Chang@amd.com<mailto:Abner.Chang@amd.com>> > Subject: Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 > installed after RestEx > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > On 11/15/23 23:12, Igor Kulchytskyy via groups.io wrote: > > Igor Kulchytskyy (2): > > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > > RestEx > > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 ++++++++++++------ > > .../RedfishDiscoverInternal.h | 4 + > > 2 files changed, 158 insertions(+), 71 deletions(-) > > Should this patch series be highlighted in the release plan? Is there a BZ? > > Laszlo -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111511): https://edk2.groups.io/g/devel/message/111511 Mute This Topic: https://groups.io/mt/102615650/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Laszlo: I agree to highlight this critical bug fix. Igor: If no BZ, please help submit it. I will help merge your patch set. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Laszlo Ersek > 发送时间: 2023年11月17日 17:11 > 收件人: devel@edk2.groups.io; igork@ami.com; Abner Chang > <abner.chang@amd.com> > 主题: Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 > installed after RestEx > > On 11/15/23 23:12, Igor Kulchytskyy via groups.io wrote: > > Igor Kulchytskyy (2): > > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > > RestEx > > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 > ++++++++++++------ > > .../RedfishDiscoverInternal.h | 4 + > > 2 files changed, 158 insertions(+), 71 deletions(-) > > Should this patch series be highlighted in the release plan? Is there a BZ? > > Laszlo > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111351): https://edk2.groups.io/g/devel/message/111351 Mute This Topic: https://groups.io/mt/102644709/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Wed, Nov 15, 2023 at 22:12:34 +0000, Igor Kulchytskyy via groups.io wrote: > Igor Kulchytskyy (2): > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > RestEx > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 ++++++++++++------ > .../RedfishDiscoverInternal.h | 4 + > 2 files changed, 158 insertions(+), 71 deletions(-) Happy with this. Many thanks for the rework. For the series: Acked-by: Leif Lindholm <quic_llindhol@quicinc.com> > -- > 2.37.1.windows.1 > -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111317): https://edk2.groups.io/g/devel/message/111317 Mute This Topic: https://groups.io/mt/102615650/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thank you all for the reviews! -----Original Message----- From: Leif Lindholm <quic_llindhol@quicinc.com> Sent: Thursday, November 16, 2023 7:29 AM To: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com> Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** On Wed, Nov 15, 2023 at 22:12:34 +0000, Igor Kulchytskyy via groups.io wrote: > Igor Kulchytskyy (2): > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > RestEx > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 ++++++++++++------ > .../RedfishDiscoverInternal.h | 4 + > 2 files changed, 158 insertions(+), 71 deletions(-) Happy with this. Many thanks for the rework. For the series: Acked-by: Leif Lindholm <quic_llindhol@quicinc.com> > -- > 2.37.1.windows.1 > -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. > > > > > -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111318): https://edk2.groups.io/g/devel/message/111318 Mute This Topic: https://groups.io/mt/102615650/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
[AMD Official Use Only - General] Great and happy ending! 😊 Hi Igor, could you please inform Liming he can merge this change. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Igor > Kulchytskyy via groups.io > Sent: Thursday, November 16, 2023 8:31 PM > To: Leif Lindholm <quic_llindhol@quicinc.com>; devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 > installed after RestEx > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Thank you all for the reviews! > > -----Original Message----- > From: Leif Lindholm <quic_llindhol@quicinc.com> > Sent: Thursday, November 16, 2023 7:29 AM > To: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com> > Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the > issue if IPv4 installed after RestEx > > > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance.** > > On Wed, Nov 15, 2023 at 22:12:34 +0000, Igor Kulchytskyy via groups.io > wrote: > > Igor Kulchytskyy (2): > > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > > RestEx > > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 ++++++++++++------ > > .../RedfishDiscoverInternal.h | 4 + > > 2 files changed, 158 insertions(+), 71 deletions(-) > > Happy with this. Many thanks for the rework. > > For the series: > Acked-by: Leif Lindholm <quic_llindhol@quicinc.com> > > > > -- > > 2.37.1.windows.1 > > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by their > designee. If the reader of this message is not the intended recipient, you are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by telephone > at 770-246-8600, and then delete or destroy all copies of the transmission. > > > > > > > > > > > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by their > designee. If the reader of this message is not the intended recipient, you are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by telephone > at 770-246-8600, and then delete or destroy all copies of the transmission. > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111319): https://edk2.groups.io/g/devel/message/111319 Mute This Topic: https://groups.io/mt/102615650/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Liming, I created PR for the final v6 patch: https://github.com/tianocore/edk2/pull/5050 Could you please merge those changes? Thank you, Igor -----Original Message----- From: Chang, Abner <Abner.Chang@amd.com> Sent: Thursday, November 16, 2023 8:03 AM To: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com>; Leif Lindholm <quic_llindhol@quicinc.com> Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** [AMD Official Use Only - General] Great and happy ending! 😊 Hi Igor, could you please inform Liming he can merge this change. Thanks Abner > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Igor > Kulchytskyy via groups.io > Sent: Thursday, November 16, 2023 8:31 PM > To: Leif Lindholm <quic_llindhol@quicinc.com>; devel@edk2.groups.io > Subject: Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 > installed after RestEx > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Thank you all for the reviews! > > -----Original Message----- > From: Leif Lindholm <quic_llindhol@quicinc.com> > Sent: Thursday, November 16, 2023 7:29 AM > To: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com> > Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the > issue if IPv4 installed after RestEx > > > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance.** > > On Wed, Nov 15, 2023 at 22:12:34 +0000, Igor Kulchytskyy via groups.io > wrote: > > Igor Kulchytskyy (2): > > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > > RestEx > > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 ++++++++++++------ > > .../RedfishDiscoverInternal.h | 4 + > > 2 files changed, 158 insertions(+), 71 deletions(-) > > Happy with this. Many thanks for the rework. > > For the series: > Acked-by: Leif Lindholm <quic_llindhol@quicinc.com> > > > > -- > > 2.37.1.windows.1 > > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by their > designee. If the reader of this message is not the intended recipient, you are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by telephone > at 770-246-8600, and then delete or destroy all copies of the transmission. > > > > > > > > > > > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended > to be read only by the individual or entity to whom it is addressed or by their > designee. If the reader of this message is not the intended recipient, you are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by telephone > at 770-246-8600, and then delete or destroy all copies of the transmission. > > > > -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111320): https://edk2.groups.io/g/devel/message/111320 Mute This Topic: https://groups.io/mt/102615650/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Igor: I re-create pull request https://github.com/tianocore/edk2/pull/5052 to revert previous commits and append new commits. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Igor > Kulchytskyy via groups.io > 发送时间: 2023年11月16日 21:45 > 收件人: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io; Leif > Lindholm <quic_llindhol@quicinc.com> > 抄送: Gao, Liming <gaoliming@byosoft.com.cn> > 主题: Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 > installed after RestEx > > Hi Liming, > I created PR for the final v6 patch: > https://github.com/tianocore/edk2/pull/5050 > Could you please merge those changes? > Thank you, > Igor > > -----Original Message----- > From: Chang, Abner <Abner.Chang@amd.com> > Sent: Thursday, November 16, 2023 8:03 AM > To: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com>; Leif Lindholm > <quic_llindhol@quicinc.com> > Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v6 0/2] Fix and optimize the > issue if IPv4 installed after RestEx > > > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance.** > > [AMD Official Use Only - General] > > Great and happy ending! 😊 > > Hi Igor, could you please inform Liming he can merge this change. > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Igor > > Kulchytskyy via groups.io > > Sent: Thursday, November 16, 2023 8:31 PM > > To: Leif Lindholm <quic_llindhol@quicinc.com>; devel@edk2.groups.io > > Subject: Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 > > installed after RestEx > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > Thank you all for the reviews! > > > > -----Original Message----- > > From: Leif Lindholm <quic_llindhol@quicinc.com> > > Sent: Thursday, November 16, 2023 7:29 AM > > To: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com> > > Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the > > issue if IPv4 installed after RestEx > > > > > > **CAUTION: The e-mail below is from an external source. Please exercise > > caution before opening attachments, clicking links, or following guidance.** > > > > On Wed, Nov 15, 2023 at 22:12:34 +0000, Igor Kulchytskyy via groups.io > > wrote: > > > Igor Kulchytskyy (2): > > > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > > > RestEx > > > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > > > > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 > ++++++++++++------ > > > .../RedfishDiscoverInternal.h | 4 + > > > 2 files changed, 158 insertions(+), 71 deletions(-) > > > > Happy with this. Many thanks for the rework. > > > > For the series: > > Acked-by: Leif Lindholm <quic_llindhol@quicinc.com> > > > > > > > -- > > > 2.37.1.windows.1 > > > -The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is intended > > to be read only by the individual or entity to whom it is addressed or by their > > designee. If the reader of this message is not the intended recipient, you are > > on notice that any distribution of this message, in any form, is strictly > > prohibited. Please promptly notify the sender by reply e-mail or by > telephone > > at 770-246-8600, and then delete or destroy all copies of the transmission. > > > > > > > > > > > > > > > > > -The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is intended > > to be read only by the individual or entity to whom it is addressed or by their > > designee. If the reader of this message is not the intended recipient, you are > > on notice that any distribution of this message, in any form, is strictly > > prohibited. Please promptly notify the sender by reply e-mail or by > telephone > > at 770-246-8600, and then delete or destroy all copies of the transmission. > > > > > > > > > > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended to > be read only by the individual or entity to whom it is addressed or by their > designee. If the reader of this message is not the intended recipient, you are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by telephone > at 770-246-8600, and then delete or destroy all copies of the transmission. > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111392): https://edk2.groups.io/g/devel/message/111392 Mute This Topic: https://groups.io/mt/102644864/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Liming, I fixed the uncrustify issues. Thank you, Igor -----Original Message----- From: gaoliming <gaoliming@byosoft.com.cn> Sent: Friday, November 17, 2023 5:05 AM To: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com>; 'Chang, Abner' <Abner.Chang@amd.com>; 'Leif Lindholm' <quic_llindhol@quicinc.com> Subject: [EXTERNAL] 回复: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 installed after RestEx **CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.** Igor: I re-create pull request https://github.com/tianocore/edk2/pull/5052 to revert previous commits and append new commits. Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Igor > Kulchytskyy via groups.io > 发送时间: 2023年11月16日 21:45 > 收件人: Chang, Abner <Abner.Chang@amd.com>; devel@edk2.groups.io; Leif > Lindholm <quic_llindhol@quicinc.com> > 抄送: Gao, Liming <gaoliming@byosoft.com.cn> > 主题: Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 > installed after RestEx > > Hi Liming, > I created PR for the final v6 patch: > https://github.com/tianocore/edk2/pull/5050 > Could you please merge those changes? > Thank you, > Igor > > -----Original Message----- > From: Chang, Abner <Abner.Chang@amd.com> > Sent: Thursday, November 16, 2023 8:03 AM > To: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com>; Leif Lindholm > <quic_llindhol@quicinc.com> > Subject: [EXTERNAL] RE: [edk2-devel] [PATCH v6 0/2] Fix and optimize the > issue if IPv4 installed after RestEx > > > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance.** > > [AMD Official Use Only - General] > > Great and happy ending! 😊 > > Hi Igor, could you please inform Liming he can merge this change. > Thanks > Abner > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Igor > > Kulchytskyy via groups.io > > Sent: Thursday, November 16, 2023 8:31 PM > > To: Leif Lindholm <quic_llindhol@quicinc.com>; devel@edk2.groups.io > > Subject: Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the issue if IPv4 > > installed after RestEx > > > > Caution: This message originated from an External Source. Use proper > caution > > when opening attachments, clicking links, or responding. > > > > > > Thank you all for the reviews! > > > > -----Original Message----- > > From: Leif Lindholm <quic_llindhol@quicinc.com> > > Sent: Thursday, November 16, 2023 7:29 AM > > To: devel@edk2.groups.io; Igor Kulchytskyy <igork@ami.com> > > Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v6 0/2] Fix and optimize the > > issue if IPv4 installed after RestEx > > > > > > **CAUTION: The e-mail below is from an external source. Please exercise > > caution before opening attachments, clicking links, or following guidance.** > > > > On Wed, Nov 15, 2023 at 22:12:34 +0000, Igor Kulchytskyy via groups.io > > wrote: > > > Igor Kulchytskyy (2): > > > RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after > > > RestEx > > > RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow > > > > > > .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 225 > ++++++++++++------ > > > .../RedfishDiscoverInternal.h | 4 + > > > 2 files changed, 158 insertions(+), 71 deletions(-) > > > > Happy with this. Many thanks for the rework. > > > > For the series: > > Acked-by: Leif Lindholm <quic_llindhol@quicinc.com> > > > > > > > -- > > > 2.37.1.windows.1 > > > -The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is intended > > to be read only by the individual or entity to whom it is addressed or by their > > designee. If the reader of this message is not the intended recipient, you are > > on notice that any distribution of this message, in any form, is strictly > > prohibited. Please promptly notify the sender by reply e-mail or by > telephone > > at 770-246-8600, and then delete or destroy all copies of the transmission. > > > > > > > > > > > > > > > > > -The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is intended > > to be read only by the individual or entity to whom it is addressed or by their > > designee. If the reader of this message is not the intended recipient, you are > > on notice that any distribution of this message, in any form, is strictly > > prohibited. Please promptly notify the sender by reply e-mail or by > telephone > > at 770-246-8600, and then delete or destroy all copies of the transmission. > > > > > > > > > > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended to > be read only by the individual or entity to whom it is addressed or by their > designee. If the reader of this message is not the intended recipient, you are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by telephone > at 770-246-8600, and then delete or destroy all copies of the transmission. > > > > -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111400): https://edk2.groups.io/g/devel/message/111400 Mute This Topic: https://groups.io/mt/102644864/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.