For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from
edk2, first remove the edk2-platforms references to that header file.

I can't build-test this change. As far as I can tell, building the
CooperCityRvp and WilsonCityRvp platforms with "build_bios.py" should
build these changes; however, both platforms fail to build without FSP
blobs.

I think there's a fair chance that this patch should work nonetheless;
<LegacyBiosMpTable.h> introduces names prefixed with EFI_LEGACY_MP_TABLE_,
and edk2-platforms doesn't contain that string. (The one exception is
FEATUREBYTE2_5, which is also absent from edk2-platforms.)

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.h | 1 -
 Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/PlatformDeviceDataSRP10nm.c       | 1 -
 2 files changed, 2 deletions(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.h b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.h
index 32c16ff9110a..d8c209a57f75 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.h
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.h
@@ -27,7 +27,6 @@
 #include <Platform.h>
 #include <Ppi/PchPolicy.h>
 
-#include <IndustryStandard/LegacyBiosMpTable.h>
 #include <UncoreCommonIncludes.h>
 
 #endif  //_SYSTEM_BOARD_INFO_DXE_H_
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/PlatformDeviceDataSRP10nm.c b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/PlatformDeviceDataSRP10nm.c
index ed9f80734cd7..b69ae1736bb8 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/PlatformDeviceDataSRP10nm.c
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/PlatformDeviceDataSRP10nm.c
@@ -8,7 +8,6 @@
 
 #include <PlatPirqData.h>
 #include <PlatDevData.h>
-#include <IndustryStandard/LegacyBiosMpTable.h>
 
 #ifndef V_INTEL_VID
 #define V_INTEL_VID               0x8086



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110970): https://edk2.groups.io/g/devel/message/110970
Mute This Topic: https://groups.io/mt/102483850/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Laszlo,

I verified and encountered build failure as some files still consuming definitions from LegacyBiosMpTable.h, for example:
https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513380ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22

Any suggestion that we can reduce impact to existing platforms?

Thanks,
Chasel



> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
> Sent: Thursday, November 9, 2023 4:06 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel
> L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> remove <LegacyBiosMpTable.h> references
> 
> For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from
> edk2, first remove the edk2-platforms references to that header file.
> 
> I can't build-test this change. As far as I can tell, building the CooperCityRvp and
> WilsonCityRvp platforms with "build_bios.py" should build these changes;
> however, both platforms fail to build without FSP blobs.
> 
> I think there's a fair chance that this patch should work nonetheless;
> <LegacyBiosMpTable.h> introduces names prefixed with
> EFI_LEGACY_MP_TABLE_, and edk2-platforms doesn't contain that string. (The
> one exception is FEATUREBYTE2_5, which is also absent from edk2-platforms.)
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoar
> dInfoDxe/SystemBoardInfoDxe.h | 1 -
> 
> Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platform
> DeviceDataSRP10nm.c       | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
> ardInfoDxe/SystemBoardInfoDxe.h
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
> ardInfoDxe/SystemBoardInfoDxe.h
> index 32c16ff9110a..d8c209a57f75 100644
> ---
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
> ardInfoDxe/SystemBoardInfoDxe.h
> +++
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
> +++ ardInfoDxe/SystemBoardInfoDxe.h
> @@ -27,7 +27,6 @@
>  #include <Platform.h>
>  #include <Ppi/PchPolicy.h>
> 
> -#include <IndustryStandard/LegacyBiosMpTable.h>
>  #include <UncoreCommonIncludes.h>
> 
>  #endif  //_SYSTEM_BOARD_INFO_DXE_H_
> diff --git
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
> mDeviceDataSRP10nm.c
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
> mDeviceDataSRP10nm.c
> index ed9f80734cd7..b69ae1736bb8 100644
> ---
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
> mDeviceDataSRP10nm.c
> +++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Pl
> +++ atformDeviceDataSRP10nm.c
> @@ -8,7 +8,6 @@
> 
>  #include <PlatPirqData.h>
>  #include <PlatDevData.h>
> -#include <IndustryStandard/LegacyBiosMpTable.h>
> 
>  #ifndef V_INTEL_VID
>  #define V_INTEL_VID               0x8086
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111005): https://edk2.groups.io/g/devel/message/111005
Mute This Topic: https://groups.io/mt/102483850/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Chasel,

On 11/10/23 02:13, Chiu, Chasel wrote:
> 
> Hi Laszlo,
> 
> I verified and encountered build failure as some files still consuming definitions from LegacyBiosMpTable.h, for example:
> https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513380ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22
> 
> Any suggestion that we can reduce impact to existing platforms?

I've been hoping to get comments from Nate on the expected contents of
DEVICE_DATA_HW_LOCAL_INT. Barring such comments, here is my proposal:
I'd like to just replace the enum constants in question with their
numerical values.

However, even for that, I'd really like to be able to build-test the
platform locally. Do you have build instructions? How can I satisfy the
FSP blob requirement?

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111261): https://edk2.groups.io/g/devel/message/111261
Mute This Topic: https://groups.io/mt/102483850/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Laszlo,

I think you have to clone all the required repos.
edk2 repository
git clone https://github.com/tianocore/edk2.git

edk2-platforms repository
git clone https://github.com/tianocore/edk2-platforms.git

edk2-non-osi repository
git clone https://github.com/tianocore/edk2-non-osi.git

FSP repository
git clone https://github.com/IntelFsp/FSP.git

check if you got all repos like below:
edk2
edk2-non-osi
edk2-platforms
FSP

Then switch to edk2-platforms/Platform/Intel/build_bios.py -p WilsonCityRvp to start the build

Detail information is in readme: https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel/Readme.md

Please let me know if any question.

Thanks,
Chasel





> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Wednesday, November 15, 2023 3:51 AM
> To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel
> L <nathaniel.l.desimone@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> remove <LegacyBiosMpTable.h> references
> 
> Hi Chasel,
> 
> On 11/10/23 02:13, Chiu, Chasel wrote:
> >
> > Hi Laszlo,
> >
> > I verified and encountered build failure as some files still consuming definitions
> from LegacyBiosMpTable.h, for example:
> > https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd5469051338
> >
> 0ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Co
> m
> > mon/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22
> >
> > Any suggestion that we can reduce impact to existing platforms?
> 
> I've been hoping to get comments from Nate on the expected contents of
> DEVICE_DATA_HW_LOCAL_INT. Barring such comments, here is my proposal:
> I'd like to just replace the enum constants in question with their numerical values.
> 
> However, even for that, I'd really like to be able to build-test the platform locally.
> Do you have build instructions? How can I satisfy the FSP blob requirement?
> 
> Thanks!
> Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111499): https://edk2.groups.io/g/devel/message/111499
Mute This Topic: https://groups.io/mt/102483850/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Tue, Nov 21, 2023 at 2:17 AM Chiu, Chasel <chasel.chiu@intel.com> wrote:
>
>
> Hi Laszlo,
>
> I think you have to clone all the required repos.
> edk2 repository
> git clone https://github.com/tianocore/edk2.git
>
> edk2-platforms repository
> git clone https://github.com/tianocore/edk2-platforms.git
>
> edk2-non-osi repository
> git clone https://github.com/tianocore/edk2-non-osi.git
>
> FSP repository
> git clone https://github.com/IntelFsp/FSP.git

I wonder if the docs are outdated? I had heard of
https://github.com/Intel/FSP, not IntelFsp/FSP.
Does https://github.com/Intel/FSP work?

-- 
Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111763): https://edk2.groups.io/g/devel/message/111763
Mute This Topic: https://groups.io/mt/102483850/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

> -----Original Message-----
> From: Pedro Falcato <pedro.falcato@gmail.com>
> Sent: Monday, November 27, 2023 3:14 PM
> To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> remove <LegacyBiosMpTable.h> references
> 
> On Tue, Nov 21, 2023 at 2:17 AM Chiu, Chasel <chasel.chiu@intel.com> wrote:
> >
> >
> > Hi Laszlo,
> >
> > I think you have to clone all the required repos.
> > edk2 repository
> > git clone https://github.com/tianocore/edk2.git
> >
> > edk2-platforms repository
> > git clone https://github.com/tianocore/edk2-platforms.git
> >
> > edk2-non-osi repository
> > git clone https://github.com/tianocore/edk2-non-osi.git
> >
> > FSP repository
> > git clone https://github.com/IntelFsp/FSP.git
> 
> I wonder if the docs are outdated? I had heard of https://github.com/Intel/FSP,
> not IntelFsp/FSP.
> Does https://github.com/Intel/FSP work?


Yes, https://github.com/intel/FSP.git is the one, however, In my case both links work the same and I can clone successfully by either one.


> 
> --
> Pedro


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111790): https://edk2.groups.io/g/devel/message/111790
Mute This Topic: https://groups.io/mt/102483850/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Chasel,

On 11/21/23 03:17, Chiu, Chasel wrote:
> 
> Hi Laszlo,
> 
> I think you have to clone all the required repos.
> edk2 repository
> git clone https://github.com/tianocore/edk2.git
> 
> edk2-platforms repository
> git clone https://github.com/tianocore/edk2-platforms.git
> 
> edk2-non-osi repository
> git clone https://github.com/tianocore/edk2-non-osi.git
> 
> FSP repository
> git clone https://github.com/IntelFsp/FSP.git

But that's the thing exactly: this repository is not public, and I'm not
a member of the IntelFsp organization. When I log in to GitHub, and open

  https://github.com/IntelFsp/

the page says

  This organization has no public repositories.

This is basically what I meant earlier, when I asked: "How can I satisfy
the FSP blob requirement?".

Anyway... this is taking too long; I don't want to waste your time with
it. We can't reasonably expect any contributor to send patches for a
subsystem they can't even build due to not being permitted access to
various proprietary blobs. I'm dropping this patch set now (for edk2 as
well), and removing myself from the BZ.

Thanks for the help thus far!
Laszlo

> 
> check if you got all repos like below:
> edk2
> edk2-non-osi
> edk2-platforms
> FSP
> 
> Then switch to edk2-platforms/Platform/Intel/build_bios.py -p WilsonCityRvp to start the build
> 
> Detail information is in readme: https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel/Readme.md
> 
> Please let me know if any question.
> 
> Thanks,
> Chasel
> 
> 
> 
> 
> 
>> -----Original Message-----
>> From: Laszlo Ersek <lersek@redhat.com>
>> Sent: Wednesday, November 15, 2023 3:51 AM
>> To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
>> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel
>> L <nathaniel.l.desimone@intel.com>
>> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
>> remove <LegacyBiosMpTable.h> references
>>
>> Hi Chasel,
>>
>> On 11/10/23 02:13, Chiu, Chasel wrote:
>>>
>>> Hi Laszlo,
>>>
>>> I verified and encountered build failure as some files still consuming definitions
>> from LegacyBiosMpTable.h, for example:
>>> https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd5469051338
>>>
>> 0ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Co
>> m
>>> mon/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22
>>>
>>> Any suggestion that we can reduce impact to existing platforms?
>>
>> I've been hoping to get comments from Nate on the expected contents of
>> DEVICE_DATA_HW_LOCAL_INT. Barring such comments, here is my proposal:
>> I'd like to just replace the enum constants in question with their numerical values.
>>
>> However, even for that, I'd really like to be able to build-test the platform locally.
>> Do you have build instructions? How can I satisfy the FSP blob requirement?
>>
>> Thanks!
>> Laszlo
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111666): https://edk2.groups.io/g/devel/message/111666
Mute This Topic: https://groups.io/mt/102483850/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Laszlo,

Thanks for your support too!
By the way, do we still plan to remove LgacyBiosMpTable.h? We can follow up with relevant OpenBoardPkg fixes if that's the goal.

Thanks,
Chasel



> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Thursday, November 23, 2023 2:05 AM
> To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel
> L <nathaniel.l.desimone@intel.com>
> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> remove <LegacyBiosMpTable.h> references
> 
> Hi Chasel,
> 
> On 11/21/23 03:17, Chiu, Chasel wrote:
> >
> > Hi Laszlo,
> >
> > I think you have to clone all the required repos.
> > edk2 repository
> > git clone https://github.com/tianocore/edk2.git
> >
> > edk2-platforms repository
> > git clone https://github.com/tianocore/edk2-platforms.git
> >
> > edk2-non-osi repository
> > git clone https://github.com/tianocore/edk2-non-osi.git
> >
> > FSP repository
> > git clone https://github.com/IntelFsp/FSP.git
> 
> But that's the thing exactly: this repository is not public, and I'm not a member of
> the IntelFsp organization. When I log in to GitHub, and open
> 
>   https://github.com/IntelFsp/
> 
> the page says
> 
>   This organization has no public repositories.
> 
> This is basically what I meant earlier, when I asked: "How can I satisfy the FSP
> blob requirement?".
> 
> Anyway... this is taking too long; I don't want to waste your time with it. We can't
> reasonably expect any contributor to send patches for a subsystem they can't
> even build due to not being permitted access to various proprietary blobs. I'm
> dropping this patch set now (for edk2 as well), and removing myself from the BZ.
> 
> Thanks for the help thus far!
> Laszlo
> 
> >
> > check if you got all repos like below:
> > edk2
> > edk2-non-osi
> > edk2-platforms
> > FSP
> >
> > Then switch to edk2-platforms/Platform/Intel/build_bios.py -p
> > WilsonCityRvp to start the build
> >
> > Detail information is in readme:
> > https://github.com/tianocore/edk2-platforms/blob/master/Platform/Intel
> > /Readme.md
> >
> > Please let me know if any question.
> >
> > Thanks,
> > Chasel
> >
> >
> >
> >
> >
> >> -----Original Message-----
> >> From: Laszlo Ersek <lersek@redhat.com>
> >> Sent: Wednesday, November 15, 2023 3:51 AM
> >> To: devel@edk2.groups.io; Chiu, Chasel <chasel.chiu@intel.com>
> >> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone,
> >> Nathaniel L <nathaniel.l.desimone@intel.com>
> >> Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
> >> remove <LegacyBiosMpTable.h> references
> >>
> >> Hi Chasel,
> >>
> >> On 11/10/23 02:13, Chiu, Chasel wrote:
> >>>
> >>> Hi Laszlo,
> >>>
> >>> I verified and encountered build failure as some files still
> >>> consuming definitions
> >> from LegacyBiosMpTable.h, for example:
> >>> https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513
> >>> 38
> >>>
> >>
> 0ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Co
> >> m
> >>> mon/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22
> >>>
> >>> Any suggestion that we can reduce impact to existing platforms?
> >>
> >> I've been hoping to get comments from Nate on the expected contents
> >> of DEVICE_DATA_HW_LOCAL_INT. Barring such comments, here is my
> proposal:
> >> I'd like to just replace the enum constants in question with their numerical
> values.
> >>
> >> However, even for that, I'd really like to be able to build-test the platform
> locally.
> >> Do you have build instructions? How can I satisfy the FSP blob requirement?
> >>
> >> Thanks!
> >> Laszlo
> >
> >
> >
> > 
> >
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111754): https://edk2.groups.io/g/devel/message/111754
Mute This Topic: https://groups.io/mt/102483850/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Chasel,

On 11/10/23 02:13, Chiu, Chasel wrote:
> 
> Hi Laszlo,
> 
> I verified and encountered build failure as some files still consuming definitions from LegacyBiosMpTable.h, for example:
> https://github.com/tianocore/edk2-platforms/blob/899a9dc97cd54690513380ad01ee8b2609dbefd5/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoardInfoDxe/SystemBoardInfoDxe.c#L22
> 
> Any suggestion that we can reduce impact to existing platforms?

thanks for testing the build!

Here's my problem: this information seems to be exposed
firmware-globally, ultimately. We have a UbaConfigProtocol->AddData()
call, which exposes SystemBoardInfoData. SystemBoardInfoData exposes
SystemBoardInfoCallback(). That one in turn exposes SystemBoardInfoTable
(of type DXE_SYSTEM_BOARD_INFO).

And so on and so on, and ultimately we publicly expose
DEVICE_DATA_HW_LOCAL_INT.

That structure type is defined in
"Platform/Intel/WhitleyOpenBoardPkg/Include/PlatDevData.h", and it only
has the following comment:

"Platform hardwired data describing connection of interrupt sources to
local APICs"

So I can't tell if this structure type officially and explicitly defers
to the MP Table specification, or just ad-hoc reuses the same values.

In the former case, we cannot remove LegacyBiosMpTable.h from edk2 (or
perhaps we need to move it over to edk2-platforms).

In the latter case, we should just replace the enum constants with their
integer values (or perhaps replace them with some different macros, like
ACPI spec macros or similar), and then we can delete LegacyBiosMpTable.h.

That is, we need to figure out where the DEVICE_DATA_HW_LOCAL_INT type
definition originates from.

The particular "DeviceDataHwLocalInt1" array comes from edk2-platforms
commit 3584efd25110 ("WhitleyOpenBoardPkg: Add UBA Modules",
2021-07-14). The commit message is empty -- so it's a dead-end.

The type definition comes from edk2-platforms commit 41bfa85f527a
("WhitleyOpenBoardPkg: Add Includes and Libraries", 2021-07-14). The
commit message is similarly empty.

Laszlo

> 
> Thanks,
> Chasel
> 
> 
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Laszlo Ersek
>> Sent: Thursday, November 9, 2023 4:06 AM
>> To: devel@edk2.groups.io
>> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel
>> L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
>> Subject: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg:
>> remove <LegacyBiosMpTable.h> references
>>
>> For removing "MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h" from
>> edk2, first remove the edk2-platforms references to that header file.
>>
>> I can't build-test this change. As far as I can tell, building the CooperCityRvp and
>> WilsonCityRvp platforms with "build_bios.py" should build these changes;
>> however, both platforms fail to build without FSP blobs.
>>
>> I think there's a fair chance that this patch should work nonetheless;
>> <LegacyBiosMpTable.h> introduces names prefixed with
>> EFI_LEGACY_MP_TABLE_, and edk2-platforms doesn't contain that string. (The
>> one exception is FEATUREBYTE2_5, which is also absent from edk2-platforms.)
>>
>> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Cc: Chasel Chiu <chasel.chiu@intel.com>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1754
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>
>> Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBoar
>> dInfoDxe/SystemBoardInfoDxe.h | 1 -
>>
>> Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platform
>> DeviceDataSRP10nm.c       | 1 -
>>  2 files changed, 2 deletions(-)
>>
>> diff --git
>> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
>> ardInfoDxe/SystemBoardInfoDxe.h
>> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
>> ardInfoDxe/SystemBoardInfoDxe.h
>> index 32c16ff9110a..d8c209a57f75 100644
>> ---
>> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
>> ardInfoDxe/SystemBoardInfoDxe.h
>> +++
>> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/Common/Dxe/SystemBo
>> +++ ardInfoDxe/SystemBoardInfoDxe.h
>> @@ -27,7 +27,6 @@
>>  #include <Platform.h>
>>  #include <Ppi/PchPolicy.h>
>>
>> -#include <IndustryStandard/LegacyBiosMpTable.h>
>>  #include <UncoreCommonIncludes.h>
>>
>>  #endif  //_SYSTEM_BOARD_INFO_DXE_H_
>> diff --git
>> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
>> mDeviceDataSRP10nm.c
>> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
>> mDeviceDataSRP10nm.c
>> index ed9f80734cd7..b69ae1736bb8 100644
>> ---
>> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Platfor
>> mDeviceDataSRP10nm.c
>> +++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/UbaMain/StaticSkuDataDxe/Pl
>> +++ atformDeviceDataSRP10nm.c
>> @@ -8,7 +8,6 @@
>>
>>  #include <PlatPirqData.h>
>>  #include <PlatDevData.h>
>> -#include <IndustryStandard/LegacyBiosMpTable.h>
>>
>>  #ifndef V_INTEL_VID
>>  #define V_INTEL_VID               0x8086
>>
>>
>>
>>
>>
> 
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111132): https://edk2.groups.io/g/devel/message/111132
Mute This Topic: https://groups.io/mt/102483850/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-