[edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest

Joey Vagedes via groups.io posted 2 patches 6 months ago
Failed in applying to current master (apply log)
.pytool/Plugin/HostUnitTestDscCompleteCheck/HostUnitTestDscCompleteCheck.py |  7 ++++---
.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py                           | 12 ++++++------
BaseTools/Plugin/DebugMacroCheck/BuildPlugin/DebugMacroCheckBuildPlugin.py  | 10 +++++-----
pip-requirements.txt                                                        |  4 ++--
4 files changed, 17 insertions(+), 16 deletions(-)
[edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest
Posted by Joey Vagedes via groups.io 6 months ago
Upgrades edk2-pytool-library to v0.19.3 and edk2-pytool-extensions to v0.25.1
and performs all necessary integrations as noted in the individual package
commits.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>

Joey Vagedes (2):
  .pytool: Integration of edk2-pytools
  BaseTools: Plugin: Integration of edk2-pytools

 .pytool/Plugin/HostUnitTestDscCompleteCheck/HostUnitTestDscCompleteCheck.py |  7 ++++---
 .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py                           | 12 ++++++------
 BaseTools/Plugin/DebugMacroCheck/BuildPlugin/DebugMacroCheckBuildPlugin.py  | 10 +++++-----
 pip-requirements.txt                                                        |  4 ++--
 4 files changed, 17 insertions(+), 16 deletions(-)

-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110215): https://edk2.groups.io/g/devel/message/110215
Mute This Topic: https://groups.io/mt/102223493/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest
Posted by Michael Kubacki 6 months ago
Series:

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 10/27/2023 11:15 AM, Joey Vagedes via groups.io wrote:
> Upgrades edk2-pytool-library to v0.19.3 and edk2-pytool-extensions to v0.25.1
> and performs all necessary integrations as noted in the individual package
> commits.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> 
> Joey Vagedes (2):
>    .pytool: Integration of edk2-pytools
>    BaseTools: Plugin: Integration of edk2-pytools
> 
>   .pytool/Plugin/HostUnitTestDscCompleteCheck/HostUnitTestDscCompleteCheck.py |  7 ++++---
>   .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py                           | 12 ++++++------
>   BaseTools/Plugin/DebugMacroCheck/BuildPlugin/DebugMacroCheckBuildPlugin.py  | 10 +++++-----
>   pip-requirements.txt                                                        |  4 ++--
>   4 files changed, 17 insertions(+), 16 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110224): https://edk2.groups.io/g/devel/message/110224
Mute This Topic: https://groups.io/mt/102223493/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest
Posted by Joey Vagedes via groups.io 6 months ago
Thank you for the reviews. Pending any reviews other maintainers of these packages would like to do, this patch series is ready to merge. I've updated the PR with the reviewed-by tags:

https://github.com/tianocore/edk2/pull/4966

Joey

-----Original Message-----
From: Michael Kubacki <mikuback@linux.microsoft.com> 
Sent: Friday, October 27, 2023 10:32 AM
To: devel@edk2.groups.io; Joey Vagedes <joeyvagedes@microsoft.com>
Cc: Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest

Series:

Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 10/27/2023 11:15 AM, Joey Vagedes via groups.io wrote:
> Upgrades edk2-pytool-library to v0.19.3 and edk2-pytool-extensions to 
> v0.25.1 and performs all necessary integrations as noted in the 
> individual package commits.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> 
> Joey Vagedes (2):
>    .pytool: Integration of edk2-pytools
>    BaseTools: Plugin: Integration of edk2-pytools
> 
>   .pytool/Plugin/HostUnitTestDscCompleteCheck/HostUnitTestDscCompleteCheck.py |  7 ++++---
>   .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py                           | 12 ++++++------
>   BaseTools/Plugin/DebugMacroCheck/BuildPlugin/DebugMacroCheckBuildPlugin.py  | 10 +++++-----
>   pip-requirements.txt                                                        |  4 ++--
>   4 files changed, 17 insertions(+), 16 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110225): https://edk2.groups.io/g/devel/message/110225
Mute This Topic: https://groups.io/mt/102223493/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest
Posted by Laszlo Ersek 6 months ago
On 10/27/23 19:41, Joey Vagedes via groups.io wrote:
> Thank you for the reviews. Pending any reviews other maintainers of these packages would like to do, this patch series is ready to merge. I've updated the PR with the reviewed-by tags:
> 
> https://github.com/tianocore/edk2/pull/4966

I figured I could try just adding the push label to your PR, but the
master branch had advanced meanwhile... So I've now picked up your
patches from the list, added the R-b tags, compared the new branch
against yours from the PR, and then created a new PR, with the "push"
label set:

https://github.com/tianocore/edk2/pull/4972

Hopefully this will complete.

Laszlo

> 
> Joey
> 
> -----Original Message-----
> From: Michael Kubacki <mikuback@linux.microsoft.com> 
> Sent: Friday, October 27, 2023 10:32 AM
> To: devel@edk2.groups.io; Joey Vagedes <joeyvagedes@microsoft.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> Subject: Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest
> 
> Series:
> 
> Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
> 
> On 10/27/2023 11:15 AM, Joey Vagedes via groups.io wrote:
>> Upgrades edk2-pytool-library to v0.19.3 and edk2-pytool-extensions to 
>> v0.25.1 and performs all necessary integrations as noted in the 
>> individual package commits.
>>
>> Cc: Sean Brogan <sean.brogan@microsoft.com>
>> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> Cc: Liming Gao <gaoliming@byosoft.com.cn>
>>
>> Joey Vagedes (2):
>>    .pytool: Integration of edk2-pytools
>>    BaseTools: Plugin: Integration of edk2-pytools
>>
>>   .pytool/Plugin/HostUnitTestDscCompleteCheck/HostUnitTestDscCompleteCheck.py |  7 ++++---
>>   .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py                           | 12 ++++++------
>>   BaseTools/Plugin/DebugMacroCheck/BuildPlugin/DebugMacroCheckBuildPlugin.py  | 10 +++++-----
>>   pip-requirements.txt                                                        |  4 ++--
>>   4 files changed, 17 insertions(+), 16 deletions(-)
>>
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110247): https://edk2.groups.io/g/devel/message/110247
Mute This Topic: https://groups.io/mt/102223493/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest
Posted by Laszlo Ersek 6 months ago
On 10/28/23 16:20, Laszlo Ersek wrote:
> On 10/27/23 19:41, Joey Vagedes via groups.io wrote:
>> Thank you for the reviews. Pending any reviews other maintainers of these packages would like to do, this patch series is ready to merge. I've updated the PR with the reviewed-by tags:
>>
>> https://github.com/tianocore/edk2/pull/4966
> 
> I figured I could try just adding the push label to your PR, but the
> master branch had advanced meanwhile... So I've now picked up your
> patches from the list, added the R-b tags, compared the new branch
> against yours from the PR, and then created a new PR, with the "push"
> label set:
> 
> https://github.com/tianocore/edk2/pull/4972
> 
> Hopefully this will complete.

It did: commit range 7ff6ab2b3e09..7806713f00e9.

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110249): https://edk2.groups.io/g/devel/message/110249
Mute This Topic: https://groups.io/mt/102223493/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 0/2] Upgrade edk2-pytools to latest
Posted by Rebecca Cran via groups.io 6 months ago
On 10/27/2023 9:15 AM, Joey Vagedes via groups.io wrote:
> Upgrades edk2-pytool-library to v0.19.3 and edk2-pytool-extensions to v0.25.1
> and performs all necessary integrations as noted in the individual package
> commits.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> 
> Joey Vagedes (2):
>    .pytool: Integration of edk2-pytools
>    BaseTools: Plugin: Integration of edk2-pytools
> 
>   .pytool/Plugin/HostUnitTestDscCompleteCheck/HostUnitTestDscCompleteCheck.py |  7 ++++---
>   .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py                           | 12 ++++++------
>   BaseTools/Plugin/DebugMacroCheck/BuildPlugin/DebugMacroCheckBuildPlugin.py  | 10 +++++-----
>   pip-requirements.txt                                                        |  4 ++--
>   4 files changed, 17 insertions(+), 16 deletions(-)
> 

For the series:

Reviewed-by: Rebecca Cran <rebecca@os.amperecomputing.com>

-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110218): https://edk2.groups.io/g/devel/message/110218
Mute This Topic: https://groups.io/mt/102223493/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-