*** Update Edk2-pytools to latest versions ***

[edk2-devel] [PATCH v2 08/12] RedfishPkg: CI: Add PrEval entry

Posted by Joey Vagedes via groups.io 2 years, 3 months ago

From: Joey Vagedes <joey.vagedes@gmail.com>

Adds a PrEval entry to the package's ci.yaml file which is used to
verify if the package uses a particular library instance when that
library instance file (INF) is updated.

When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the
package uses said library instance. If the package does use the library
instance, it will be built and tested to ensure the package is not
broken from the change.

Cc: Abner Chang <abner.chang@amd.com>
Cc: Nickle Wang <nicklew@nvidia.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>

Reviewed-by: Abner Chang <abner.chang@amd.com
---
 RedfishPkg/RedfishPkg.ci.yaml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
index 96133f8c288d..69b6bf39f5ce 100644
--- a/RedfishPkg/RedfishPkg.ci.yaml
+++ b/RedfishPkg/RedfishPkg.ci.yaml
@@ -5,6 +5,9 @@
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 ##
 {
+    "PrEval": {
+        "DscPath": "RedfishPkg.dsc",
+    },
     "LicenseCheck": {
         "IgnoreFiles": []
     },
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109943): https://edk2.groups.io/g/devel/message/109943
Mute This Topic: https://groups.io/mt/102140976/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 08/12] RedfishPkg: CI: Add PrEval entry

Posted by Nickle Wang via groups.io 2 years, 3 months ago

Reviewed-by: Nickle Wang <nicklew@nvidia.com>

Regards,
Nickle

> -----Original Message-----
> From: Joey Vagedes <joey.vagedes@gmail.com>
> Sent: Tuesday, October 24, 2023 1:52 AM
> To: devel@edk2.groups.io
> Cc: Abner Chang <abner.chang@amd.com>; Nickle Wang <nicklew@nvidia.com>;
> Igor Kulchytskyy <igork@ami.com>
> Subject: [PATCH v2 08/12] RedfishPkg: CI: Add PrEval entry
> 
> External email: Use caution opening links or attachments
> 
> 
> From: Joey Vagedes <joey.vagedes@gmail.com>
> 
> Adds a PrEval entry to the package's ci.yaml file which is used to verify if the
> package uses a particular library instance when that library instance file (INF) is
> updated.
> 
> When a library instance file (INF) is updated, PrEval will review each package's
> DSC as described in the ci.yaml file to determine if the package uses said library
> instance. If the package does use the library instance, it will be built and tested to
> ensure the package is not broken from the change.
> 
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
> 
> Reviewed-by: Abner Chang <abner.chang@amd.com
> ---
>  RedfishPkg/RedfishPkg.ci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml index
> 96133f8c288d..69b6bf39f5ce 100644
> --- a/RedfishPkg/RedfishPkg.ci.yaml
> +++ b/RedfishPkg/RedfishPkg.ci.yaml
> @@ -5,6 +5,9 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  ##
> 
>  {
> 
> +    "PrEval": {
> 
> +        "DscPath": "RedfishPkg.dsc",
> 
> +    },
> 
>      "LicenseCheck": {
> 
>          "IgnoreFiles": []
> 
>      },
> 
> --
> 2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109975): https://edk2.groups.io/g/devel/message/109975
Mute This Topic: https://groups.io/mt/102140976/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 08/12] RedfishPkg: CI: Add PrEval entry

Posted by Chang, Abner via groups.io 2 years, 3 months ago

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <abner.chang@amd.com>

> -----Original Message-----
> From: Joey Vagedes <joey.vagedes@gmail.com>
> Sent: Tuesday, October 24, 2023 1:52 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; Nickle Wang
> <nicklew@nvidia.com>; Igor Kulchytskyy <igork@ami.com>
> Subject: [PATCH v2 08/12] RedfishPkg: CI: Add PrEval entry
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> From: Joey Vagedes <joey.vagedes@gmail.com>
>
> Adds a PrEval entry to the package's ci.yaml file which is used to
> verify if the package uses a particular library instance when that
> library instance file (INF) is updated.
>
> When a library instance file (INF) is updated, PrEval will review each
> package's DSC as described in the ci.yaml file to determine if the
> package uses said library instance. If the package does use the library
> instance, it will be built and tested to ensure the package is not
> broken from the change.
>
> Cc: Abner Chang <abner.chang@amd.com>
> Cc: Nickle Wang <nicklew@nvidia.com>
> Cc: Igor Kulchytskyy <igork@ami.com>
> Signed-off-by: Joey Vagedes <joeyvagedes@gmail.com>
>
> Reviewed-by: Abner Chang <abner.chang@amd.com
> ---
>  RedfishPkg/RedfishPkg.ci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/RedfishPkg/RedfishPkg.ci.yaml b/RedfishPkg/RedfishPkg.ci.yaml
> index 96133f8c288d..69b6bf39f5ce 100644
> --- a/RedfishPkg/RedfishPkg.ci.yaml
> +++ b/RedfishPkg/RedfishPkg.ci.yaml
> @@ -5,6 +5,9 @@
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>
>  ##
>
>  {
>
> +    "PrEval": {
>
> +        "DscPath": "RedfishPkg.dsc",
>
> +    },
>
>      "LicenseCheck": {
>
>          "IgnoreFiles": []
>
>      },
>
> --
> 2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109972): https://edk2.groups.io/g/devel/message/109972
Mute This Topic: https://groups.io/mt/102140976/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-