[v1] RedfishClientPkg: various minor fixes

[edk2-devel] [PATCH 3/9] RedfishLib: remove redudant zeroing

Posted by Mike Maslenkin 2 years, 4 months ago

Memory allocated by calloc() is filled with bytes of value zero.

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
---
 .../PrivateLibrary/RedfishLib/edk2libredfish/src/service.c       | 1 -
 1 file changed, 1 deletion(-)

diff --git a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c b/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
index a38bdfbea65f..0ffc23725d37 100644
--- a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
+++ b/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
@@ -1773,7 +1773,6 @@ createServiceEnumeratorNoAuth (
   char            *HostStart;
 
   ret = (redfishService *)calloc (1, sizeof (redfishService));
-  ZeroMem (ret, sizeof (redfishService));
   if (initRest (ret, restProtocol) != 0) {
     free (ret);
     return NULL;
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109219): https://edk2.groups.io/g/devel/message/109219
Mute This Topic: https://groups.io/mt/101667462/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 3/9] RedfishLib: remove redudant zeroing

Posted by Chang, Abner via groups.io 2 years, 4 months ago

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <Abner.Chang@amd.com>

> -----Original Message-----
> From: Mike Maslenkin <mike.maslenkin@gmail.com>
> Sent: Saturday, September 30, 2023 5:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner <Abner.Chang@amd.com>; nicklew@nvidia.com;
> igork@ami.com; Mike Maslenkin <mike.maslenkin@gmail.com>
> Subject: [PATCH 3/9] RedfishLib: remove redudant zeroing
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Memory allocated by calloc() is filled with bytes of value zero.
>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
> ---
>  .../PrivateLibrary/RedfishLib/edk2libredfish/src/service.c       | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git
> a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
> b/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
> index a38bdfbea65f..0ffc23725d37 100644
> --- a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
> +++
> b/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
> @@ -1773,7 +1773,6 @@ createServiceEnumeratorNoAuth (
>    char            *HostStart;
>
>
>
>    ret = (redfishService *)calloc (1, sizeof (redfishService));
>
> -  ZeroMem (ret, sizeof (redfishService));
>
>    if (initRest (ret, restProtocol) != 0) {
>
>      free (ret);
>
>      return NULL;
>
> --
> 2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109244): https://edk2.groups.io/g/devel/message/109244
Mute This Topic: https://groups.io/mt/101667462/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-