[v3] Platform/ARM: Add dynamic CPU node, TRBE & ETE support to FVP

[edk2-devel] [PATCH edk2-platforms v3 0/3] Platform/ARM: Add dynamic CPU node, TRBE & ETE support to FVP

Posted by Sami Mujawar 1 year ago

This patch series updates the FVP platform firmware
to add support for dynamically generating CPU nodes
in AML and also reports the TRBE interrupt in the
MADT GICC structure. The last patch in the series
enables support for adding an ETE device to the CPU
device nodes in AML.

This patch series depends on the edk2 patch series
at: https://edk2.groups.io/g/devel/message/108996

Updates from v2 patch series:
  - Fixed comment for patch 2/3 and 3/3 to remove
    usage of magic numbers in feature detection code
    by introducing helper functions in ArmLib (which
    can be seen in patch 12/13 and 13/13 in the edk2
    patch series linked above) and using them instead.

Updates from v1 patch series:
  - Fixed comment in patch 2/3 to specify the TRBE
    interrupt as PPI 15.

The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/2620_ete_dev_fvp_v3

Sami Mujawar (3):
  Platform/ARM: Add dynamic CPU node generation for FVP
  Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC
  Platform/ARM: FVP: Add ETE device if supported by FVP

 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl          | 38 +-----------
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 64 +++++++++++++++++---
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h      |  4 +-
 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |  3 +-
 4 files changed, 61 insertions(+), 48 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109007): https://edk2.groups.io/g/devel/message/109007
Mute This Topic: https://groups.io/mt/101522378/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms v3 0/3] Platform/ARM: Add dynamic CPU node, TRBE & ETE support to FVP

Posted by PierreGondois 1 year ago

Hi Sami,
Thanks for the update:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

Regards,
Pierre

On 9/22/23 16:41, Sami Mujawar wrote:
> This patch series updates the FVP platform firmware
> to add support for dynamically generating CPU nodes
> in AML and also reports the TRBE interrupt in the
> MADT GICC structure. The last patch in the series
> enables support for adding an ETE device to the CPU
> device nodes in AML.
> 
> This patch series depends on the edk2 patch series
> at: https://edk2.groups.io/g/devel/message/108996
> 
> Updates from v2 patch series:
>    - Fixed comment for patch 2/3 and 3/3 to remove
>      usage of magic numbers in feature detection code
>      by introducing helper functions in ArmLib (which
>      can be seen in patch 12/13 and 13/13 in the edk2
>      patch series linked above) and using them instead.
> 
> Updates from v1 patch series:
>    - Fixed comment in patch 2/3 to specify the TRBE
>      interrupt as PPI 15.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2-platforms/tree/2620_ete_dev_fvp_v3
> 
> Sami Mujawar (3):
>    Platform/ARM: Add dynamic CPU node generation for FVP
>    Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC
>    Platform/ARM: FVP: Add ETE device if supported by FVP
> 
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl          | 38 +-----------
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 64 +++++++++++++++++---
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h      |  4 +-
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |  3 +-
>   4 files changed, 61 insertions(+), 48 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109011): https://edk2.groups.io/g/devel/message/109011
Mute This Topic: https://groups.io/mt/101522378/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms v3 0/3] Platform/ARM: Add dynamic CPU node, TRBE & ETE support to FVP

Posted by Sami Mujawar 11 months, 2 weeks ago

Merged as dc8de7cc888f..1ae7cffab740

Thanks.

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110319): https://edk2.groups.io/g/devel/message/110319
Mute This Topic: https://groups.io/mt/101522378/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-