[edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support

Sami Mujawar posted 11 patches 5 months ago
Failed in applying to current master (apply log)
ArmPkg/Include/Chipset/AArch64.h                                                       |   4 +
ArmPkg/Include/Library/ArmLib.h                                                        |  25 +++
ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c                                             |  31 ++++
DynamicTablesPkg/Include/ArmNameSpaceObjects.h                                         |  32 +++-
DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c                       | 108 +++++------
DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c                       |  79 ++++----
DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 188 +++++++++++++++++++-
DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.h |  11 +-
DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c      |  11 +-
MdePkg/Include/IndustryStandard/Acpi65.h                                               |   4 +-
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c                 |  48 ++++-
11 files changed, 442 insertions(+), 99 deletions(-)
[edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support
Posted by Sami Mujawar 5 months ago
This patch series provides the following updates:
- The patches 1 & 2 add the new fields introduced
  in MADT (APIC table) by ACPI 6.5 and the patch
  7/11 updates the Acpiview MADT parser accordingly.
- The patches 3, 4 & 5 adds TRBE support to the MADT
  table generator in DynamicTablesPkg.
- Patch 6/11 updates the FADT ACPI revision to 6.5.
- The patches 8, 9 & 10 add support to generate ETE
  device nodes.
- The 3rd last last patch series fixes a bug wherein
  the CPC token was incorrectly referenced.
- The last 2 patches in the series introduce helper
  functions to detect if TRBE and ETE features are
  supported.

Updates from v2 patch series:
- Updated patch 5 to removed superfluous initialisation
  of TRBE interrupt field for ACPI 6.4.
- Patch 12/13 introduces a helper function in ArmLib to
  detect if TRBE is supported.
- Patch 13/13 introduces a helper function in ArmLib to
  detect if ETE is supported.

Updates from v1 patch series:
  - Fixed issue with setting TRBE interrupt in patch 5/11.

The changes can be seen at:
https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v3

Sami Mujawar (13):
  MdePkg: MADT: Add Online capable flag in GICC
  MdePkg: MADT: Add TRBE interrupt to GICC
  DynamicTablesPkg: Add TRBE interrupt to GICC object
  DynamicTablesPkg: Add TRBE interrupt to GICC object parser
  DynamicTablesPkg: Update MADT generator for ACPI 6.5
  DynamicTablesPkg: Update FADT generator to ACPI 6.5
  ShellPkg: Acpiview: Update MADT parser for TRBE interrupt
  DynamicTablesPkg: Add an ET info object to Arm namespace
  DynamicTablesPkg: Add an ET info object parser
  DynamicTablesPkg: Add ETE device to CPU node in AML
  DynamicTablesPkg: Fix referencing of CPC token
  ArmPkg/ArmLib: Add ArmHasTrbe () helper function
  ArmPkg/ArmLib: Add ArmHasEte () helper function

 ArmPkg/Include/Chipset/AArch64.h                                                       |   4 +
 ArmPkg/Include/Library/ArmLib.h                                                        |  25 +++
 ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c                                             |  31 ++++
 DynamicTablesPkg/Include/ArmNameSpaceObjects.h                                         |  32 +++-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c                       | 108 +++++------
 DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c                       |  79 ++++----
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 188 +++++++++++++++++++-
 DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.h |  11 +-
 DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c      |  11 +-
 MdePkg/Include/IndustryStandard/Acpi65.h                                               |   4 +-
 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c                 |  48 ++++-
 11 files changed, 442 insertions(+), 99 deletions(-)

-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108996): https://edk2.groups.io/g/devel/message/108996
Mute This Topic: https://groups.io/mt/101522262/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support
Posted by Leif Lindholm 5 months ago
On Fri, Sep 22, 2023 at 15:35:03 +0100, Sami Mujawar wrote:
> This patch series provides the following updates:
> - The patches 1 & 2 add the new fields introduced
>   in MADT (APIC table) by ACPI 6.5 and the patch
>   7/11 updates the Acpiview MADT parser accordingly.
> - The patches 3, 4 & 5 adds TRBE support to the MADT
>   table generator in DynamicTablesPkg.
> - Patch 6/11 updates the FADT ACPI revision to 6.5.
> - The patches 8, 9 & 10 add support to generate ETE
>   device nodes.
> - The 3rd last last patch series fixes a bug wherein
>   the CPC token was incorrectly referenced.
> - The last 2 patches in the series introduce helper
>   functions to detect if TRBE and ETE features are
>   supported.
> 
> Updates from v2 patch series:
> - Updated patch 5 to removed superfluous initialisation
>   of TRBE interrupt field for ACPI 6.4.
> - Patch 12/13 introduces a helper function in ArmLib to
>   detect if TRBE is supported.
> - Patch 13/13 introduces a helper function in ArmLib to
>   detect if ETE is supported.
> 
> Updates from v1 patch series:
>   - Fixed issue with setting TRBE interrupt in patch 5/11.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v3

For 1-2,12-13:
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>


> Sami Mujawar (13):
>   MdePkg: MADT: Add Online capable flag in GICC
>   MdePkg: MADT: Add TRBE interrupt to GICC
>   DynamicTablesPkg: Add TRBE interrupt to GICC object
>   DynamicTablesPkg: Add TRBE interrupt to GICC object parser
>   DynamicTablesPkg: Update MADT generator for ACPI 6.5
>   DynamicTablesPkg: Update FADT generator to ACPI 6.5
>   ShellPkg: Acpiview: Update MADT parser for TRBE interrupt
>   DynamicTablesPkg: Add an ET info object to Arm namespace
>   DynamicTablesPkg: Add an ET info object parser
>   DynamicTablesPkg: Add ETE device to CPU node in AML
>   DynamicTablesPkg: Fix referencing of CPC token
>   ArmPkg/ArmLib: Add ArmHasTrbe () helper function
>   ArmPkg/ArmLib: Add ArmHasEte () helper function
> 
>  ArmPkg/Include/Chipset/AArch64.h                                                       |   4 +
>  ArmPkg/Include/Library/ArmLib.h                                                        |  25 +++
>  ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c                                             |  31 ++++
>  DynamicTablesPkg/Include/ArmNameSpaceObjects.h                                         |  32 +++-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c                       | 108 +++++------
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c                       |  79 ++++----
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 188 +++++++++++++++++++-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.h |  11 +-
>  DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c      |  11 +-
>  MdePkg/Include/IndustryStandard/Acpi65.h                                               |   4 +-
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c                 |  48 ++++-
>  11 files changed, 442 insertions(+), 99 deletions(-)
> 
> -- 
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109017): https://edk2.groups.io/g/devel/message/109017
Mute This Topic: https://groups.io/mt/101522262/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support
Posted by PierreGondois 5 months ago
Hi Sami,
Thanks for the update:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

Regards,
Pierre

On 9/22/23 16:35, Sami Mujawar wrote:
> This patch series provides the following updates:
> - The patches 1 & 2 add the new fields introduced
>    in MADT (APIC table) by ACPI 6.5 and the patch
>    7/11 updates the Acpiview MADT parser accordingly.
> - The patches 3, 4 & 5 adds TRBE support to the MADT
>    table generator in DynamicTablesPkg.
> - Patch 6/11 updates the FADT ACPI revision to 6.5.
> - The patches 8, 9 & 10 add support to generate ETE
>    device nodes.
> - The 3rd last last patch series fixes a bug wherein
>    the CPC token was incorrectly referenced.
> - The last 2 patches in the series introduce helper
>    functions to detect if TRBE and ETE features are
>    supported.
> 
> Updates from v2 patch series:
> - Updated patch 5 to removed superfluous initialisation
>    of TRBE interrupt field for ACPI 6.4.
> - Patch 12/13 introduces a helper function in ArmLib to
>    detect if TRBE is supported.
> - Patch 13/13 introduces a helper function in ArmLib to
>    detect if ETE is supported.
> 
> Updates from v1 patch series:
>    - Fixed issue with setting TRBE interrupt in patch 5/11.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v3
> 
> Sami Mujawar (13):
>    MdePkg: MADT: Add Online capable flag in GICC
>    MdePkg: MADT: Add TRBE interrupt to GICC
>    DynamicTablesPkg: Add TRBE interrupt to GICC object
>    DynamicTablesPkg: Add TRBE interrupt to GICC object parser
>    DynamicTablesPkg: Update MADT generator for ACPI 6.5
>    DynamicTablesPkg: Update FADT generator to ACPI 6.5
>    ShellPkg: Acpiview: Update MADT parser for TRBE interrupt
>    DynamicTablesPkg: Add an ET info object to Arm namespace
>    DynamicTablesPkg: Add an ET info object parser
>    DynamicTablesPkg: Add ETE device to CPU node in AML
>    DynamicTablesPkg: Fix referencing of CPC token
>    ArmPkg/ArmLib: Add ArmHasTrbe () helper function
>    ArmPkg/ArmLib: Add ArmHasEte () helper function
> 
>   ArmPkg/Include/Chipset/AArch64.h                                                       |   4 +
>   ArmPkg/Include/Library/ArmLib.h                                                        |  25 +++
>   ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c                                             |  31 ++++
>   DynamicTablesPkg/Include/ArmNameSpaceObjects.h                                         |  32 +++-
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c                       | 108 +++++------
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c                       |  79 ++++----
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 188 +++++++++++++++++++-
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.h |  11 +-
>   DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c      |  11 +-
>   MdePkg/Include/IndustryStandard/Acpi65.h                                               |   4 +-
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c                 |  48 ++++-
>   11 files changed, 442 insertions(+), 99 deletions(-)
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109012): https://edk2.groups.io/g/devel/message/109012
Mute This Topic: https://groups.io/mt/101522262/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support
Posted by Jeshua Smith via groups.io 4 months ago
This series has received:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

And also For 1-2,12-13:
Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

Can this be merged?

-----Original Message-----
From: Pierre Gondois <pierre.gondois@arm.com>
Sent: Friday, September 22, 2023 8:51 AM
To: Sami Mujawar <sami.mujawar@arm.com>; devel@edk2.groups.io
Cc: ardb+tianocore@kernel.org; quic_llindhol@quicinc.com; michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; zhichao.gao@intel.com; Anshuman.Khandual@arm.com; Matteo.Carlini@arm.com; Akanksha.Jain2@arm.com; Sibel.Allinson@arm.com; Jeshua Smith <jeshuas@nvidia.com>; nd@arm.com
Subject: Re: [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support

External email: Use caution opening links or attachments


Hi Sami,
Thanks for the update:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>

Regards,
Pierre

On 9/22/23 16:35, Sami Mujawar wrote:
> This patch series provides the following updates:
> - The patches 1 & 2 add the new fields introduced
>    in MADT (APIC table) by ACPI 6.5 and the patch
>    7/11 updates the Acpiview MADT parser accordingly.
> - The patches 3, 4 & 5 adds TRBE support to the MADT
>    table generator in DynamicTablesPkg.
> - Patch 6/11 updates the FADT ACPI revision to 6.5.
> - The patches 8, 9 & 10 add support to generate ETE
>    device nodes.
> - The 3rd last last patch series fixes a bug wherein
>    the CPC token was incorrectly referenced.
> - The last 2 patches in the series introduce helper
>    functions to detect if TRBE and ETE features are
>    supported.
>
> Updates from v2 patch series:
> - Updated patch 5 to removed superfluous initialisation
>    of TRBE interrupt field for ACPI 6.4.
> - Patch 12/13 introduces a helper function in ArmLib to
>    detect if TRBE is supported.
> - Patch 13/13 introduces a helper function in ArmLib to
>    detect if ETE is supported.
>
> Updates from v1 patch series:
>    - Fixed issue with setting TRBE interrupt in patch 5/11.
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v3
>
> Sami Mujawar (13):
>    MdePkg: MADT: Add Online capable flag in GICC
>    MdePkg: MADT: Add TRBE interrupt to GICC
>    DynamicTablesPkg: Add TRBE interrupt to GICC object
>    DynamicTablesPkg: Add TRBE interrupt to GICC object parser
>    DynamicTablesPkg: Update MADT generator for ACPI 6.5
>    DynamicTablesPkg: Update FADT generator to ACPI 6.5
>    ShellPkg: Acpiview: Update MADT parser for TRBE interrupt
>    DynamicTablesPkg: Add an ET info object to Arm namespace
>    DynamicTablesPkg: Add an ET info object parser
>    DynamicTablesPkg: Add ETE device to CPU node in AML
>    DynamicTablesPkg: Fix referencing of CPC token
>    ArmPkg/ArmLib: Add ArmHasTrbe () helper function
>    ArmPkg/ArmLib: Add ArmHasEte () helper function
>
>   ArmPkg/Include/Chipset/AArch64.h                                                       |   4 +
>   ArmPkg/Include/Library/ArmLib.h                                                        |  25 +++
>   ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c                                             |  31 ++++
>   DynamicTablesPkg/Include/ArmNameSpaceObjects.h                                         |  32 +++-
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c                       | 108 +++++------
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c                       |  79 ++++----
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 188 +++++++++++++++++++-
>   DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.h |  11 +-
>   DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c      |  11 +-
>   MdePkg/Include/IndustryStandard/Acpi65.h                                               |   4 +-
>   ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c                 |  48 ++++-
>   11 files changed, 442 insertions(+), 99 deletions(-)
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109931): https://edk2.groups.io/g/devel/message/109931
Mute This Topic: https://groups.io/mt/101522262/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support
Posted by Sami Mujawar 4 months ago
Dear MdePkg Maintainers,

Can I have your review feedback for the first 2 patches in this series, 
please?

- MdePkg: MADT: Add Online capable flag in GICC
- MdePkg: MADT: Add TRBE interrupt to GICC

I plan to merge this series by end of this week.

Regards,

Sami Mujawar

On 23/10/2023 04:30 pm, Jeshua Smith wrote:
> This series has received:
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
>
> And also For 1-2,12-13:
> Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
>
> Can this be merged?
>
> -----Original Message-----
> From: Pierre Gondois <pierre.gondois@arm.com>
> Sent: Friday, September 22, 2023 8:51 AM
> To: Sami Mujawar <sami.mujawar@arm.com>; devel@edk2.groups.io
> Cc: ardb+tianocore@kernel.org; quic_llindhol@quicinc.com; michael.d.kinney@intel.com; gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; zhichao.gao@intel.com; Anshuman.Khandual@arm.com; Matteo.Carlini@arm.com; Akanksha.Jain2@arm.com; Sibel.Allinson@arm.com; Jeshua Smith <jeshuas@nvidia.com>; nd@arm.com
> Subject: Re: [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support
>
> External email: Use caution opening links or attachments
>
>
> Hi Sami,
> Thanks for the update:
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
>
> Regards,
> Pierre
>
> On 9/22/23 16:35, Sami Mujawar wrote:
>> This patch series provides the following updates:
>> - The patches 1 & 2 add the new fields introduced
>>     in MADT (APIC table) by ACPI 6.5 and the patch
>>     7/11 updates the Acpiview MADT parser accordingly.
>> - The patches 3, 4 & 5 adds TRBE support to the MADT
>>     table generator in DynamicTablesPkg.
>> - Patch 6/11 updates the FADT ACPI revision to 6.5.
>> - The patches 8, 9 & 10 add support to generate ETE
>>     device nodes.
>> - The 3rd last last patch series fixes a bug wherein
>>     the CPC token was incorrectly referenced.
>> - The last 2 patches in the series introduce helper
>>     functions to detect if TRBE and ETE features are
>>     supported.
>>
>> Updates from v2 patch series:
>> - Updated patch 5 to removed superfluous initialisation
>>     of TRBE interrupt field for ACPI 6.4.
>> - Patch 12/13 introduces a helper function in ArmLib to
>>     detect if TRBE is supported.
>> - Patch 13/13 introduces a helper function in ArmLib to
>>     detect if ETE is supported.
>>
>> Updates from v1 patch series:
>>     - Fixed issue with setting TRBE interrupt in patch 5/11.
>>
>> The changes can be seen at:
>> https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v3
>>
>> Sami Mujawar (13):
>>     MdePkg: MADT: Add Online capable flag in GICC
>>     MdePkg: MADT: Add TRBE interrupt to GICC
>>     DynamicTablesPkg: Add TRBE interrupt to GICC object
>>     DynamicTablesPkg: Add TRBE interrupt to GICC object parser
>>     DynamicTablesPkg: Update MADT generator for ACPI 6.5
>>     DynamicTablesPkg: Update FADT generator to ACPI 6.5
>>     ShellPkg: Acpiview: Update MADT parser for TRBE interrupt
>>     DynamicTablesPkg: Add an ET info object to Arm namespace
>>     DynamicTablesPkg: Add an ET info object parser
>>     DynamicTablesPkg: Add ETE device to CPU node in AML
>>     DynamicTablesPkg: Fix referencing of CPC token
>>     ArmPkg/ArmLib: Add ArmHasTrbe () helper function
>>     ArmPkg/ArmLib: Add ArmHasEte () helper function
>>
>>    ArmPkg/Include/Chipset/AArch64.h                                                       |   4 +
>>    ArmPkg/Include/Library/ArmLib.h                                                        |  25 +++
>>    ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c                                             |  31 ++++
>>    DynamicTablesPkg/Include/ArmNameSpaceObjects.h                                         |  32 +++-
>>    DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c                       | 108 +++++------
>>    DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c                       |  79 ++++----
>>    DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 188 +++++++++++++++++++-
>>    DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.h |  11 +-
>>    DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c      |  11 +-
>>    MdePkg/Include/IndustryStandard/Acpi65.h                                               |   4 +-
>>    ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c                 |  48 ++++-
>>    11 files changed, 442 insertions(+), 99 deletions(-)
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109994): https://edk2.groups.io/g/devel/message/109994
Mute This Topic: https://groups.io/mt/101522262/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support
Posted by Gao, Zhichao 4 months ago
For the change of ShellPkg: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Sami Mujawar <sami.mujawar@arm.com>
> Sent: Tuesday, October 24, 2023 4:43 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>;
> Liu, Zhiguang <zhiguang.liu@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>
> Cc: Pierre Gondois <pierre.gondois@arm.com>; Jeshua Smith
> <jeshuas@nvidia.com>; ardb+tianocore@kernel.org;
> quic_llindhol@quicinc.com; Gao, Zhichao <zhichao.gao@intel.com>;
> Anshuman.Khandual@arm.com; Matteo.Carlini@arm.com;
> Akanksha.Jain2@arm.com; Sibel.Allinson@arm.com; nd@arm.com
> Subject: Re: [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE &
> ETE support
> 
> Dear MdePkg Maintainers,
> 
> Can I have your review feedback for the first 2 patches in this series, please?
> 
> - MdePkg: MADT: Add Online capable flag in GICC
> - MdePkg: MADT: Add TRBE interrupt to GICC
> 
> I plan to merge this series by end of this week.
> 
> Regards,
> 
> Sami Mujawar
> 
> On 23/10/2023 04:30 pm, Jeshua Smith wrote:
> > This series has received:
> > Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
> >
> > And also For 1-2,12-13:
> > Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>
> >
> > Can this be merged?
> >
> > -----Original Message-----
> > From: Pierre Gondois <pierre.gondois@arm.com>
> > Sent: Friday, September 22, 2023 8:51 AM
> > To: Sami Mujawar <sami.mujawar@arm.com>; devel@edk2.groups.io
> > Cc: ardb+tianocore@kernel.org; quic_llindhol@quicinc.com;
> > michael.d.kinney@intel.com; gaoliming@byosoft.com.cn;
> > zhiguang.liu@intel.com; zhichao.gao@intel.com;
> > Anshuman.Khandual@arm.com; Matteo.Carlini@arm.com;
> > Akanksha.Jain2@arm.com; Sibel.Allinson@arm.com; Jeshua Smith
> > <jeshuas@nvidia.com>; nd@arm.com
> > Subject: Re: [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE &
> > ETE support
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Hi Sami,
> > Thanks for the update:
> > Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
> >
> > Regards,
> > Pierre
> >
> > On 9/22/23 16:35, Sami Mujawar wrote:
> >> This patch series provides the following updates:
> >> - The patches 1 & 2 add the new fields introduced
> >>     in MADT (APIC table) by ACPI 6.5 and the patch
> >>     7/11 updates the Acpiview MADT parser accordingly.
> >> - The patches 3, 4 & 5 adds TRBE support to the MADT
> >>     table generator in DynamicTablesPkg.
> >> - Patch 6/11 updates the FADT ACPI revision to 6.5.
> >> - The patches 8, 9 & 10 add support to generate ETE
> >>     device nodes.
> >> - The 3rd last last patch series fixes a bug wherein
> >>     the CPC token was incorrectly referenced.
> >> - The last 2 patches in the series introduce helper
> >>     functions to detect if TRBE and ETE features are
> >>     supported.
> >>
> >> Updates from v2 patch series:
> >> - Updated patch 5 to removed superfluous initialisation
> >>     of TRBE interrupt field for ACPI 6.4.
> >> - Patch 12/13 introduces a helper function in ArmLib to
> >>     detect if TRBE is supported.
> >> - Patch 13/13 introduces a helper function in ArmLib to
> >>     detect if ETE is supported.
> >>
> >> Updates from v1 patch series:
> >>     - Fixed issue with setting TRBE interrupt in patch 5/11.
> >>
> >> The changes can be seen at:
> >> https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v3
> >>
> >> Sami Mujawar (13):
> >>     MdePkg: MADT: Add Online capable flag in GICC
> >>     MdePkg: MADT: Add TRBE interrupt to GICC
> >>     DynamicTablesPkg: Add TRBE interrupt to GICC object
> >>     DynamicTablesPkg: Add TRBE interrupt to GICC object parser
> >>     DynamicTablesPkg: Update MADT generator for ACPI 6.5
> >>     DynamicTablesPkg: Update FADT generator to ACPI 6.5
> >>     ShellPkg: Acpiview: Update MADT parser for TRBE interrupt
> >>     DynamicTablesPkg: Add an ET info object to Arm namespace
> >>     DynamicTablesPkg: Add an ET info object parser
> >>     DynamicTablesPkg: Add ETE device to CPU node in AML
> >>     DynamicTablesPkg: Fix referencing of CPC token
> >>     ArmPkg/ArmLib: Add ArmHasTrbe () helper function
> >>     ArmPkg/ArmLib: Add ArmHasEte () helper function
> >>
> >>    ArmPkg/Include/Chipset/AArch64.h                                                       |   4 +
> >>    ArmPkg/Include/Library/ArmLib.h                                                        |  25 +++
> >>    ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c                                             |
> 31 ++++
> >>    DynamicTablesPkg/Include/ArmNameSpaceObjects.h
> |  32 +++-
> >>    DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c
> | 108 +++++------
> >>
> DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c
> |  79 ++++----
> >>
> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuT
> opologyGenerator.c | 188 +++++++++++++++++++-
> >>
> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuT
> opologyGenerator.h |  11 +-
> >>
> DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManager
> ObjectParser.c      |  11 +-
> >>    MdePkg/Include/IndustryStandard/Acpi65.h                                               |   4
> +-
> >>
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.
> c                 |  48 ++++-
> >>    11 files changed, 442 insertions(+), 99 deletions(-)
> >>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110083): https://edk2.groups.io/g/devel/message/110083
Mute This Topic: https://groups.io/mt/101522262/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-