Resending to Cc the reviewers

These tests support platform firmware that implement
MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock
UEFI variables in accordance with TCG PC Platform Reset Attack
Mitigation Specification.

The 6 patches are split up according to the six sections
documented in the SCT spec linked below.

SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419

PR: https://github.com/tianocore/edk2-test/pull/78 

Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
Cc: Barton Gao <gaojie@byosoft.com.cn>
Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>

Abhi Singh (6):
  uefi-sct/SctPkg: TCG Platform Reset Check Test
  uefi-sct/SctPkg: TCG MOR SetVariable Test
  uefi-sct/SctPkg: TCG MORLOCK SetVariable Test
  uefi-sct/SctPkg: TCG MORLOCK Unlocked State Test
  uefi-sct/SctPkg: TCG MORLOCK Locked No Key State Test
  uefi-sct/SctPkg: TCG MORLOCK Locked with Key State Test

 uefi-sct/SctPkg/UEFI/UEFI_SCT.dsc                                                                                                  |    1 +
 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTest.inf       |   53 +
 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBoxTest/Guid.h                                    |  271 +++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestMain.h     |  137 ++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBoxTest/Guid.c                                    |  127 ++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestFunction.c | 2289 ++++++++++++++++++++
 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestMain.c     |  115 +
 uefi-sct/SctPkg/CommonGenFramework.sh                                                                                              |    1 +
 uefi-sct/SctPkg/Config/Data/Category.ini                                                                                           |    7 +
 9 files changed, 3001 insertions(+)
 create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTest.inf
 create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBoxTest/Guid.h
 create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestMain.h
 create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBoxTest/Guid.c
 create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestFunction.c
 create mode 100644 uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/TCGMemoryOverwriteRequest/BlackBoxTest/TCGMemoryOverwriteRequestBBTestMain.c

-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108950): https://edk2.groups.io/g/devel/message/108950
Mute This Topic: https://groups.io/mt/101504337/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On 9/21/23 11:37 AM, Abhimanyu Singh via groups.io wrote:
> Resending to Cc the reviewers
> 
> These tests support platform firmware that implement
> MemoryOverwriteRequestControl & MemoryOverwriteRequestControlLock
> UEFI variables in accordance with TCG PC Platform Reset Attack
> Mitigation Specification.
> 
> The 6 patches are split up according to the six sections
> documented in the SCT spec linked below.
> 
> SCT spec: https://bugzilla.tianocore.org/show_bug.cgi?id=4374
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4419
> 
> PR: https://github.com/tianocore/edk2-test/pull/78
> 
> Cc: G Edhaya Chandran <Edhaya.Chandran@arm.com>
> Cc: Barton Gao <gaojie@byosoft.com.cn>
> Cc: Carolyn Gjertsen <Carolyn.Gjertsen@amd.com>
> 
> Abhi Singh (6):
>    uefi-sct/SctPkg: TCG Platform Reset Check Test
>    uefi-sct/SctPkg: TCG MOR SetVariable Test
>    uefi-sct/SctPkg: TCG MORLOCK SetVariable Test
>    uefi-sct/SctPkg: TCG MORLOCK Unlocked State Test
>    uefi-sct/SctPkg: TCG MORLOCK Locked No Key State Test
>    uefi-sct/SctPkg: TCG MORLOCK Locked with Key State Test

Some general comments--

-on your next respin of this make sure you run the
  BaseTools/Scripts/PatchCheck.py on the patches.  There
  were a number of whitespace warnings when I applied the patches
  to my tree.

-delete the Change-Id on the patches, example:
  "Change-Id: I774d5893e5aff47690dadf90c36c7b9e7e7ee584"

-review your capitalization in comments and strings throughout
  the patches and be consistent.  Examples:
     -some references to DataSize variable are "datasize"
     -"When Locked with an 8 byte Key"... locked and key should be
      lowercase
     -some instance of "MORLOCK" some of "MORLock"
     -"Once Locked with no key, MORLOCK".  Should Locked be capitalized?
     -Now check to see if the Lock can still be unlocked.  Why is Lock
      capitalized?
     -there are various reference to state, such as
      Locked with Key State.  Would be better to make it something
      like:
          "Locked with Key" state
           Locked-with-Key state


Thanks,
Stuart


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108962): https://edk2.groups.io/g/devel/message/108962
Mute This Topic: https://groups.io/mt/101504337/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-