MdeModulePkg: Ignore TAB in string input

[edk2-devel] [PATCH v1] MdeModulePkg: Ignore TAB in string input

Posted by oscar.li@intel.com 7 months, 2 weeks ago

From: Oscar Li <oscar.li@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4550

Ignore TAB when handling input characters for string input to be consistent with the usual behavior.

Signed-off-by: Oscar Li <oscar.li@intel.com>
Cc: Dakota Chiang <dakota.chiang@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
---
 MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c b/MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c
index f70feeb55f..44e774ce24 100644
--- a/MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c
+++ b/MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c
@@ -226,6 +226,9 @@ ReadString (
           return EFI_DEVICE_ERROR;
         }
 
+      case CHAR_TAB:
+        break;
+
       case CHAR_BACKSPACE:
         if ((StringPtr[0] != CHAR_NULL) && (CurrentCursor != 0)) {
           for (Index = 0; Index < CurrentCursor - 1; Index++) {
-- 
2.41.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108797): https://edk2.groups.io/g/devel/message/108797
Mute This Topic: https://groups.io/mt/101435625/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v1] MdeModulePkg: Ignore TAB in string input

Posted by Dandan Bi 6 months, 1 week ago

Reviewed-by: Dandan Bi <dandan.bi@intel.com>


Thanks,
Dandan
-----Original Message-----
From: Li, Oscar <oscar.li@intel.com> 
Sent: Monday, September 18, 2023 3:26 PM
To: devel@edk2.groups.io
Cc: Li, Oscar <oscar.li@intel.com>; Chiang, Dakota <dakota.chiang@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Dong, Eric <eric.dong@intel.com>
Subject: [PATCH v1] MdeModulePkg: Ignore TAB in string input

From: Oscar Li <oscar.li@intel.com>

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4550

Ignore TAB when handling input characters for string input to be consistent with the usual behavior.

Signed-off-by: Oscar Li <oscar.li@intel.com>
Cc: Dakota Chiang <dakota.chiang@intel.com>
Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
---
 MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c b/MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c
index f70feeb55f..44e774ce24 100644
--- a/MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c
+++ b/MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c
@@ -226,6 +226,9 @@ ReadString (
           return EFI_DEVICE_ERROR;

         }

 

+      case CHAR_TAB:

+        break;

+

       case CHAR_BACKSPACE:

         if ((StringPtr[0] != CHAR_NULL) && (CurrentCursor != 0)) {

           for (Index = 0; Index < CurrentCursor - 1; Index++) {

-- 
2.41.0.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109777): https://edk2.groups.io/g/devel/message/109777
Mute This Topic: https://groups.io/mt/101435625/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-