1. Patchew
  2. EDK2
  3. [edk2-devel] [PATCH v3 0/2] UefiPayloadPkg supports Fit
  4. View patch

[edk2-devel] [PATCH v3 1/2] MdePkg/BaseFdtLib: Add Fdt function.

brucex.wang@intel.com posted 2 patches 11 months, 3 weeks ago
[edk2-devel] [PATCH v3 1/2] MdePkg/BaseFdtLib: Add Fdt function.
Posted by brucex.wang@intel.com 11 months, 3 weeks ago 
From: "Brucex.Wang" <brucex.wang@intel.com>

Add FdtGetName() and FdtNodeDepth() function.

Cc: Benny Lin <benny.lin@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: James Lu <james.lu@intel.com>

Signed-off-by: BruceX Wang <brucex.wang@intel.com>
---
 MdePkg/Include/Library/FdtLib.h    | 34 +++++++++++++++++++++++++
 MdePkg/Library/BaseFdtLib/FdtLib.c | 40 ++++++++++++++++++++++++++++++
 2 files changed, 74 insertions(+)

diff --git a/MdePkg/Include/Library/FdtLib.h b/MdePkg/Include/Library/FdtLib.h
index cf5ceba9e9..2bd926b5b4 100644
--- a/MdePkg/Include/Library/FdtLib.h
+++ b/MdePkg/Include/Library/FdtLib.h
@@ -398,4 +398,38 @@ FdtSetProp (
   IN UINT32       Length
   );
 
+/**
+  Returns the name of a given node.
+
+  @param[in] Fdt            The pointer to FDT blob.
+  @param[in] NodeOffse      Offset of node to check.
+  @param[in] Length         The pointer to an integer variable (will be overwritten) or NULL.
+
+  @return The pointer to the node's name.
+
+**/
+CONST CHAR8 *
+EFIAPI
+FdtGetName (
+  IN VOID    *Fdt,
+  IN INT32   NodeOffset,
+  IN UINT32  *Length
+  );
+
+/**
+  FdtNodeDepth() finds the depth of a given node.  The root node
+  has depth 0, its immediate subnodes depth 1 and so forth.
+
+  @param[in] Fdt            The pointer to FDT blob.
+  @param[in] NodeOffset     Offset of node to check.
+
+  @return Depth of the node at NodeOffset.
+ **/
+INT32
+EFIAPI
+FdtNodeDepth (
+  IN CONST VOID  *Fdt,
+  IN INT32       NodeOffset
+  );
+
 #endif /* FDT_LIB_H_ */
diff --git a/MdePkg/Library/BaseFdtLib/FdtLib.c b/MdePkg/Library/BaseFdtLib/FdtLib.c
index 090b0b3fd4..1ef99ea882 100644
--- a/MdePkg/Library/BaseFdtLib/FdtLib.c
+++ b/MdePkg/Library/BaseFdtLib/FdtLib.c
@@ -402,3 +402,43 @@ FdtSetProp (
 {
   return fdt_setprop (Fdt, NodeOffset, Name, Value, (int)Length);
 }
+
+/**
+  Returns the name of a given node.
+
+  @param[in] Fdt            The pointer to FDT blob.
+  @param[in] NodeOffset     Offset of node to check.
+  @param[in] Length         The pointer to an integer variable (will be overwritten) or NULL.
+
+  @return The pointer to the node's name.
+
+**/
+CONST CHAR8 *
+EFIAPI
+FdtGetName (
+  IN VOID    *Fdt,
+  IN INT32   NodeOffset,
+  IN UINT32  *Length
+  )
+{
+  return fdt_get_name (Fdt, NodeOffset, (int *)Length);
+}
+
+/**
+  FdtNodeDepth() finds the depth of a given node.  The root node
+  has depth 0, its immediate subnodes depth 1 and so forth.
+
+  @param[in] Fdt            The pointer to FDT blob.
+  @param[in] NodeOffset     Offset of node to check.
+
+  @returns Depth of the node at NodeOffset.
+**/
+INT32
+EFIAPI
+FdtNodeDepth (
+  IN CONST VOID  *Fdt,
+  IN INT32       NodeOffset
+  )
+{
+  return fdt_node_depth (Fdt, NodeOffset);
+}
-- 
2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108754): https://edk2.groups.io/g/devel/message/108754
Mute This Topic: https://groups.io/mt/101398211/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v3 1/2] MdePkg/BaseFdtLib: Add Fdt function.
Posted by Benny Lin 11 months, 3 weeks ago 
Hi, Bruce,

A redundant space in the function comment of FdtNodeDepth.
Please find my comment below. Thanks!

QQQ
Benny

________________________________
From: Wang, BruceX <brucex.wang@intel.com>
Sent: Saturday, September 16, 2023 6:53:17 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Wang, BruceX <brucex.wang@intel.com>; Lin, Benny <benny.lin@intel.com>; Guo, Gua <gua.guo@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>; Lu, James <james.lu@intel.com>
Subject: [PATCH v3 1/2] MdePkg/BaseFdtLib: Add Fdt function.

From: "Brucex.Wang" <brucex.wang@intel.com>

Add FdtGetName() and FdtNodeDepth() function.

Cc: Benny Lin <benny.lin@intel.com>
Cc: Gua Guo <gua.guo@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: James Lu <james.lu@intel.com>

Signed-off-by: BruceX Wang <brucex.wang@intel.com>
---
 MdePkg/Include/Library/FdtLib.h    | 34 +++++++++++++++++++++++++
 MdePkg/Library/BaseFdtLib/FdtLib.c | 40 ++++++++++++++++++++++++++++++
 2 files changed, 74 insertions(+)

diff --git a/MdePkg/Include/Library/FdtLib.h b/MdePkg/Include/Library/FdtLib.h
index cf5ceba9e9..2bd926b5b4 100644
--- a/MdePkg/Include/Library/FdtLib.h
+++ b/MdePkg/Include/Library/FdtLib.h
@@ -398,4 +398,38 @@ FdtSetProp (
   IN UINT32       Length

   );



+/**

+  Returns the name of a given node.

+

+  @param[in] Fdt            The pointer to FDT blob.

+  @param[in] NodeOffse      Offset of node to check.

+  @param[in] Length         The pointer to an integer variable (will be overwritten) or NULL.

+

+  @return The pointer to the node's name.

+

+**/

+CONST CHAR8 *

+EFIAPI

+FdtGetName (

+  IN VOID    *Fdt,

+  IN INT32   NodeOffset,

+  IN UINT32  *Length

+  );

+

+/**

+  FdtNodeDepth() finds the depth of a given node.  The root node

+  has depth 0, its immediate subnodes depth 1 and so forth.

+

+  @param[in] Fdt            The pointer to FDT blob.

+  @param[in] NodeOffset     Offset of node to check.

+

+  @return Depth of the node at NodeOffset.

+ **/
> A redundant space.

+INT32

+EFIAPI

+FdtNodeDepth (

+  IN CONST VOID  *Fdt,

+  IN INT32       NodeOffset

+  );

+

 #endif /* FDT_LIB_H_ */

diff --git a/MdePkg/Library/BaseFdtLib/FdtLib.c b/MdePkg/Library/BaseFdtLib/FdtLib.c
index 090b0b3fd4..1ef99ea882 100644
--- a/MdePkg/Library/BaseFdtLib/FdtLib.c
+++ b/MdePkg/Library/BaseFdtLib/FdtLib.c
@@ -402,3 +402,43 @@ FdtSetProp (
 {

   return fdt_setprop (Fdt, NodeOffset, Name, Value, (int)Length);

 }

+

+/**

+  Returns the name of a given node.

+

+  @param[in] Fdt            The pointer to FDT blob.

+  @param[in] NodeOffset     Offset of node to check.

+  @param[in] Length         The pointer to an integer variable (will be overwritten) or NULL.

+

+  @return The pointer to the node's name.

+

+**/

+CONST CHAR8 *

+EFIAPI

+FdtGetName (

+  IN VOID    *Fdt,

+  IN INT32   NodeOffset,

+  IN UINT32  *Length

+  )

+{

+  return fdt_get_name (Fdt, NodeOffset, (int *)Length);

+}

+

+/**

+  FdtNodeDepth() finds the depth of a given node.  The root node

+  has depth 0, its immediate subnodes depth 1 and so forth.

+

+  @param[in] Fdt            The pointer to FDT blob.

+  @param[in] NodeOffset     Offset of node to check.

+

+  @returns Depth of the node at NodeOffset.

+**/

+INT32

+EFIAPI

+FdtNodeDepth (

+  IN CONST VOID  *Fdt,

+  IN INT32       NodeOffset

+  )

+{

+  return fdt_node_depth (Fdt, NodeOffset);

+}

--
2.39.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108766): https://edk2.groups.io/g/devel/message/108766
Mute This Topic: https://groups.io/mt/101398211/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.