Platform/Intel/Tools/GenBiosId/GenBiosId.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
The length of the Board ID is being updated based on the BOARD_ID
string. If the PCH_TYPE is empty space/single quotes(''), removing the
empty space/single quotes('') and concatenating the
TARGET_PLATFORM_SHORT and BUILD flag strings.
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Cc: T V Krishnamoorthy <krishnamoorthy.t.v@intel.com>
Signed-off-by: ManickamX Srinivasan <manickamx.srinivasan@intel.com>
---
Platform/Intel/Tools/GenBiosId/GenBiosId.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py b/Platform/Intel/Tools/GenBiosId/GenBiosId.py
index fa3689867..54503fdfc 100644
--- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py
+++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py
@@ -141,14 +141,16 @@ def ParserInputFile(InputDict, NoTimestamp):
if Item not in _ConfigItem:
EdkLogger("GenBiosId", FORMAT_INVALID, ExtraData=_ConfigItemInvalid % Item)
_ConfigItem[Item]['Value'] = InputDict[Item]
- if len(_ConfigItem[Item]['Value']) != _ConfigItem[Item]['Length']:
+ if ((len(_ConfigItem[Item]['Value']) != _ConfigItem[Item]['Length'])|(_ConfigItem["BOARD_ID"]['Value'][3:4] == " ")):
# The length of the Board ID is being updated based on the BOARD_ID string
#If the PCH_TYPE is empty space/single quotes(''), removing the empty space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT and BUILD flag strings
if(_ConfigItem["BOARD_ID"]['Value'][3:5] == "\'\'"):
_ConfigItem["BOARD_ID"]['Value']=_ConfigItem["BOARD_ID"]['Value'][0:3]+_ConfigItem["BOARD_ID"]['Value'][5:len(_ConfigItem["BOARD_ID"]['Value'])]
- _ConfigItem["BOARD_ID"]['Length']=len(_ConfigItem["BOARD_ID"]['Value'])
+ elif (_ConfigItem["BOARD_ID"]['Value'][3:4] == " "):
+ _ConfigItem["BOARD_ID"]['Value']=_ConfigItem["BOARD_ID"]['Value'][0:3]+_ConfigItem["BOARD_ID"]['Value'][4:len(_ConfigItem["BOARD_ID"]['Value'])]
else:
EdkLogger("GenBiosId", FORMAT_INVALID, ExtraData=_ConfigLenInvalid % Item)
+ _ConfigItem["BOARD_ID"]['Length']=len(_ConfigItem["BOARD_ID"]['Value'])
for Item in _ConfigItem:
if not _ConfigItem[Item]['Value']:
EdkLogger("GenBiosId", FORMAT_UNKNOWN_ERROR, ExtraData="Item %s is missing" % Item)
--
2.30.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108574): https://edk2.groups.io/g/devel/message/108574
Mute This Topic: https://groups.io/mt/101333312/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Yuwei Chen <yuwei.chen@intel.com> > -----Original Message----- > From: Srinivasan, ManickamX <manickamx.srinivasan@intel.com> > Sent: Wednesday, September 13, 2023 4:56 PM > To: devel@edk2.groups.io > Cc: Srinivasan, ManickamX <manickamx.srinivasan@intel.com>; Feng, Bob C > <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, > Christine <yuwei.chen@intel.com>; T V, Krishnamoorthy > <krishnamoorthy.t.v@intel.com> > Subject: [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE > support > > The length of the Board ID is being updated based on the BOARD_ID string. If > the PCH_TYPE is empty space/single quotes(''), removing the empty > space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT > and BUILD flag strings. > > Cc: Bob Feng <bob.c.feng@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Yuwei Chen <yuwei.chen@intel.com> > Cc: T V Krishnamoorthy <krishnamoorthy.t.v@intel.com> > Signed-off-by: ManickamX Srinivasan <manickamx.srinivasan@intel.com> > --- > Platform/Intel/Tools/GenBiosId/GenBiosId.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py > b/Platform/Intel/Tools/GenBiosId/GenBiosId.py > index fa3689867..54503fdfc 100644 > --- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py > +++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py > @@ -141,14 +141,16 @@ def ParserInputFile(InputDict, NoTimestamp): > if Item not in _ConfigItem: > EdkLogger("GenBiosId", FORMAT_INVALID, > ExtraData=_ConfigItemInvalid % Item) > _ConfigItem[Item]['Value'] = InputDict[Item] > - if len(_ConfigItem[Item]['Value']) != _ConfigItem[Item]['Length']: > + if ((len(_ConfigItem[Item]['Value']) != > _ConfigItem[Item]['Length'])|(_ConfigItem["BOARD_ID"]['Value'][3:4] == " ")): > # The length of the Board ID is being updated based on the BOARD_ID > string > #If the PCH_TYPE is empty space/single quotes(''), removing the empty > space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT > and BUILD flag strings > if(_ConfigItem["BOARD_ID"]['Value'][3:5] == "\'\'"): > > _ConfigItem["BOARD_ID"]['Value']=_ConfigItem["BOARD_ID"]['Value'][0:3]+_ > ConfigItem["BOARD_ID"]['Value'][5:len(_ConfigItem["BOARD_ID"]['Value'])] > - > _ConfigItem["BOARD_ID"]['Length']=len(_ConfigItem["BOARD_ID"]['Value']) > + elif (_ConfigItem["BOARD_ID"]['Value'][3:4] == " "): > + > + _ConfigItem["BOARD_ID"]['Value']=_ConfigItem["BOARD_ID"]['Value'][0:3] > + +_ConfigItem["BOARD_ID"]['Value'][4:len(_ConfigItem["BOARD_ID"]['Value > + '])] > else: > EdkLogger("GenBiosId", FORMAT_INVALID, > ExtraData=_ConfigLenInvalid % Item) > + > + _ConfigItem["BOARD_ID"]['Length']=len(_ConfigItem["BOARD_ID"]['Value'] > + ) > for Item in _ConfigItem: > if not _ConfigItem[Item]['Value']: > EdkLogger("GenBiosId", FORMAT_UNKNOWN_ERROR, > ExtraData="Item %s is missing" % Item) > -- > 2.30.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108713): https://edk2.groups.io/g/devel/message/108713 Mute This Topic: https://groups.io/mt/101333312/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Reviewed-by: Bob Feng <bob.c.feng@intel.com> -----Original Message----- From: Srinivasan, ManickamX <manickamx.srinivasan@intel.com> Sent: Wednesday, September 13, 2023 4:56 PM To: devel@edk2.groups.io Cc: Srinivasan, ManickamX <manickamx.srinivasan@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Chen, Christine <yuwei.chen@intel.com>; T V, Krishnamoorthy <krishnamoorthy.t.v@intel.com> Subject: [PATCH] Platform/Intel: Enhance the BOARD_ID without PCH_TYPE support The length of the Board ID is being updated based on the BOARD_ID string. If the PCH_TYPE is empty space/single quotes(''), removing the empty space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT and BUILD flag strings. Cc: Bob Feng <bob.c.feng@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Yuwei Chen <yuwei.chen@intel.com> Cc: T V Krishnamoorthy <krishnamoorthy.t.v@intel.com> Signed-off-by: ManickamX Srinivasan <manickamx.srinivasan@intel.com> --- Platform/Intel/Tools/GenBiosId/GenBiosId.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py b/Platform/Intel/Tools/GenBiosId/GenBiosId.py index fa3689867..54503fdfc 100644 --- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py +++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py @@ -141,14 +141,16 @@ def ParserInputFile(InputDict, NoTimestamp): if Item not in _ConfigItem: EdkLogger("GenBiosId", FORMAT_INVALID, ExtraData=_ConfigItemInvalid % Item) _ConfigItem[Item]['Value'] = InputDict[Item] - if len(_ConfigItem[Item]['Value']) != _ConfigItem[Item]['Length']: + if ((len(_ConfigItem[Item]['Value']) != _ConfigItem[Item]['Length'])|(_ConfigItem["BOARD_ID"]['Value'][3:4] == " ")): # The length of the Board ID is being updated based on the BOARD_ID string #If the PCH_TYPE is empty space/single quotes(''), removing the empty space/single quotes('') and concatenating the TARGET_PLATFORM_SHORT and BUILD flag strings if(_ConfigItem["BOARD_ID"]['Value'][3:5] == "\'\'"): _ConfigItem["BOARD_ID"]['Value']=_ConfigItem["BOARD_ID"]['Value'][0:3]+_ConfigItem["BOARD_ID"]['Value'][5:len(_ConfigItem["BOARD_ID"]['Value'])] - _ConfigItem["BOARD_ID"]['Length']=len(_ConfigItem["BOARD_ID"]['Value']) + elif (_ConfigItem["BOARD_ID"]['Value'][3:4] == " "): + + _ConfigItem["BOARD_ID"]['Value']=_ConfigItem["BOARD_ID"]['Value'][0:3] + +_ConfigItem["BOARD_ID"]['Value'][4:len(_ConfigItem["BOARD_ID"]['Value + '])] else: EdkLogger("GenBiosId", FORMAT_INVALID, ExtraData=_ConfigLenInvalid % Item) + + _ConfigItem["BOARD_ID"]['Length']=len(_ConfigItem["BOARD_ID"]['Value'] + ) for Item in _ConfigItem: if not _ConfigItem[Item]['Value']: EdkLogger("GenBiosId", FORMAT_UNKNOWN_ERROR, ExtraData="Item %s is missing" % Item) -- 2.30.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108697): https://edk2.groups.io/g/devel/message/108697 Mute This Topic: https://groups.io/mt/101333312/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.