Please review small improvements to UsbNetwork

Here is corresponding PR https://github.com/tianocore/edk2/pull/4762

Cc: Richard Ho <richardho@ami.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108039): https://edk2.groups.io/g/devel/message/108039
Mute This Topic: https://groups.io/mt/100968486/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Pushed as:

https://github.com/tianocore/edk2/commit/e07948255cfafb75fa9cbe4555bfe3421488dd9a

https://github.com/tianocore/edk2/commit/03d6569f70939d2a1653265367121212459a6b89


-- 
Rebecca Cran


On 8/25/23 19:57, Mike Maslenkin wrote:
> Please review small improvements to UsbNetwork
>
> Here is corresponding PR https://github.com/tianocore/edk2/pull/4762
>
> Cc: Richard Ho <richardho@ami.com>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109658): https://edk2.groups.io/g/devel/message/109658
Mute This Topic: https://groups.io/mt/100968486/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Rebecca,

We have tried the patch. It works on my device.
I think it could be add it into UsbNetwork source. Do you think?

Thanks,
Richard
-----Original Message-----
From: Mike Maslenkin <mike.maslenkin@gmail.com>
Sent: 2023年8月26日 9:58 AM
To: devel@edk2.groups.io
Cc: Richard Ho (何明忠) <RichardHo@ami.com>; rebecca@bsdio.com; Mike Maslenkin <mike.maslenkin@gmail.com>
Subject: [EXTERNAL] [PATCH 0/2] MdeModulePkg: small improvements to UsbNetwork


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

Please review small improvements to UsbNetwork

Here is corresponding PR https://github.com/tianocore/edk2/pull/4762

Cc: Richard Ho <richardho@ami.com>
Cc: Rebecca Cran <rebecca@bsdio.com>
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>

-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108111): https://edk2.groups.io/g/devel/message/108111
Mute This Topic: https://groups.io/mt/100968486/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On 8/29/2023 8:05 PM, Richard Ho (何明忠) wrote:
> Hi Rebecca,
> 
> We have tried the patch. It works on my device.
> I think it could be add it into UsbNetwork source. Do you think?

I agree, it looks good.

Reviewed-by: Rebecca Cran <rebecca@bsdio.com>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108188): https://edk2.groups.io/g/devel/message/108188
Mute This Topic: https://groups.io/mt/100968486/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Thu, Aug 31, 2023 at 3:32 PM Rebecca Cran <rebecca@bsdio.com> wrote:
>
> On 8/29/2023 8:05 PM, Richard Ho (何明忠) wrote:
> > Hi Rebecca,
> >
> > We have tried the patch. It works on my device.
> > I think it could be add it into UsbNetwork source. Do you think?
>
> I agree, it looks good.
>
> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
>

Ping.
Should I send v2 with R-b set?

Regards,
MIke.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109389): https://edk2.groups.io/g/devel/message/109389
Mute This Topic: https://groups.io/mt/100968486/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Sorry for the extreme delay!

No need to send a v2 - I can commit this.


-- 

Rebecca Cran


On 10/8/23 04:20, Mike Maslenkin wrote:
> On Thu, Aug 31, 2023 at 3:32 PM Rebecca Cran <rebecca@bsdio.com> wrote:
>> On 8/29/2023 8:05 PM, Richard Ho (何明忠) wrote:
>>> Hi Rebecca,
>>>
>>> We have tried the patch. It works on my device.
>>> I think it could be add it into UsbNetwork source. Do you think?
>> I agree, it looks good.
>>
>> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
>>
> Ping.
> Should I send v2 with R-b set?
>
> Regards,
> MIke.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109656): https://edk2.groups.io/g/devel/message/109656
Mute This Topic: https://groups.io/mt/100968486/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-