[edk2-devel] [PATCH v2 7/7] .pytool: Undo uncrustify check change

VivianNK posted 7 patches 2 years, 5 months ago
[edk2-devel] [PATCH v2 7/7] .pytool: Undo uncrustify check change
Posted by VivianNK 2 years, 5 months ago
Set global audit only to False now that new rules have been applied to
all necessary packages.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Michael Kubacki <mikuback@linux.microsoft.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
---
 .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
index 17f77b48d954..ffc72f2c5918 100644
--- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
+++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
@@ -530,7 +530,7 @@ class UncrustifyCheck(ICiBuildPlugin):
         """
         Initializes options that influence test case output.
         """
-        self._audit_only_mode = True
+        self._audit_only_mode = False
         self._output_file_diffs = True
 
         if "AuditOnly" in self._package_config and self._package_config["AuditOnly"]:
-- 
2.41.0.windows.3



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107816): https://edk2.groups.io/g/devel/message/107816
Mute This Topic: https://groups.io/mt/100788672/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 7/7] .pytool: Undo uncrustify check change
Posted by Michael Kubacki 2 years, 5 months ago
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>

On 8/16/2023 5:15 PM, VivianNK wrote:
> Set global audit only to False now that new rules have been applied to
> all necessary packages.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
> ---
>   .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> index 17f77b48d954..ffc72f2c5918 100644
> --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> @@ -530,7 +530,7 @@ class UncrustifyCheck(ICiBuildPlugin):
>           """
> 
>           Initializes options that influence test case output.
> 
>           """
> 
> -        self._audit_only_mode = True
> 
> +        self._audit_only_mode = False
> 
>           self._output_file_diffs = True
> 
>   
> 
>           if "AuditOnly" in self._package_config and self._package_config["AuditOnly"]:
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107818): https://edk2.groups.io/g/devel/message/107818
Mute This Topic: https://groups.io/mt/100788672/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-