[edk2-devel] [PATCH v1 1/7] .pytool: Set uncrustify check to audit only

VivianNK posted 7 patches 2 years, 6 months ago
There is a newer version of this series
[edk2-devel] [PATCH v1 1/7] .pytool: Set uncrustify check to audit only
Posted by VivianNK 2 years, 6 months ago
Temporarily set uncrustify to audit only to prevent build failures.

CC: Sean Brogan <sean.brogan@microsoft.com>
CC: Michael Kubacki <mikuback@linux.microsoft.com>
CC: Michael D Kinney <michael.d.kinney@intel.com>
CC: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
---
 .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
index 8dc9ffe6945a..8978ffc443bf 100644
--- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
+++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
@@ -530,7 +530,7 @@ class UncrustifyCheck(ICiBuildPlugin):
         """
         Initializes options that influence test case output.
         """
-        self._audit_only_mode = False
+        self._audit_only_mode = True
         self._output_file_diffs = True
 
         if "AuditOnly" in self._package_config and self._package_config["AuditOnly"]:
-- 
2.41.0.windows.3
1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107667): https://edk2.groups.io/g/devel/message/107667
Mute This Topic: https://groups.io/mt/100655290/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1 1/7] .pytool: Set uncrustify check to audit only
Posted by Michael Kubacki 2 years, 5 months ago
Was this meant to be included in the series? We wouldn't want audit only 
mode always enabled.

On 8/9/2023 5:32 PM, VivianNK wrote:
> Temporarily set uncrustify to audit only to prevent build failures.
> 
> CC: Sean Brogan <sean.brogan@microsoft.com>
> CC: Michael Kubacki <mikuback@linux.microsoft.com>
> CC: Michael D Kinney <michael.d.kinney@intel.com>
> CC: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
> ---
>   .pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> index 8dc9ffe6945a..8978ffc443bf 100644
> --- a/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> +++ b/.pytool/Plugin/UncrustifyCheck/UncrustifyCheck.py
> @@ -530,7 +530,7 @@ class UncrustifyCheck(ICiBuildPlugin):
>           """
> 
>           Initializes options that influence test case output.
> 
>           """
> 
> -        self._audit_only_mode = False
> 
> +        self._audit_only_mode = True
> 
>           self._output_file_diffs = True
> 
>   
> 
>           if "AuditOnly" in self._package_config and self._package_config["AuditOnly"]:
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107751): https://edk2.groups.io/g/devel/message/107751
Mute This Topic: https://groups.io/mt/100655290/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-