To iterate entire SMBIOS table records for searching specific records,
"SmbiosHandle" input need to be as "SMBIOS_HANDLE_PI_RESERVED". This
patch helps to fix that.

Cc: Leif Lindholm <quic_llindhol@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
---
 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
index 3a5626b50c0d..7250da02b3ac 100644
--- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
+++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
@@ -8,6 +8,7 @@
   Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
   Copyright (c) 2015, Hisilicon Limited. All rights reserved.<BR>
   Copyright (c) 2015, Linaro Limited. All rights reserved.<BR>
+  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -159,6 +160,7 @@ GetHandleCount (
   EFI_SMBIOS_TABLE_HEADER  *Record;
 
   HandleCount = 0;
+  SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED;
 
   // Iterate through entries to get the number
   do {
-- 
2.39.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104980): https://edk2.groups.io/g/devel/message/104980
Mute This Topic: https://groups.io/mt/98948707/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Minh,

Thank you for this fix.

This change looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 16/05/2023 08:08 am, Minh Nguyen wrote:
> To iterate entire SMBIOS table records for searching specific records,
> "SmbiosHandle" input need to be as "SMBIOS_HANDLE_PI_RESERVED". This
> patch helps to fix that.
>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Minh Nguyen <minhnguyen1@os.amperecomputing.com>
> ---
>   ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> index 3a5626b50c0d..7250da02b3ac 100644
> --- a/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> +++ b/ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c
> @@ -8,6 +8,7 @@
>     Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
>     Copyright (c) 2015, Hisilicon Limited. All rights reserved.<BR>
>     Copyright (c) 2015, Linaro Limited. All rights reserved.<BR>
> +  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
>     SPDX-License-Identifier: BSD-2-Clause-Patent
>   
>   **/
> @@ -159,6 +160,7 @@ GetHandleCount (
>     EFI_SMBIOS_TABLE_HEADER  *Record;
>   
>     HandleCount = 0;
> +  SmbiosHandle = SMBIOS_HANDLE_PI_RESERVED;
>   
>     // Iterate through entries to get the number
>     do {


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104915): https://edk2.groups.io/g/devel/message/104915
Mute This Topic: https://groups.io/mt/98922255/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-