An attempt to reduce code duplication a bit.  PlatformBootManagerLibGrub
is an (outdated) copy of PlatformBootManagerLib with some policy
changes.  Add a PCD to enable this policy and add support for that to
PlatformBootManagerLib, which in turn allows to remove
PlatformBootManagerLibGrub.

v2:
 - rebase to latest master
 - add patch to disable NvVarsFileLib (James)
 - pick up acks

Gerd Hoffmann (4):
  OvmfPkg/PlatformBootManagerLib: add PcdBootRestrictToFirmware
  OvmfPkg/NvVarsFileLib: disable in case PcdBootRestrictToFirmware is
    set
  OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub
  OvmfPkg: drop PlatformBootManagerLibGrub

 OvmfPkg/OvmfPkg.dec                           |    3 +
 OvmfPkg/AmdSev/AmdSevX64.dsc                  |   10 +-
 .../Library/NvVarsFileLib/NvVarsFileLib.inf   |    1 +
 .../PlatformBootManagerLib.inf                |    2 +
 .../PlatformBootManagerLibGrub.inf            |   73 -
 .../PlatformBootManagerLibGrub/BdsPlatform.h  |  185 --
 OvmfPkg/Library/NvVarsFileLib/NvVarsFileLib.c |    3 +-
 .../PlatformBootManagerLib/BdsPlatform.c      |   70 +-
 .../PlatformBootManagerLibGrub/BdsPlatform.c  | 1604 -----------------
 .../PlatformBootManagerLibGrub/PlatformData.c |  212 ---
 .../PlatformBootManagerLibGrub/QemuKernel.c   |   55 -
 11 files changed, 82 insertions(+), 2136 deletions(-)
 delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/PlatformBootManagerLibGrub.inf
 delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.h
 delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c
 delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/PlatformData.c
 delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/QemuKernel.c

-- 
2.40.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104097): https://edk2.groups.io/g/devel/message/104097
Mute This Topic: https://groups.io/mt/98699873/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

(cc Liming)

I'd like to merge this series before the stable tag - any objections?

On Fri, 5 May 2023 at 07:28, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> An attempt to reduce code duplication a bit.  PlatformBootManagerLibGrub
> is an (outdated) copy of PlatformBootManagerLib with some policy
> changes.  Add a PCD to enable this policy and add support for that to
> PlatformBootManagerLib, which in turn allows to remove
> PlatformBootManagerLibGrub.
>
> v2:
>  - rebase to latest master
>  - add patch to disable NvVarsFileLib (James)
>  - pick up acks
>
> Gerd Hoffmann (4):
>   OvmfPkg/PlatformBootManagerLib: add PcdBootRestrictToFirmware
>   OvmfPkg/NvVarsFileLib: disable in case PcdBootRestrictToFirmware is
>     set
>   OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub
>   OvmfPkg: drop PlatformBootManagerLibGrub
>
>  OvmfPkg/OvmfPkg.dec                           |    3 +
>  OvmfPkg/AmdSev/AmdSevX64.dsc                  |   10 +-
>  .../Library/NvVarsFileLib/NvVarsFileLib.inf   |    1 +
>  .../PlatformBootManagerLib.inf                |    2 +
>  .../PlatformBootManagerLibGrub.inf            |   73 -
>  .../PlatformBootManagerLibGrub/BdsPlatform.h  |  185 --
>  OvmfPkg/Library/NvVarsFileLib/NvVarsFileLib.c |    3 +-
>  .../PlatformBootManagerLib/BdsPlatform.c      |   70 +-
>  .../PlatformBootManagerLibGrub/BdsPlatform.c  | 1604 -----------------
>  .../PlatformBootManagerLibGrub/PlatformData.c |  212 ---
>  .../PlatformBootManagerLibGrub/QemuKernel.c   |   55 -
>  11 files changed, 82 insertions(+), 2136 deletions(-)
>  delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/PlatformBootManagerLibGrub.inf
>  delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.h
>  delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c
>  delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/PlatformData.c
>  delete mode 100644 OvmfPkg/Library/PlatformBootManagerLibGrub/QemuKernel.c
>
> --
> 2.40.1
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104496): https://edk2.groups.io/g/devel/message/104496
Mute This Topic: https://groups.io/mt/98699873/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Ard:
  Seemly, this patch set passed code review before the soft feature freeze. So, I am OK to merge it for this stable tag. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Ard Biesheuvel <ardb@kernel.org>
> 发送时间: 2023年5月10日 15:13
> 收件人: Gerd Hoffmann <kraxel@redhat.com>; Liming Gao (Byosoft address)
> <gaoliming@byosoft.com.cn>
> 抄送: devel@edk2.groups.io; Jordan Justen <jordan.l.justen@intel.com>;
> Stefan Berger <stefanb@linux.ibm.com>; Tom Lendacky
> <thomas.lendacky@amd.com>; Jiewen Yao <jiewen.yao@intel.com>;
> Anthony Perard <anthony.perard@citrix.com>; Marc-André Lureau
> <marcandre.lureau@redhat.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Erdem Aktas <erdemaktas@google.com>;
> Oliver Steffen <osteffen@redhat.com>; Min Xu <min.m.xu@intel.com>;
> James Bottomley <jejb@linux.ibm.com>; Julien Grall <julien@xen.org>;
> Michael Roth <michael.roth@amd.com>; Pawel Polawski
> <ppolawsk@redhat.com>
> 主题: Re: [PATCH v2 0/4] OvmfPkg: remove PlatformBootManagerLibGrub
> 
> (cc Liming)
> 
> I'd like to merge this series before the stable tag - any objections?
> 
> On Fri, 5 May 2023 at 07:28, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > An attempt to reduce code duplication a bit.
> PlatformBootManagerLibGrub
> > is an (outdated) copy of PlatformBootManagerLib with some policy
> > changes.  Add a PCD to enable this policy and add support for that to
> > PlatformBootManagerLib, which in turn allows to remove
> > PlatformBootManagerLibGrub.
> >
> > v2:
> >  - rebase to latest master
> >  - add patch to disable NvVarsFileLib (James)
> >  - pick up acks
> >
> > Gerd Hoffmann (4):
> >   OvmfPkg/PlatformBootManagerLib: add PcdBootRestrictToFirmware
> >   OvmfPkg/NvVarsFileLib: disable in case PcdBootRestrictToFirmware is
> >     set
> >   OvmfPkg/AmdSev: stop using PlatformBootManagerLibGrub
> >   OvmfPkg: drop PlatformBootManagerLibGrub
> >
> >  OvmfPkg/OvmfPkg.dec                           |    3 +
> >  OvmfPkg/AmdSev/AmdSevX64.dsc                  |   10 +-
> >  .../Library/NvVarsFileLib/NvVarsFileLib.inf   |    1 +
> >  .../PlatformBootManagerLib.inf                |    2 +
> >  .../PlatformBootManagerLibGrub.inf            |   73 -
> >  .../PlatformBootManagerLibGrub/BdsPlatform.h  |  185 --
> >  OvmfPkg/Library/NvVarsFileLib/NvVarsFileLib.c |    3 +-
> >  .../PlatformBootManagerLib/BdsPlatform.c      |   70 +-
> >  .../PlatformBootManagerLibGrub/BdsPlatform.c  | 1604 -----------------
> >  .../PlatformBootManagerLibGrub/PlatformData.c |  212 ---
> >  .../PlatformBootManagerLibGrub/QemuKernel.c   |   55 -
> >  11 files changed, 82 insertions(+), 2136 deletions(-)
> >  delete mode 100644
> OvmfPkg/Library/PlatformBootManagerLibGrub/PlatformBootManagerLibGru
> b.inf
> >  delete mode 100644
> OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.h
> >  delete mode 100644
> OvmfPkg/Library/PlatformBootManagerLibGrub/BdsPlatform.c
> >  delete mode 100644
> OvmfPkg/Library/PlatformBootManagerLibGrub/PlatformData.c
> >  delete mode 100644
> OvmfPkg/Library/PlatformBootManagerLibGrub/QemuKernel.c
> >
> > --
> > 2.40.1
> >




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104503): https://edk2.groups.io/g/devel/message/104503
Mute This Topic: https://groups.io/mt/98801329/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Wed, 10 May 2023 at 09:41, gaoliming via groups.io
<gaoliming=byosoft.com.cn@groups.io> wrote:
>
> Ard:
>   Seemly, this patch set passed code review before the soft feature freeze. So, I am OK to merge it for this stable tag.
>

Thanks

Gerd,

Could you run this through the CI please? I am getting errors.

https://github.com/tianocore/edk2/pull/4382


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104548): https://edk2.groups.io/g/devel/message/104548
Mute This Topic: https://groups.io/mt/98801329/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Wed, 10 May 2023 at 14:33, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Wed, 10 May 2023 at 09:41, gaoliming via groups.io
> <gaoliming=byosoft.com.cn@groups.io> wrote:
> >
> > Ard:
> >   Seemly, this patch set passed code review before the soft feature freeze. So, I am OK to merge it for this stable tag.
> >
>
> Thanks
>
> Gerd,
>
> Could you run this through the CI please? I am getting errors.
>
> https://github.com/tianocore/edk2/pull/4382

Actually, it seems to be a trivial uncrustify fix - i'll just fix that
up locally.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104551): https://edk2.groups.io/g/devel/message/104551
Mute This Topic: https://groups.io/mt/98801329/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Wed, 10 May 2023 at 14:43, Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Wed, 10 May 2023 at 14:33, Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > On Wed, 10 May 2023 at 09:41, gaoliming via groups.io
> > <gaoliming=byosoft.com.cn@groups.io> wrote:
> > >
> > > Ard:
> > >   Seemly, this patch set passed code review before the soft feature freeze. So, I am OK to merge it for this stable tag.
> > >
> >
> > Thanks
> >
> > Gerd,
> >
> > Could you run this through the CI please? I am getting errors.
> >
> > https://github.com/tianocore/edk2/pull/4382
>
> Actually, it seems to be a trivial uncrustify fix - i'll just fix that
> up locally.

Merged. Thanks all.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104571): https://edk2.groups.io/g/devel/message/104571
Mute This Topic: https://groups.io/mt/98801329/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-