[v1] Add IPMI SSIF definitions

[edk2-devel] [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions

Posted by Tinh Nguyen via groups.io 2 years, 9 months ago

This adds more definitions for the IPMI Get System Interface
Capabilities command.

Signed-off-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
---
 MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 31 ++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
index a5835ba08c00..933303b0fa2c 100644
--- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
+++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
@@ -13,6 +13,7 @@
 
   Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.<BR>
   Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
+  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
   SPDX-License-Identifier: BSD-2-Clause-Patent
 **/
 
@@ -1046,6 +1047,36 @@ typedef struct {
 //  Constants and Structure definitions for "Get System Interface Capabilities" command to follow here
 //
 
+#define IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SSIF  0x0
+#define IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_KCS   0x1
+#define IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SMIC  0x2
+
+typedef union {
+  struct {
+    UINT8    InterfaceType : 4;
+    UINT8    Reserved      : 4;
+  } Bits;
+  UINT8    Uint8;
+} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST;
+
+typedef union {
+  struct {
+    UINT8    Version            : 3;
+    UINT8    PecSupport         : 1;
+    UINT8    Reserved           : 2;
+    UINT8    TransactionSupport : 2;
+  } Bits;
+  UINT8    Uint8;
+} IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES;
+
+typedef struct {
+  UINT8                                      CompletionCode;
+  UINT8                                      Reserved;
+  IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES    InterfaceCap;
+  UINT8                                      InputMsgSize;
+  UINT8                                      OutputMsgSize;
+} IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE;
+
 //
 //  Definitions for Get System Interface Capabilities command SSIF transaction support
 //
-- 
2.40.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103743): https://edk2.groups.io/g/devel/message/103743
Mute This Topic: https://groups.io/mt/98552186/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions

Posted by Chang, Abner via groups.io 2 years, 9 months ago

[AMD Official Use Only - General]

Reviewed-by: Abner Chang <Abner.Chang@amd.com>

> -----Original Message-----
> From: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> Sent: Friday, April 28, 2023 12:00 PM
> To: devel@edk2.groups.io
> Cc: patches@amperecomputing.com; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; Chang, Abner
> <Abner.Chang@amd.com>; Tinh Nguyen
> <tinhnguyen@os.amperecomputing.com>
> Subject: [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more
> definitions
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> This adds more definitions for the IPMI Get System Interface Capabilities
> command.
> 
> Signed-off-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> ---
>  MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 31
> ++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> index a5835ba08c00..933303b0fa2c 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> @@ -13,6 +13,7 @@
> 
>    Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.<BR>
>    Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> +  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
>    SPDX-License-Identifier: BSD-2-Clause-Patent  **/
> 
> @@ -1046,6 +1047,36 @@ typedef struct {
>  //  Constants and Structure definitions for "Get System Interface
> Capabilities" command to follow here  //
> 
> +#define
> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SSIF  0x0
> +#define
> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_KCS   0x1
> +#define
> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SMIC  0x2
> +
> +typedef union {
> +  struct {
> +    UINT8    InterfaceType : 4;
> +    UINT8    Reserved      : 4;
> +  } Bits;
> +  UINT8    Uint8;
> +} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST;
> +
> +typedef union {
> +  struct {
> +    UINT8    Version            : 3;
> +    UINT8    PecSupport         : 1;
> +    UINT8    Reserved           : 2;
> +    UINT8    TransactionSupport : 2;
> +  } Bits;
> +  UINT8    Uint8;
> +} IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES;
> +
> +typedef struct {
> +  UINT8                                      CompletionCode;
> +  UINT8                                      Reserved;
> +  IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES    InterfaceCap;
> +  UINT8                                      InputMsgSize;
> +  UINT8                                      OutputMsgSize;
> +} IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE;
> +
>  //
>  //  Definitions for Get System Interface Capabilities command SSIF
> transaction support  //
> --
> 2.40.0


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103788): https://edk2.groups.io/g/devel/message/103788
Mute This Topic: https://groups.io/mt/98552186/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions

Posted by gaoliming via groups.io 2 years, 9 months ago

Tinh:
  Please use the specific word in the subject. For example, add Capabilities
definitions.

> -----邮件原件-----
> 发件人: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> 发送时间: 2023年4月28日 12:00
> 收件人: devel@edk2.groups.io
> 抄送: patches@amperecomputing.com; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com; abner.chang@amd.com;
> Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> 主题: [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more
> definitions
> 
> This adds more definitions for the IPMI Get System Interface
> Capabilities command.
> 
> Signed-off-by: Tinh Nguyen <tinhnguyen@os.amperecomputing.com>
> ---
>  MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 31
> ++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> index a5835ba08c00..933303b0fa2c 100644
> --- a/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnApp.h
> @@ -13,6 +13,7 @@
> 
>    Copyright (c) 1999 - 2018, Intel Corporation. All rights reserved.<BR>
>    Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
reserved.<BR>
> +  Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
>    SPDX-License-Identifier: BSD-2-Clause-Patent
>  **/
> 
> @@ -1046,6 +1047,36 @@ typedef struct {
>  //  Constants and Structure definitions for "Get System Interface
> Capabilities" command to follow here
>  //
> 
> +#define
> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SSIF  0x0
> +#define
> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_KCS   0x1
> +#define
> IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_INTERFACE_TYPE_SMIC  0x2
> +

KCS and SMIC type are added. Can you also add KCS and SMIC Capabilities
definitions? 

Thanks
Liming
> +typedef union {
> +  struct {
> +    UINT8    InterfaceType : 4;
> +    UINT8    Reserved      : 4;
> +  } Bits;
> +  UINT8    Uint8;
> +} IPMI_GET_SYSTEM_INTERFACE_CAPABILITIES_REQUEST;
> +
> +typedef union {
> +  struct {
> +    UINT8    Version            : 3;
> +    UINT8    PecSupport         : 1;
> +    UINT8    Reserved           : 2;
> +    UINT8    TransactionSupport : 2;
> +  } Bits;
> +  UINT8    Uint8;
> +} IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES;
> +
> +typedef struct {
> +  UINT8                                      CompletionCode;
> +  UINT8                                      Reserved;
> +  IPMI_SYSTEM_INTERFACE_SSIF_CAPABILITIES    InterfaceCap;
> +  UINT8                                      InputMsgSize;
> +  UINT8                                      OutputMsgSize;
> +} IPMI_GET_SYSTEM_INTERFACE_SSIF_CAPABILITIES_RESPONSE;
> +
>  //
>  //  Definitions for Get System Interface Capabilities command SSIF
> transaction support
>  //
> --
> 2.40.0





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103752): https://edk2.groups.io/g/devel/message/103752
Mute This Topic: https://groups.io/mt/98552977/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 1/2] MdePkg/IndustryStandard: Adds definitions for IPMI SSIF
[edk2-devel] [PATCH 2/2] MdePkg/IndustryStandard/IpmiNetFnApp.h: Add more definitions