ArmVirtPkg: can't find gUefiOvmfPkgTokenSpaceGuid

[edk2-devel] [PATCH v2] ArmVirtPkg: can't find gUefiOvmfPkgTokenSpaceGuid

Posted by Jianyong Wu 1 year ago

commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
missing in CloudHvHasAcpiDtDxe.inf which leads to
gUefiOvmfPkgTokenSpaceGuid found nowhere when build.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
---
 ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
index 7cad40e11f..6ff80b24d0 100644
--- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
+++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
@@ -23,6 +23,7 @@
   EmbeddedPkg/EmbeddedPkg.dec
   MdeModulePkg/MdeModulePkg.dec
   MdePkg/MdePkg.dec
+  OvmfPkg/OvmfPkg.dec
 
 [LibraryClasses]
   BaseLib
-- 
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102020): https://edk2.groups.io/g/devel/message/102020
Mute This Topic: https://groups.io/mt/97901263/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] ArmVirtPkg: can't find gUefiOvmfPkgTokenSpaceGuid

Posted by Sami Mujawar 1 year ago

Hi Ard,

This patch fixes a build break for the CloudHv firmware.
Can you let me know if I can merge this patch, please?

Regards,

Sami Mujawar

On 28/03/2023, 10:11, "Jianyong Wu" <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>> wrote:


commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
missing in CloudHvHasAcpiDtDxe.inf which leads to
gUefiOvmfPkgTokenSpaceGuid found nowhere when build.


Reviewed-by: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>>
Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>
---
ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
1 file changed, 1 insertion(+)


diff --git a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
index 7cad40e11f..6ff80b24d0 100644
--- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
+++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
@@ -23,6 +23,7 @@
EmbeddedPkg/EmbeddedPkg.dec
MdeModulePkg/MdeModulePkg.dec
MdePkg/MdePkg.dec
+ OvmfPkg/OvmfPkg.dec


[LibraryClasses]
BaseLib
--
2.17.1





IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102022): https://edk2.groups.io/g/devel/message/102022
Mute This Topic: https://groups.io/mt/97901263/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2] ArmVirtPkg: can't find gUefiOvmfPkgTokenSpaceGuid

Posted by Ard Biesheuvel 1 year ago

On Tue, 28 Mar 2023 at 12:11, Sami Mujawar <sami.mujawar@arm.com> wrote:
>
> Hi Ard,
>
> This patch fixes a build break for the CloudHv firmware.
> Can you let me know if I can merge this patch, please?
>

Yes, please go ahead

Reviewed-by: Ard Biesheuvel <ardb@kernel.org>

>
> On 28/03/2023, 10:11, "Jianyong Wu" <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>> wrote:
>
>
> commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
> missing in CloudHvHasAcpiDtDxe.inf which leads to
> gUefiOvmfPkgTokenSpaceGuid found nowhere when build.
>
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>>
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com <mailto:jianyong.wu@arm.com>>
> ---
> ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
> 1 file changed, 1 insertion(+)
>
>
> diff --git a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> index 7cad40e11f..6ff80b24d0 100644
> --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> @@ -23,6 +23,7 @@
> EmbeddedPkg/EmbeddedPkg.dec
> MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> + OvmfPkg/OvmfPkg.dec
>
>
> [LibraryClasses]
> BaseLib
> --
> 2.17.1
>
>
>
>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
>
>
> 
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102030): https://edk2.groups.io/g/devel/message/102030
Mute This Topic: https://groups.io/mt/97901263/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-