modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination
in Acpi64.h.
Signed-off-by: Dun Tan <dun.tan@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
MdePkg/Include/IndustryStandard/Acpi64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h b/MdePkg/Include/IndustryStandard/Acpi64.h
index fe5ebfac2b..bfd022b6b6 100644
--- a/MdePkg/Include/IndustryStandard/Acpi64.h
+++ b/MdePkg/Include/IndustryStandard/Acpi64.h
@@ -607,7 +607,7 @@ typedef struct {
typedef struct {
UINT16 Command;
UINT16 Reserved;
- UINT32 AcpiId;
+ UINT32 ApicId;
UINT64 WakeupVector;
UINT8 ReservedForOs[2032];
UINT8 ReservedForFirmware[2048];
--
2.31.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100903): https://edk2.groups.io/g/devel/message/100903
Mute This Topic: https://groups.io/mt/97489640/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Dun: Is there any code impact with this change? Thanks Liming > -----邮件原件----- > 发件人: Dun Tan <dun.tan@intel.com> > 发送时间: 2023年3月9日 11:40 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com> > 主题: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in > MpWakeupStructure > > modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination > in Acpi64.h. > > Signed-off-by: Dun Tan <dun.tan@intel.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com> > --- > MdePkg/Include/IndustryStandard/Acpi64.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h > b/MdePkg/Include/IndustryStandard/Acpi64.h > index fe5ebfac2b..bfd022b6b6 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > @@ -607,7 +607,7 @@ typedef struct { > typedef struct { > UINT16 Command; > UINT16 Reserved; > - UINT32 AcpiId; > + UINT32 ApicId; > UINT64 WakeupVector; > UINT8 ReservedForOs[2032]; > UINT8 ReservedForFirmware[2048]; > -- > 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100970): https://edk2.groups.io/g/devel/message/100970 Mute This Topic: https://groups.io/mt/97511706/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Hi Liming, I've checked edk2 and edk2-platforms repo. This code change doesn't impacted any code. The MultiprocessorWakeupMailbox structure has not been used yet. Thanks, Dun -----Original Message----- From: gaoliming <gaoliming@byosoft.com.cn> Sent: Friday, March 10, 2023 10:16 AM To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com> Subject: 回复: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure Dun: Is there any code impact with this change? Thanks Liming > -----邮件原件----- > 发件人: Dun Tan <dun.tan@intel.com> > 发送时间: 2023年3月9日 11:40 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com> > 主题: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in > MpWakeupStructure > > modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination > in Acpi64.h. > > Signed-off-by: Dun Tan <dun.tan@intel.com> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com> > --- > MdePkg/Include/IndustryStandard/Acpi64.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h > b/MdePkg/Include/IndustryStandard/Acpi64.h > index fe5ebfac2b..bfd022b6b6 100644 > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > @@ -607,7 +607,7 @@ typedef struct { > typedef struct { > UINT16 Command; > UINT16 Reserved; > - UINT32 AcpiId; > + UINT32 ApicId; > UINT64 WakeupVector; > UINT8 ReservedForOs[2032]; > UINT8 ReservedForFirmware[2048]; > -- > 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100985): https://edk2.groups.io/g/devel/message/100985 Mute This Topic: https://groups.io/mt/97514479/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Dun: OK. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> Can you create PR for this patch set? I will merge this PR. Thanks Liming > -----邮件原件----- > 发件人: Tan, Dun <dun.tan@intel.com> > 发送时间: 2023年3月10日 14:17 > 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang > <zhiguang.liu@intel.com> > 主题: RE: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in > MpWakeupStructure > > Hi Liming, > > I've checked edk2 and edk2-platforms repo. This code change doesn't > impacted any code. > The MultiprocessorWakeupMailbox structure has not been used yet. > > Thanks, > Dun > > -----Original Message----- > From: gaoliming <gaoliming@byosoft.com.cn> > Sent: Friday, March 10, 2023 10:16 AM > To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang > <zhiguang.liu@intel.com> > Subject: 回复: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' > in MpWakeupStructure > > Dun: > Is there any code impact with this change? > > Thanks > Liming > > -----邮件原件----- > > 发件人: Dun Tan <dun.tan@intel.com> > > 发送时间: 2023年3月9日 11:40 > > 收件人: devel@edk2.groups.io > > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao > > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com> > > 主题: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in > > MpWakeupStructure > > > > modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination > > in Acpi64.h. > > > > Signed-off-by: Dun Tan <dun.tan@intel.com> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com> > > --- > > MdePkg/Include/IndustryStandard/Acpi64.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h > > b/MdePkg/Include/IndustryStandard/Acpi64.h > > index fe5ebfac2b..bfd022b6b6 100644 > > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > > @@ -607,7 +607,7 @@ typedef struct { > > typedef struct { > > UINT16 Command; > > UINT16 Reserved; > > - UINT32 AcpiId; > > + UINT32 ApicId; > > UINT64 WakeupVector; > > UINT8 ReservedForOs[2032]; > > UINT8 ReservedForFirmware[2048]; > > -- > > 2.31.1.windows.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101603): https://edk2.groups.io/g/devel/message/101603 Mute This Topic: https://groups.io/mt/97792866/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thanks Liming. Sorry for missing the email. Here is the PR for the two patches: https://github.com/tianocore/edk2/pull/4169 Thanks, Dun -----Original Message----- From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of gaoliming via groups.io Sent: Thursday, March 23, 2023 9:17 AM To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com> Subject: [edk2-devel] 回复: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure Dun: OK. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> Can you create PR for this patch set? I will merge this PR. Thanks Liming > -----邮件原件----- > 发件人: Tan, Dun <dun.tan@intel.com> > 发送时间: 2023年3月10日 14:17 > 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io > 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang > <zhiguang.liu@intel.com> > 主题: RE: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' > in MpWakeupStructure > > Hi Liming, > > I've checked edk2 and edk2-platforms repo. This code change doesn't > impacted any code. > The MultiprocessorWakeupMailbox structure has not been used yet. > > Thanks, > Dun > > -----Original Message----- > From: gaoliming <gaoliming@byosoft.com.cn> > Sent: Friday, March 10, 2023 10:16 AM > To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang > <zhiguang.liu@intel.com> > Subject: 回复: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' > in MpWakeupStructure > > Dun: > Is there any code impact with this change? > > Thanks > Liming > > -----邮件原件----- > > 发件人: Dun Tan <dun.tan@intel.com> > > 发送时间: 2023年3月9日 11:40 > > 收件人: devel@edk2.groups.io > > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao > > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com> > > 主题: [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in > > MpWakeupStructure > > > > modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure > > defination in Acpi64.h. > > > > Signed-off-by: Dun Tan <dun.tan@intel.com> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Reviewed-by: Zhiguang Liu <zhiguang.liu@intel.com> > > --- > > MdePkg/Include/IndustryStandard/Acpi64.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h > > b/MdePkg/Include/IndustryStandard/Acpi64.h > > index fe5ebfac2b..bfd022b6b6 100644 > > --- a/MdePkg/Include/IndustryStandard/Acpi64.h > > +++ b/MdePkg/Include/IndustryStandard/Acpi64.h > > @@ -607,7 +607,7 @@ typedef struct { typedef struct { > > UINT16 Command; > > UINT16 Reserved; > > - UINT32 AcpiId; > > + UINT32 ApicId; > > UINT64 WakeupVector; > > UINT8 ReservedForOs[2032]; > > UINT8 ReservedForFirmware[2048]; > > -- > > 2.31.1.windows.1 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101764): https://edk2.groups.io/g/devel/message/101764 Mute This Topic: https://groups.io/mt/97792866/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.