[edk2-devel] [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response

Mike Maslenkin posted 3 patches 1 year, 1 month ago
Failed in applying to current master (apply log)
[edk2-devel] [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response
Posted by Mike Maslenkin 1 year, 1 month ago
This patchset fixes "Get Self Test Results" IPMI command response processing.
The first patch just makes a fix.
The second patch removes a transfer buffer from IPMI instance data as a
preparation of further improvement. It's not clear why a buffer of
a maximum size used for all commands. For the command mentioned above
response contains only 3 bytes.
The third patch drops raw byte array usage while parsing command
response because structure for this response is already defined in edk2.

Checked compilation for the Intel’s Aowanda platform using GCC5
toolchain.

v2:
  patch 1:
    added R-b
  patch 2:
    added changes to SmmGenericIpmi.c
  patch 3:
    renamed pSelfTestResult to SelfTestResult,
    fixed initialization of SelfTestResult->CompletionCode before
    IpmiSendCommand call.
   
Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Isaac Oram <isaac.w.oram@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100881): https://edk2.groups.io/g/devel/message/100881
Mute This Topic: https://groups.io/mt/97485240/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response
Posted by Isaac Oram 1 year, 1 month ago
Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100893): https://edk2.groups.io/g/devel/message/100893
Mute This Topic: https://groups.io/mt/97485240/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-


Re: [edk2-devel] [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response
Posted by Isaac Oram 1 year, 1 month ago
Pushed as 90ea518edf..95b58f71d9

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Isaac Oram
Sent: Wednesday, March 8, 2023 6:43 PM
To: Mike Maslenkin <mike.maslenkin@gmail.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response

Series Reviewed-by: Isaac Oram <isaac.w.oram@intel.com<mailto:isaac.w.oram@intel.com>>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100895): https://edk2.groups.io/g/devel/message/100895
Mute This Topic: https://groups.io/mt/97485240/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-