[edk2-devel] [edk2-libc Patch 2/2] Incorporated review comments

Ajay Kadapathri posted 2 patches 2 years, 11 months ago
There is a newer version of this series
[edk2-devel] [edk2-libc Patch 2/2] Incorporated review comments
Posted by Ajay Kadapathri 2 years, 11 months ago
Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Jayaprakash N <n.jayaprakash@intel.com>
Signed-off-by: Ajay Kadapathri <ajay.kadapathri@intel.com>
---
 .../PyMod-3.6.8/Modules/edk2module.c          | 26 +++++++++----------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
index a0e6273..4c400b9 100644
--- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
+++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
@@ -4257,26 +4257,24 @@ MiscRT_SetVariable(PyObject *self, PyObject *args)
 }
 
 
+/**
+  This function prints a GUID to a buffer
+  
+  @param guid                    Pointer to a GUID
+  
+  @param str_buffer              Pointer to a str buffer
+  
+
+  @retval EFI_SUCCESS            GUID was printed
+  
+  @retval EFI_INVALID_PARAMETER  GUID was NULL
 
+**/
 EFI_STATUS
 GuidToStr (
   IN EFI_GUID  *guid,
   IN OUT UINT8 *str_buffer
   )
-/*++
-
-Routine Description:
-  This function prints a GUID to a buffer
-
-Arguments:
-  guid       - Pointer to a GUID
-  str_buffer - Pointer to a str buffer
-
-Returns:
-  EFI_SUCCESS            GUID was printed
-  EFI_INVALID_PARAMETER  GUID was NULL
-  
---*/
 {
   if (guid == NULL) {
     return EFI_INVALID_PARAMETER;
-- 
2.39.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100777): https://edk2.groups.io/g/devel/message/100777
Mute This Topic: https://groups.io/mt/97443897/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-libc Patch 2/2] Incorporated review comments
Posted by Rebecca Cran 2 years, 11 months ago
Sorry, could you send out a v2 patch series with the fixes included please?


Thanks.

Rebecca Cran


On 3/6/23 10:11 PM, Ajay Kadapathri wrote:
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Jayaprakash N <n.jayaprakash@intel.com>
> Signed-off-by: Ajay Kadapathri <ajay.kadapathri@intel.com>
> ---
>   .../PyMod-3.6.8/Modules/edk2module.c          | 26 +++++++++----------
>   1 file changed, 12 insertions(+), 14 deletions(-)
>
> diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
> index a0e6273..4c400b9 100644
> --- a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
> +++ b/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2module.c
> @@ -4257,26 +4257,24 @@ MiscRT_SetVariable(PyObject *self, PyObject *args)
>   }
>   
>   
> +/**
> +  This function prints a GUID to a buffer
> +
> +  @param guid                    Pointer to a GUID
> +
> +  @param str_buffer              Pointer to a str buffer
> +
> +
> +  @retval EFI_SUCCESS            GUID was printed
> +
> +  @retval EFI_INVALID_PARAMETER  GUID was NULL
>   
> +**/
>   EFI_STATUS
>   GuidToStr (
>     IN EFI_GUID  *guid,
>     IN OUT UINT8 *str_buffer
>     )
> -/*++
> -
> -Routine Description:
> -  This function prints a GUID to a buffer
> -
> -Arguments:
> -  guid       - Pointer to a GUID
> -  str_buffer - Pointer to a str buffer
> -
> -Returns:
> -  EFI_SUCCESS            GUID was printed
> -  EFI_INVALID_PARAMETER  GUID was NULL
> -
> ---*/
>   {
>     if (guid == NULL) {
>       return EFI_INVALID_PARAMETER;


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100805): https://edk2.groups.io/g/devel/message/100805
Mute This Topic: https://groups.io/mt/97443897/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-