[v3] Ext4Pkg: Code correctness and security improvements

[edk2-devel] [edk2-platforms][PATCH v3 00/11] Ext4Pkg: Code correctness and security improvements

Savva Mitrofanov posted 11 patches 1 year, 3 months ago

Diff against v1 v2 v2 v3 v4
Download series mbox

Failed in applying to current master (apply log)

There is a newer version of this series

Features/Ext4Pkg/Ext4Pkg.dsc          |  2 +-
Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h   | 13 ++++-
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    | 39 +++++++++++++++
Features/Ext4Pkg/Ext4Dxe/BlockGroup.c |  5 ++
Features/Ext4Pkg/Ext4Dxe/Directory.c  | 52 ++++++++++++++------
Features/Ext4Pkg/Ext4Dxe/DiskUtil.c   |  8 +--
Features/Ext4Pkg/Ext4Dxe/File.c       | 23 ++++++---
Features/Ext4Pkg/Ext4Dxe/Inode.c      |  6 +--
Features/Ext4Pkg/Ext4Dxe/Superblock.c | 16 ++++--
Features/Ext4Pkg/Ext4Dxe/Symlink.c    | 12 ++---
10 files changed, 134 insertions(+), 42 deletions(-)

Expand all Fold all

[edk2-devel] [edk2-platforms][PATCH v3 00/11] Ext4Pkg: Code correctness and security improvements

Posted by Savva Mitrofanov 1 year, 3 months ago

Hi all,

In v3 I rebased patches according upstream and removed already applied patches.
Also in this revision I corrected 'Fixes' tag formatting, added corrections to
Ext4GetUcs2DirentName to filter out directory entry names containing \0 as invalid
and added a fix for building using MSVC.

This patchset fixes several code problems found by fuzzing Ext4Dxe like
buffer and integer overflows, memory leaks, logic bugs and so on.

REF: https://github.com/savvamitrofanov/edk2-platforms/tree/master

Cc: Marvin Häuser <mhaeuser@posteo.de>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>

Savva Mitrofanov (11):
  Ext4Pkg: Fix memory leak in Ext4RetrieveDirent
  Ext4Pkg: Fix incorrect checksum metadata feature check
  Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group
  Ext4Pkg: Add inode number validity check
  Ext4Pkg: Fix shift out of bounds in Ext4OpenSuperblock
  Ext4Pkg: Corrects integer overflow check logic in DiskUtil
  Ext4Pkg: Check that source file is directory in Ext4OpenInternal
  Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName
  Ext4Pkg: Add missing exit Status in Ext4OpenDirent
  Ext4Pkg: Fixes build on MSVC
  Ext4Pkg: Filter out directory entry names containing \0 as invalid

 Features/Ext4Pkg/Ext4Pkg.dsc          |  2 +-
 Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h   | 13 ++++-
 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    | 39 +++++++++++++++
 Features/Ext4Pkg/Ext4Dxe/BlockGroup.c |  5 ++
 Features/Ext4Pkg/Ext4Dxe/Directory.c  | 52 ++++++++++++++------
 Features/Ext4Pkg/Ext4Dxe/DiskUtil.c   |  8 +--
 Features/Ext4Pkg/Ext4Dxe/File.c       | 23 ++++++---
 Features/Ext4Pkg/Ext4Dxe/Inode.c      |  6 +--
 Features/Ext4Pkg/Ext4Dxe/Superblock.c | 16 ++++--
 Features/Ext4Pkg/Ext4Dxe/Symlink.c    | 12 ++---
 10 files changed, 134 insertions(+), 42 deletions(-)

-- 
2.39.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99136): https://edk2.groups.io/g/devel/message/99136
Mute This Topic: https://groups.io/mt/96562689/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-