From: Pierre Gondois <pierre.gondois@arm.com>

Building the following images with the SECURE_STORAGE_ENABLE flag
fails due to VariableFlashInfoLib being missing:
 - Platform/Hisilicon/D03/D03.dsc
 - Platform/Hisilicon/D06/D06.dsc
 - Platform/Hisilicon/HiKey960/HiKey960.dsc
 - Platform/Hisilicon/HiKey/HiKey.dsc

Add the missing library.

Reported-by: Guillaume Gardet <Guillaume.Gardet@arm.com>
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
 Silicon/Hisilicon/Hisilicon.dsc.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Hisilicon/Hisilicon.dsc.inc b/Silicon/Hisilicon/Hisilicon.dsc.inc
index b12efd7f031b..1f70460a2baf 100644
--- a/Silicon/Hisilicon/Hisilicon.dsc.inc
+++ b/Silicon/Hisilicon/Hisilicon.dsc.inc
@@ -37,6 +37,7 @@ [LibraryClasses.common]
   UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf
   HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
   UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
+  VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
 
   UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
   OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibNull/OemHookStatusCodeLibNull.inf
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99012): https://edk2.groups.io/g/devel/message/99012
Mute This Topic: https://groups.io/mt/96518047/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Pierre,

Thank you for this patch.

On Wed, Jan 25, 2023 at 02:28 AM, PierreGondois wrote:

> 
> - Platform/Hisilicon/D03/D03.dsc
> - Platform/Hisilicon/D06/D06.dsc

There is also Platform/Hisilicon/D05/D05.dsc that probably depends on this fix. However, I find the builds for all the D0x platforms fail. Apparently, the issue is the file Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf could not be found.
Have you seen this issue or there is something wrong in my setup?

Other than that I could test this patch indeed fixes the build issue for HiKey960 and HiKey platform.
Since this fix is required for the D0x platforms as well.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99074): https://edk2.groups.io/g/devel/message/99074
Mute This Topic: https://groups.io/mt/96518047/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

I see the note in the cover letter. I am getting the same issue.
Looks like there is more work needed to fix the D0x platforms.
I think this patch should progress regardless, but that is a decision for the maintainers.

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99075): https://edk2.groups.io/g/devel/message/99075
Mute This Topic: https://groups.io/mt/96518047/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-