From: Pierre Gondois <pierre.gondois@arm.com>

The '-march=armv8-a+nofp' flag used for PlatformStandaloneMm.dsc
was removed in the previous patch. The same flag was probably copied
from this first configuration in:
commit bd5071cfbde01 ("StMMRpmb: Add support for building StandaloneMm
image for OP-TEE")

As the flag is removed for PlatformStandaloneMm.dsc in the previous
patch, also remove the flag for PlatformStandaloneMmRpmb.dsc.

CC: Ilias Apalodimas <ilias.apalodimas@linaro.org>
CC: Omkar Anand Kulkarni <omkar.kulkarni@arm.com>
CC: Pranav Madhu <pranav.madhu@arm.com>
CC: Sayanta Pattanayak <Sayanta.Pattanayak@arm.com>
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
 .../PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
index 653029c52fdb..611d76e62117 100644
--- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
+++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
@@ -165,7 +165,7 @@ [Components.common]
 #
 ###################################################################################################
 [BuildOptions.AARCH64]
-GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp
+GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
 GCC:*_*_*_CC_FLAGS = -mstrict-align
 
 [BuildOptions.ARM]
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99010): https://edk2.groups.io/g/devel/message/99010
Mute This Topic: https://groups.io/mt/96518044/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Hi Pierre,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99128): https://edk2.groups.io/g/devel/message/99128
Mute This Topic: https://groups.io/mt/96518044/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On 25/01/2023 10:27, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
> 
> The '-march=armv8-a+nofp' flag used for PlatformStandaloneMm.dsc
> was removed in the previous patch. The same flag was probably copied
> from this first configuration in:
> commit bd5071cfbde01 ("StMMRpmb: Add support for building StandaloneMm
> image for OP-TEE")
> 
> As the flag is removed for PlatformStandaloneMm.dsc in the previous
> patch, also remove the flag for PlatformStandaloneMmRpmb.dsc.
> 
> CC: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> CC: Omkar Anand Kulkarni <omkar.kulkarni@arm.com>
> CC: Pranav Madhu <pranav.madhu@arm.com>
> CC: Sayanta Pattanayak <Sayanta.Pattanayak@arm.com>
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
>   .../PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc        | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> index 653029c52fdb..611d76e62117 100644
> --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> @@ -165,7 +165,7 @@ [Components.common]
>   #
>   ###################################################################################################
>   [BuildOptions.AARCH64]
> -GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp
> +GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
>   GCC:*_*_*_CC_FLAGS = -mstrict-align
>   
>   [BuildOptions.ARM]


Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99067): https://edk2.groups.io/g/devel/message/99067
Mute This Topic: https://groups.io/mt/96518044/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

On Thu, 26 Jan 2023 at 11:35, Thomas Abraham <thomas.abraham@arm.com> wrote:
>
>
>
> On 25/01/2023 10:27, Pierre.Gondois@arm.com wrote:
> > From: Pierre Gondois <pierre.gondois@arm.com>
> >
> > The '-march=armv8-a+nofp' flag used for PlatformStandaloneMm.dsc
> > was removed in the previous patch. The same flag was probably copied
> > from this first configuration in:
> > commit bd5071cfbde01 ("StMMRpmb: Add support for building StandaloneMm
> > image for OP-TEE")
> >
> > As the flag is removed for PlatformStandaloneMm.dsc in the previous
> > patch, also remove the flag for PlatformStandaloneMmRpmb.dsc.
> >
> > CC: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> > CC: Omkar Anand Kulkarni <omkar.kulkarni@arm.com>
> > CC: Pranav Madhu <pranav.madhu@arm.com>
> > CC: Sayanta Pattanayak <Sayanta.Pattanayak@arm.com>
> > Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> > ---
> >   .../PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc        | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> > index 653029c52fdb..611d76e62117 100644
> > --- a/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> > +++ b/Platform/StandaloneMm/PlatformStandaloneMmPkg/PlatformStandaloneMmRpmb.dsc
> > @@ -165,7 +165,7 @@ [Components.common]
> >   #
> >   ###################################################################################################
> >   [BuildOptions.AARCH64]
> > -GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000 -march=armv8-a+nofp
> > +GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
> >   GCC:*_*_*_CC_FLAGS = -mstrict-align
> >
> >   [BuildOptions.ARM]
>
>
> Reviewed-by: Thomas Abraham <thomas.abraham@arm.com>

Thanks for the fix,

Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#99069): https://edk2.groups.io/g/devel/message/99069
Mute This Topic: https://groups.io/mt/96518044/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-