EmbeddedPkg/Include/Library/PrePiLib.h | 22 +++++++++++++- EmbeddedPkg/Library/PrePiLib/FwVol.c | 33 ++++++++++++++++++--- EmbeddedPkg/Library/PrePiLib/PrePiLib.c | 2 +- OvmfPkg/Library/PeilessStartupLib/DxeLoad.c | 4 +-- 4 files changed, 53 insertions(+), 8 deletions(-)
Commit c673216 introduces FFS_CHECK_SECTION_HOOK and add it as the second input parameter in FfsFindSectionData. This change breaks the build of ArmVirtPkg. To fix this issue, the new version of FfsFindSectionData is renamed as FfsFindSectionDataWithHook. Then the original FfsFindSectionData is added back. After FfsFindSectionData is renamed as FfsFindSectionDataWithHook, PeilessStartupLib in OvmfPkg is updated as well. Cc: Leif Lindholm <quic_llindhol@quicinc.com> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> Cc: Abner Chang <abner.chang@amd.com> Cc: Daniel Schaefer <git@danielschaefer.me> Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Erdem Aktas <erdemaktas@google.com> Cc: James Bottomley <jejb@linux.ibm.com> Cc: Jiewen Yao <jiewen.yao@intel.com> Cc: Tom Lendacky <thomas.lendacky@amd.com> Signed-off-by: Min Xu <min.m.xu@intel.com> Min M Xu (2): EmbeddedPkg: Rename FfsFindSectionData as FfsFindSectionDataWithHook EmbeddedPkg: Add back FfsFindSectionData EmbeddedPkg/Include/Library/PrePiLib.h | 22 +++++++++++++- EmbeddedPkg/Library/PrePiLib/FwVol.c | 33 ++++++++++++++++++--- EmbeddedPkg/Library/PrePiLib/PrePiLib.c | 2 +- OvmfPkg/Library/PeilessStartupLib/DxeLoad.c | 4 +-- 4 files changed, 53 insertions(+), 8 deletions(-) -- 2.29.2.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98841): https://edk2.groups.io/g/devel/message/98841 Mute This Topic: https://groups.io/mt/96369498/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Thu, Jan 19, 2023 at 09:51:06AM +0800, Min Xu wrote: > Commit c673216 introduces FFS_CHECK_SECTION_HOOK and add it as the > second input parameter in FfsFindSectionData. This change breaks the build > of ArmVirtPkg. To fix this issue, the new version of FfsFindSectionData > is renamed as FfsFindSectionDataWithHook. Then the original > FfsFindSectionData is added back. Acked-by: Gerd Hoffmann <kraxel@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98871): https://edk2.groups.io/g/devel/message/98871 Mute This Topic: https://groups.io/mt/96369498/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Thu, 19 Jan 2023 at 08:55, Gerd Hoffmann <kraxel@redhat.com> wrote: > > On Thu, Jan 19, 2023 at 09:51:06AM +0800, Min Xu wrote: > > Commit c673216 introduces FFS_CHECK_SECTION_HOOK and add it as the > > second input parameter in FfsFindSectionData. This change breaks the build > > of ArmVirtPkg. To fix this issue, the new version of FfsFindSectionData > > is renamed as FfsFindSectionDataWithHook. Then the original > > FfsFindSectionData is added back. > > Acked-by: Gerd Hoffmann <kraxel@redhat.com> > Thanks all I will go and push this. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98872): https://edk2.groups.io/g/devel/message/98872 Mute This Topic: https://groups.io/mt/96369498/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
Thanks for the quick update. Reviewed-by: Jiewen Yao <Jiewen.yao@intel.com> > -----Original Message----- > From: Xu, Min M <min.m.xu@intel.com> > Sent: Thursday, January 19, 2023 9:51 AM > To: devel@edk2.groups.io > Cc: Xu, Min M <min.m.xu@intel.com>; Leif Lindholm > <quic_llindhol@quicinc.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; > Abner Chang <abner.chang@amd.com>; Daniel Schaefer > <git@danielschaefer.me>; Gerd Hoffmann <kraxel@redhat.com>; Aktas, > Erdem <erdemaktas@google.com>; James Bottomley <jejb@linux.ibm.com>; > Yao, Jiewen <jiewen.yao@intel.com>; Tom Lendacky > <thomas.lendacky@amd.com> > Subject: [PATCH V1 0/2] Add back FfsFindSectionData in EmbeddedPkg > > Commit c673216 introduces FFS_CHECK_SECTION_HOOK and add it as the > second input parameter in FfsFindSectionData. This change breaks the build > of ArmVirtPkg. To fix this issue, the new version of FfsFindSectionData > is renamed as FfsFindSectionDataWithHook. Then the original > FfsFindSectionData is added back. > > After FfsFindSectionData is renamed as FfsFindSectionDataWithHook, > PeilessStartupLib in OvmfPkg is updated as well. > > Cc: Leif Lindholm <quic_llindhol@quicinc.com> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org> > Cc: Abner Chang <abner.chang@amd.com> > Cc: Daniel Schaefer <git@danielschaefer.me> > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Erdem Aktas <erdemaktas@google.com> > Cc: James Bottomley <jejb@linux.ibm.com> > Cc: Jiewen Yao <jiewen.yao@intel.com> > Cc: Tom Lendacky <thomas.lendacky@amd.com> > Signed-off-by: Min Xu <min.m.xu@intel.com> > > Min M Xu (2): > EmbeddedPkg: Rename FfsFindSectionData as FfsFindSectionDataWithHook > EmbeddedPkg: Add back FfsFindSectionData > > EmbeddedPkg/Include/Library/PrePiLib.h | 22 +++++++++++++- > EmbeddedPkg/Library/PrePiLib/FwVol.c | 33 ++++++++++++++++++--- > EmbeddedPkg/Library/PrePiLib/PrePiLib.c | 2 +- > OvmfPkg/Library/PeilessStartupLib/DxeLoad.c | 4 +-- > 4 files changed, 53 insertions(+), 8 deletions(-) > > -- > 2.29.2.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#98844): https://edk2.groups.io/g/devel/message/98844 Mute This Topic: https://groups.io/mt/96369498/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.