1. Patchew
  2. EDK2
  3. [edk2-devel] [PATCH v11 00/17] CI: Use Fedora 35 container for Linux jobs
  4. View patch

[edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell

Oliver Steffen posted 17 patches 3 years ago
[edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
Posted by Oliver Steffen 3 years ago 
Work around a bug in Ovmf that causes Ovmf to crash on startup
when running in recent versions of Qemu.  Setting the cpu model
to something older, for example "Broadwell" works around the issue.

Signed-off-by: Oliver Steffen <osteffen@redhat.com>
---
 OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py b/OvmfPkg/PlatformCI/PlatformBuildLib.py
index bfef9849c749..93f7d7aa13d6 100644
--- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
+++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
@@ -194,6 +194,7 @@ class PlatformBuilder( UefiBuilder, BuildSettingsManager):
         cmd = "qemu-system-x86_64"
         args  = "-debugcon stdio"                                           # write messages to stdio
         args += " -global isa-debugcon.iobase=0x402"                        # debug messages out thru virtual io port
+        args += " -cpu Broadwell"                                           # workaround Qvmf bug
         args += " -net none"                                                # turn off network
         args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" # Mount disk with startup.nsh
 
-- 
2.39.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98596): https://edk2.groups.io/g/devel/message/98596
Mute This Topic: https://groups.io/mt/96311858/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
Posted by Yao, Jiewen 3 years ago 
Not sure the detail.

Could you please add more comment, such as, what issue? Why crash? Why changing to Broadwell can resolve it?
any URL?



> -----Original Message-----
> From: Oliver Steffen <osteffen@redhat.com>
> Sent: Tuesday, January 17, 2023 1:41 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Feng, Bob C <bob.c.feng@intel.com>; Bi,
> Dandan <dandan.bi@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Michael Kubacki
> <mikuback@linux.microsoft.com>; Ni, Ray <ray.ni@intel.com>; Sami
> Mujawar <sami.mujawar@arm.com>; Sean Brogan
> <sean.brogan@microsoft.com>; Chen, Christine <yuwei.chen@intel.com>;
> Pawel Polawski <ppolawsk@redhat.com>; chris.fernald@outlook.com; Oliver
> Steffen <osteffen@redhat.com>
> Subject: [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
> 
> Work around a bug in Ovmf that causes Ovmf to crash on startup
> when running in recent versions of Qemu.  Setting the cpu model
> to something older, for example "Broadwell" works around the issue.
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>  OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> index bfef9849c749..93f7d7aa13d6 100644
> --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> @@ -194,6 +194,7 @@ class PlatformBuilder( UefiBuilder,
> BuildSettingsManager):
>          cmd = "qemu-system-x86_64"
>          args  = "-debugcon stdio"                                           # write messages to
> stdio
>          args += " -global isa-debugcon.iobase=0x402"                        # debug
> messages out thru virtual io port
> +        args += " -cpu Broadwell"                                           # workaround Qvmf
> bug
>          args += " -net none"                                                # turn off network
>          args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" #
> Mount disk with startup.nsh
> 
> --
> 2.39.0



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98621): https://edk2.groups.io/g/devel/message/98621
Mute This Topic: https://groups.io/mt/96311858/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
Posted by Oliver Steffen 3 years ago 
It is this one:
https://bugzilla.tianocore.org/show_bug.cgi?id=4251
Should have put that into the commit message, sorry.


On Tue, Jan 17, 2023 at 1:16 AM Yao, Jiewen <jiewen.yao@intel.com> wrote:

> Not sure the detail.
>
> Could you please add more comment, such as, what issue? Why crash? Why
> changing to Broadwell can resolve it?
> any URL?
>
>
>
> > -----Original Message-----
> > From: Oliver Steffen <osteffen@redhat.com>
> > Sent: Tuesday, January 17, 2023 1:41 AM
> > To: devel@edk2.groups.io
> > Cc: Andrew Fish <afish@apple.com>; Ard Biesheuvel
> > <ardb+tianocore@kernel.org>; Feng, Bob C <bob.c.feng@intel.com>; Bi,
> > Dandan <dandan.bi@intel.com>; Gerd Hoffmann <kraxel@redhat.com>;
> > Wang, Jian J <jian.j.wang@intel.com>; Yao, Jiewen <jiewen.yao@intel.com
> >;
> > Justen, Jordan L <jordan.l.justen@intel.com>; Leif Lindholm
> > <quic_llindhol@quicinc.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> > Kinney, Michael D <michael.d.kinney@intel.com>; Michael Kubacki
> > <mikuback@linux.microsoft.com>; Ni, Ray <ray.ni@intel.com>; Sami
> > Mujawar <sami.mujawar@arm.com>; Sean Brogan
> > <sean.brogan@microsoft.com>; Chen, Christine <yuwei.chen@intel.com>;
> > Pawel Polawski <ppolawsk@redhat.com>; chris.fernald@outlook.com; Oliver
> > Steffen <osteffen@redhat.com>
> > Subject: [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
> >
> > Work around a bug in Ovmf that causes Ovmf to crash on startup
> > when running in recent versions of Qemu.  Setting the cpu model
> > to something older, for example "Broadwell" works around the issue.
> >
> > Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> > ---
> >  OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> > b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> > index bfef9849c749..93f7d7aa13d6 100644
> > --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> > +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> > @@ -194,6 +194,7 @@ class PlatformBuilder( UefiBuilder,
> > BuildSettingsManager):
> >          cmd = "qemu-system-x86_64"
> >          args  = "-debugcon stdio"
>      # write messages to
> > stdio
> >          args += " -global isa-debugcon.iobase=0x402"
>     # debug
> > messages out thru virtual io port
> > +        args += " -cpu Broadwell"
>      # workaround Qvmf
> > bug
> >          args += " -net none"
>     # turn off network
> >          args += f" -drive
> file=fat:rw:{VirtualDrive},format=raw,media=disk" #
> > Mount disk with startup.nsh
> >
> > --
> > 2.39.0
>
>
>
> 
>
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98665): https://edk2.groups.io/g/devel/message/98665
Mute This Topic: https://groups.io/mt/96311858/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
Posted by Yao, Jiewen 3 years ago 
I have seen Gerd sent out V4 patch set for #4251. Is that not enough?

In general, I prefer no work-around, unless there is strong reason.

I would like to have Gerd and Ard to feedback.

Thank you
Yao, Jiewen

From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oliver Steffen
Sent: Tuesday, January 17, 2023 6:37 PM
To: devel@edk2.groups.io; Yao, Jiewen <jiewen.yao@intel.com>
Cc: Andrew Fish <afish@apple.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Feng, Bob C <bob.c.feng@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Gerd Hoffmann <kraxel@redhat.com>; Wang, Jian J <jian.j.wang@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>; Michael Kubacki <mikuback@linux.microsoft.com>; Ni, Ray <ray.ni@intel.com>; Sami Mujawar <sami.mujawar@arm.com>; Sean Brogan <sean.brogan@microsoft.com>; Chen, Christine <yuwei.chen@intel.com>; Pawel Polawski <ppolawsk@redhat.com>; chris.fernald@outlook.com
Subject: Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell

It is this one:
https://bugzilla.tianocore.org/show_bug.cgi?id=4251
Should have put that into the commit message, sorry.


On Tue, Jan 17, 2023 at 1:16 AM Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>> wrote:
Not sure the detail.

Could you please add more comment, such as, what issue? Why crash? Why changing to Broadwell can resolve it?
any URL?



> -----Original Message-----
> From: Oliver Steffen <osteffen@redhat.com<mailto:osteffen@redhat.com>>
> Sent: Tuesday, January 17, 2023 1:41 AM
> To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> Cc: Andrew Fish <afish@apple.com<mailto:afish@apple.com>>; Ard Biesheuvel
> <ardb+tianocore@kernel.org<mailto:ardb%2Btianocore@kernel.org>>; Feng, Bob C <bob.c.feng@intel.com<mailto:bob.c.feng@intel.com>>; Bi,
> Dandan <dandan.bi@intel.com<mailto:dandan.bi@intel.com>>; Gerd Hoffmann <kraxel@redhat.com<mailto:kraxel@redhat.com>>;
> Wang, Jian J <jian.j.wang@intel.com<mailto:jian.j.wang@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>;
> Justen, Jordan L <jordan.l.justen@intel.com<mailto:jordan.l.justen@intel.com>>; Leif Lindholm
> <quic_llindhol@quicinc.com<mailto:quic_llindhol@quicinc.com>>; Gao, Liming <gaoliming@byosoft.com.cn<mailto:gaoliming@byosoft.com.cn>>;
> Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>; Michael Kubacki
> <mikuback@linux.microsoft.com<mailto:mikuback@linux.microsoft.com>>; Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>; Sami
> Mujawar <sami.mujawar@arm.com<mailto:sami.mujawar@arm.com>>; Sean Brogan
> <sean.brogan@microsoft.com<mailto:sean.brogan@microsoft.com>>; Chen, Christine <yuwei.chen@intel.com<mailto:yuwei.chen@intel.com>>;
> Pawel Polawski <ppolawsk@redhat.com<mailto:ppolawsk@redhat.com>>; chris.fernald@outlook.com<mailto:chris.fernald@outlook.com>; Oliver
> Steffen <osteffen@redhat.com<mailto:osteffen@redhat.com>>
> Subject: [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
>
> Work around a bug in Ovmf that causes Ovmf to crash on startup
> when running in recent versions of Qemu.  Setting the cpu model
> to something older, for example "Broadwell" works around the issue.
>
> Signed-off-by: Oliver Steffen <osteffen@redhat.com<mailto:osteffen@redhat.com>>
> ---
>  OvmfPkg/PlatformCI/PlatformBuildLib.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> index bfef9849c749..93f7d7aa13d6 100644
> --- a/OvmfPkg/PlatformCI/PlatformBuildLib.py
> +++ b/OvmfPkg/PlatformCI/PlatformBuildLib.py
> @@ -194,6 +194,7 @@ class PlatformBuilder( UefiBuilder,
> BuildSettingsManager):
>          cmd = "qemu-system-x86_64"
>          args  = "-debugcon stdio"                                           # write messages to
> stdio
>          args += " -global isa-debugcon.iobase=0x402"                        # debug
> messages out thru virtual io port
> +        args += " -cpu Broadwell"                                           # workaround Qvmf
> bug
>          args += " -net none"                                                # turn off network
>          args += f" -drive file=fat:rw:{VirtualDrive},format=raw,media=disk" #
> Mount disk with startup.nsh
>
> --
> 2.39.0








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98679): https://edk2.groups.io/g/devel/message/98679
Mute This Topic: https://groups.io/mt/96311858/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
Posted by Gerd Hoffmann 3 years ago 
On Tue, Jan 17, 2023 at 12:20:16PM +0000, Yao, Jiewen wrote:
> I have seen Gerd sent out V4 patch set for #4251. Is that not enough?

If that is merged first patch 17 should not be needed.

take care,
  Gerd



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98681): https://edk2.groups.io/g/devel/message/98681
Mute This Topic: https://groups.io/mt/96311858/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
Posted by Yao, Jiewen 3 years ago 
Cool!
Then I suggest to drop patch 17.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd
> Hoffmann
> Sent: Tuesday, January 17, 2023 8:39 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>
> Cc: devel@edk2.groups.io; osteffen@redhat.com; Andrew Fish
> <afish@apple.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Feng,
> Bob C <bob.c.feng@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Wang,
> Jian J <jian.j.wang@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>;
> Leif Lindholm <quic_llindhol@quicinc.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Michael Kubacki
> <mikuback@linux.microsoft.com>; Ni, Ray <ray.ni@intel.com>; Sami
> Mujawar <sami.mujawar@arm.com>; Sean Brogan
> <sean.brogan@microsoft.com>; Chen, Christine <yuwei.chen@intel.com>;
> Pawel Polawski <ppolawsk@redhat.com>; chris.fernald@outlook.com
> Subject: Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set
> CPU to Broadwell
> 
> On Tue, Jan 17, 2023 at 12:20:16PM +0000, Yao, Jiewen wrote:
> > I have seen Gerd sent out V4 patch set for #4251. Is that not enough?
> 
> If that is merged first patch 17 should not be needed.
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98702): https://edk2.groups.io/g/devel/message/98702
Mute This Topic: https://groups.io/mt/96311858/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set CPU to Broadwell
Posted by Oliver Steffen 3 years ago 
On Tue, Jan 17, 2023 at 3:50 PM Yao, Jiewen <jiewen.yao@intel.com> wrote:

> Cool!
> Then I suggest to drop patch 17.
>

Perfectly fine with me.


>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd
> > Hoffmann
> > Sent: Tuesday, January 17, 2023 8:39 PM
> > To: Yao, Jiewen <jiewen.yao@intel.com>
> > Cc: devel@edk2.groups.io; osteffen@redhat.com; Andrew Fish
> > <afish@apple.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Feng,
> > Bob C <bob.c.feng@intel.com>; Bi, Dandan <dandan.bi@intel.com>; Wang,
> > Jian J <jian.j.wang@intel.com>; Justen, Jordan L <
> jordan.l.justen@intel.com>;
> > Leif Lindholm <quic_llindhol@quicinc.com>; Gao, Liming
> > <gaoliming@byosoft.com.cn>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Michael Kubacki
> > <mikuback@linux.microsoft.com>; Ni, Ray <ray.ni@intel.com>; Sami
> > Mujawar <sami.mujawar@arm.com>; Sean Brogan
> > <sean.brogan@microsoft.com>; Chen, Christine <yuwei.chen@intel.com>;
> > Pawel Polawski <ppolawsk@redhat.com>; chris.fernald@outlook.com
> > Subject: Re: [edk2-devel] [PATCH v11 17/17] OfmvPkg: CI: Qemu tests: set
> > CPU to Broadwell
> >
> > On Tue, Jan 17, 2023 at 12:20:16PM +0000, Yao, Jiewen wrote:
> > > I have seen Gerd sent out V4 patch set for #4251. Is that not enough?
> >
> > If that is merged first patch 17 should not be needed.
> >
> > take care,
> >   Gerd
> >
>
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98704): https://edk2.groups.io/g/devel/message/98704
Mute This Topic: https://groups.io/mt/96311858/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.