1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices

Chang, Abner via groups.io posted 1 patch 1 year, 3 months ago
Failed in applying to current master (apply log)
MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
[edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
Posted by Chang, Abner via groups.io 1 year, 3 months ago 
From: Abner Chang <abner.chang@amd.com>

In V4: Update the copyright to 2023.
In V3: Add AMD copyright.
In V2: Remove the signed-off-by: Abner Chang

Display PCIe Vendor ID and Device ID in DEBUG message.

Signed-off-by: Jiangang He <jiangang.he@amd.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
Cc: Abner Chang <abner.chang@amd.com>
---
 MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
index 8eca8596958..6594b8eae83 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
@@ -3,6 +3,7 @@
 
 Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
 (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
+Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
@@ -227,13 +228,15 @@ PciSearchDevice (
 
   DEBUG ((
     DEBUG_INFO,
-    "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
+    "PciBus: Discovered %s @ [%02x|%02x|%02x]  [VID = 0x%x, DID = 0x%0x]\n",
     IS_PCI_BRIDGE (Pci) ?     L"PPB" :
     IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
     L"PCI",
     Bus,
     Device,
-    Func
+    Func,
+    Pci->Hdr.VendorId,
+    Pci->Hdr.DeviceId
     ));
 
   if (!IS_PCI_BRIDGE (Pci)) {
-- 
2.37.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#98332): https://edk2.groups.io/g/devel/message/98332
Mute This Topic: https://groups.io/mt/96217383/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
Posted by Ni, Ray 1 year, 2 months ago 
Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> Abner via groups.io
> Sent: Thursday, January 12, 2023 1:14 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Garrett
> Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> <abner.chang@amd.com>
> Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> information of PCIe devices
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> In V4: Update the copyright to 2023.
> In V3: Add AMD copyright.
> In V2: Remove the signed-off-by: Abner Chang
> 
> Display PCIe Vendor ID and Device ID in DEBUG message.
> 
> Signed-off-by: Jiangang He <jiangang.he@amd.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> Cc: Abner Chang <abner.chang@amd.com>
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> index 8eca8596958..6594b8eae83 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> @@ -3,6 +3,7 @@
> 
>  Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
>  (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -227,13 +228,15 @@ PciSearchDevice (
> 
>    DEBUG ((
>      DEBUG_INFO,
> -    "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> +    "PciBus: Discovered %s @ [%02x|%02x|%02x]  [VID = 0x%x, DID =
> 0x%0x]\n",
>      IS_PCI_BRIDGE (Pci) ?     L"PPB" :
>      IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
>      L"PCI",
>      Bus,
>      Device,
> -    Func
> +    Func,
> +    Pci->Hdr.VendorId,
> +    Pci->Hdr.DeviceId
>      ));
> 
>    if (!IS_PCI_BRIDGE (Pci)) {
> --
> 2.37.1.windows.1
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100154): https://edk2.groups.io/g/devel/message/100154
Mute This Topic: https://groups.io/mt/96217383/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
Posted by Michael D Kinney 1 year, 2 months ago 
Acked-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> Sent: Monday, February 13, 2023 6:18 PM
> To: devel@edk2.groups.io; abner.chang@amd.com
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall <garrett.kirkendall@amd.com>
> Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
> 
> Reviewed-by: Ray Ni <ray.ni@intel.com>
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Thursday, January 12, 2023 1:14 PM
> > To: devel@edk2.groups.io
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Garrett
> > Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > <abner.chang@amd.com>
> > Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > information of PCIe devices
> >
> > From: Abner Chang <abner.chang@amd.com>
> >
> > In V4: Update the copyright to 2023.
> > In V3: Add AMD copyright.
> > In V2: Remove the signed-off-by: Abner Chang
> >
> > Display PCIe Vendor ID and Device ID in DEBUG message.
> >
> > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > Cc: Hao A Wu <hao.a.wu@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > Cc: Abner Chang <abner.chang@amd.com>
> > ---
> >  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > index 8eca8596958..6594b8eae83 100644
> > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > @@ -3,6 +3,7 @@
> >
> >  Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> >  (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> >  SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >  **/
> > @@ -227,13 +228,15 @@ PciSearchDevice (
> >
> >    DEBUG ((
> >      DEBUG_INFO,
> > -    "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> > +    "PciBus: Discovered %s @ [%02x|%02x|%02x]  [VID = 0x%x, DID =
> > 0x%0x]\n",
> >      IS_PCI_BRIDGE (Pci) ?     L"PPB" :
> >      IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> >      L"PCI",
> >      Bus,
> >      Device,
> > -    Func
> > +    Func,
> > +    Pci->Hdr.VendorId,
> > +    Pci->Hdr.DeviceId
> >      ));
> >
> >    if (!IS_PCI_BRIDGE (Pci)) {
> > --
> > 2.37.1.windows.1
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100201): https://edk2.groups.io/g/devel/message/100201
Mute This Topic: https://groups.io/mt/96217383/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
Posted by Michael D Kinney 1 year, 2 months ago 
Merged

PR: https://github.com/tianocore/edk2/pull/4042
Commit: https://github.com/tianocore/edk2/commit/f9c6b5134e5e2c5ca977f422119b1255412acd53

Mike

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Tuesday, February 14, 2023 3:27 PM
> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; abner.chang@amd.com
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall <garrett.kirkendall@amd.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
> 
> Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> > Sent: Monday, February 13, 2023 6:18 PM
> > To: devel@edk2.groups.io; abner.chang@amd.com
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall <garrett.kirkendall@amd.com>
> > Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
> >
> > Reviewed-by: Ray Ni <ray.ni@intel.com>
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> > > Abner via groups.io
> > > Sent: Thursday, January 12, 2023 1:14 PM
> > > To: devel@edk2.groups.io
> > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Garrett
> > > Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > > <abner.chang@amd.com>
> > > Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > information of PCIe devices
> > >
> > > From: Abner Chang <abner.chang@amd.com>
> > >
> > > In V4: Update the copyright to 2023.
> > > In V3: Add AMD copyright.
> > > In V2: Remove the signed-off-by: Abner Chang
> > >
> > > Display PCIe Vendor ID and Device ID in DEBUG message.
> > >
> > > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > ---
> > >  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++--
> > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > index 8eca8596958..6594b8eae83 100644
> > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > @@ -3,6 +3,7 @@
> > >
> > >  Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
> > >  (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> > > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
> > >  SPDX-License-Identifier: BSD-2-Clause-Patent
> > >
> > >  **/
> > > @@ -227,13 +228,15 @@ PciSearchDevice (
> > >
> > >    DEBUG ((
> > >      DEBUG_INFO,
> > > -    "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> > > +    "PciBus: Discovered %s @ [%02x|%02x|%02x]  [VID = 0x%x, DID =
> > > 0x%0x]\n",
> > >      IS_PCI_BRIDGE (Pci) ?     L"PPB" :
> > >      IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> > >      L"PCI",
> > >      Bus,
> > >      Device,
> > > -    Func
> > > +    Func,
> > > +    Pci->Hdr.VendorId,
> > > +    Pci->Hdr.DeviceId
> > >      ));
> > >
> > >    if (!IS_PCI_BRIDGE (Pci)) {
> > > --
> > > 2.37.1.windows.1
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> > 
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100207): https://edk2.groups.io/g/devel/message/100207
Mute This Topic: https://groups.io/mt/96217383/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
Posted by Chang, Abner via groups.io 1 year, 2 months ago 
[AMD Official Use Only - General]

Thanks Ray and Mike, I will create PR and merge it.

Abner

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, February 15, 2023 7:27 AM
> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Chang, Abner
> <Abner.Chang@amd.com>
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett
> <Garrett.Kirkendall@amd.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> information of PCIe devices
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni,
> Ray
> > Sent: Monday, February 13, 2023 6:18 PM
> > To: devel@edk2.groups.io; abner.chang@amd.com
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall
> > <garrett.kirkendall@amd.com>
> > Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > information of PCIe devices
> >
> > Reviewed-by: Ray Ni <ray.ni@intel.com>
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > Chang, Abner via groups.io
> > > Sent: Thursday, January 12, 2023 1:14 PM
> > > To: devel@edk2.groups.io
> > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > > Garrett Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > > <abner.chang@amd.com>
> > > Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > information of PCIe devices
> > >
> > > From: Abner Chang <abner.chang@amd.com>
> > >
> > > In V4: Update the copyright to 2023.
> > > In V3: Add AMD copyright.
> > > In V2: Remove the signed-off-by: Abner Chang
> > >
> > > Display PCIe Vendor ID and Device ID in DEBUG message.
> > >
> > > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > > Cc: Abner Chang <abner.chang@amd.com>
> > > ---
> > >  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++-
> -
> > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > index 8eca8596958..6594b8eae83 100644
> > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > @@ -3,6 +3,7 @@
> > >
> > >  Copyright (c) 2006 - 2021, Intel Corporation. All rights
> > > reserved.<BR>
> > >  (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> > > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > > +reserved.<BR>
> > >  SPDX-License-Identifier: BSD-2-Clause-Patent
> > >
> > >  **/
> > > @@ -227,13 +228,15 @@ PciSearchDevice (
> > >
> > >    DEBUG ((
> > >      DEBUG_INFO,
> > > -    "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> > > +    "PciBus: Discovered %s @ [%02x|%02x|%02x]  [VID = 0x%x, DID =
> > > 0x%0x]\n",
> > >      IS_PCI_BRIDGE (Pci) ?     L"PPB" :
> > >      IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> > >      L"PCI",
> > >      Bus,
> > >      Device,
> > > -    Func
> > > +    Func,
> > > +    Pci->Hdr.VendorId,
> > > +    Pci->Hdr.DeviceId
> > >      ));
> > >
> > >    if (!IS_PCI_BRIDGE (Pci)) {
> > > --
> > > 2.37.1.windows.1
> > >
> > >
> > >
> > >
> > >
> >
> >
> >
> > 
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100203): https://edk2.groups.io/g/devel/message/100203
Mute This Topic: https://groups.io/mt/96217383/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
Posted by Michael D Kinney 1 year, 2 months ago 
It is already in process of being merged

https://github.com/tianocore/edk2/pull/4042

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner via groups.io
> Sent: Tuesday, February 14, 2023 4:29 PM
> To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>
> Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
> 
> [AMD Official Use Only - General]
> 
> Thanks Ray and Mike, I will create PR and merge it.
> 
> Abner
> 
> > -----Original Message-----
> > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > Sent: Wednesday, February 15, 2023 7:27 AM
> > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Chang, Abner
> > <Abner.Chang@amd.com>
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett
> > <Garrett.Kirkendall@amd.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: RE: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > information of PCIe devices
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni,
> > Ray
> > > Sent: Monday, February 13, 2023 6:18 PM
> > > To: devel@edk2.groups.io; abner.chang@amd.com
> > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall
> > > <garrett.kirkendall@amd.com>
> > > Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > information of PCIe devices
> > >
> > > Reviewed-by: Ray Ni <ray.ni@intel.com>
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > Chang, Abner via groups.io
> > > > Sent: Thursday, January 12, 2023 1:14 PM
> > > > To: devel@edk2.groups.io
> > > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > > > Garrett Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > > > <abner.chang@amd.com>
> > > > Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > > information of PCIe devices
> > > >
> > > > From: Abner Chang <abner.chang@amd.com>
> > > >
> > > > In V4: Update the copyright to 2023.
> > > > In V3: Add AMD copyright.
> > > > In V2: Remove the signed-off-by: Abner Chang
> > > >
> > > > Display PCIe Vendor ID and Device ID in DEBUG message.
> > > >
> > > > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > > Cc: Ray Ni <ray.ni@intel.com>
> > > > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > ---
> > > >  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++-
> > -
> > > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > index 8eca8596958..6594b8eae83 100644
> > > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > @@ -3,6 +3,7 @@
> > > >
> > > >  Copyright (c) 2006 - 2021, Intel Corporation. All rights
> > > > reserved.<BR>
> > > >  (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> > > > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > > > +reserved.<BR>
> > > >  SPDX-License-Identifier: BSD-2-Clause-Patent
> > > >
> > > >  **/
> > > > @@ -227,13 +228,15 @@ PciSearchDevice (
> > > >
> > > >    DEBUG ((
> > > >      DEBUG_INFO,
> > > > -    "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> > > > +    "PciBus: Discovered %s @ [%02x|%02x|%02x]  [VID = 0x%x, DID =
> > > > 0x%0x]\n",
> > > >      IS_PCI_BRIDGE (Pci) ?     L"PPB" :
> > > >      IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> > > >      L"PCI",
> > > >      Bus,
> > > >      Device,
> > > > -    Func
> > > > +    Func,
> > > > +    Pci->Hdr.VendorId,
> > > > +    Pci->Hdr.DeviceId
> > > >      ));
> > > >
> > > >    if (!IS_PCI_BRIDGE (Pci)) {
> > > > --
> > > > 2.37.1.windows.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > >
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100204): https://edk2.groups.io/g/devel/message/100204
Mute This Topic: https://groups.io/mt/96217383/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076/xyzzy [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
Posted by Chang, Abner via groups.io 1 year, 2 months ago 
[AMD Official Use Only - General]

Ah ok, thanks!

> -----Original Message-----
> From: Kinney, Michael D <michael.d.kinney@intel.com>
> Sent: Wednesday, February 15, 2023 8:41 AM
> To: devel@edk2.groups.io; Chang, Abner <Abner.Chang@amd.com>; Ni, Ray
> <ray.ni@intel.com>
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett
> <Garrett.Kirkendall@amd.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: RE: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> information of PCIe devices
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> It is already in process of being merged
> 
> https://github.com/tianocore/edk2/pull/4042
> 
> Mike
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Tuesday, February 14, 2023 4:29 PM
> > To: Kinney, Michael D <michael.d.kinney@intel.com>;
> > devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett
> > <Garrett.Kirkendall@amd.com>
> > Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > information of PCIe devices
> >
> > [AMD Official Use Only - General]
> >
> > Thanks Ray and Mike, I will create PR and merge it.
> >
> > Abner
> >
> > > -----Original Message-----
> > > From: Kinney, Michael D <michael.d.kinney@intel.com>
> > > Sent: Wednesday, February 15, 2023 7:27 AM
> > > To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Chang, Abner
> > > <Abner.Chang@amd.com>
> > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Kirkendall, Garrett
> > > <Garrett.Kirkendall@amd.com>; Kinney, Michael D
> > > <michael.d.kinney@intel.com>
> > > Subject: RE: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > information of PCIe devices
> > >
> > > Caution: This message originated from an External Source. Use proper
> > > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > Acked-by: Michael D Kinney <michael.d.kinney@intel.com>
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni,
> > > Ray
> > > > Sent: Monday, February 13, 2023 6:18 PM
> > > > To: devel@edk2.groups.io; abner.chang@amd.com
> > > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Garrett Kirkendall
> > > > <garrett.kirkendall@amd.com>
> > > > Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display
> > > > more information of PCIe devices
> > > >
> > > > Reviewed-by: Ray Ni <ray.ni@intel.com>
> > > >
> > > > > -----Original Message-----
> > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > > > > Chang, Abner via groups.io
> > > > > Sent: Thursday, January 12, 2023 1:14 PM
> > > > > To: devel@edk2.groups.io
> > > > > Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>;
> > > > > Garrett Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> > > > > <abner.chang@amd.com>
> > > > > Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> > > > > information of PCIe devices
> > > > >
> > > > > From: Abner Chang <abner.chang@amd.com>
> > > > >
> > > > > In V4: Update the copyright to 2023.
> > > > > In V3: Add AMD copyright.
> > > > > In V2: Remove the signed-off-by: Abner Chang
> > > > >
> > > > > Display PCIe Vendor ID and Device ID in DEBUG message.
> > > > >
> > > > > Signed-off-by: Jiangang He <jiangang.he@amd.com>
> > > > > Cc: Hao A Wu <hao.a.wu@intel.com>
> > > > > Cc: Ray Ni <ray.ni@intel.com>
> > > > > Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> > > > > Cc: Abner Chang <abner.chang@amd.com>
> > > > > ---
> > > > >  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7
> > > > > +++++-
> > > -
> > > > >  1 file changed, 5 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git
> > > > > a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > > index 8eca8596958..6594b8eae83 100644
> > > > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> > > > > @@ -3,6 +3,7 @@
> > > > >
> > > > >  Copyright (c) 2006 - 2021, Intel Corporation. All rights
> > > > > reserved.<BR>
> > > > >  (C) Copyright 2015 Hewlett Packard Enterprise Development
> > > > > LP<BR>
> > > > > +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> > > > > +reserved.<BR>
> > > > >  SPDX-License-Identifier: BSD-2-Clause-Patent
> > > > >
> > > > >  **/
> > > > > @@ -227,13 +228,15 @@ PciSearchDevice (
> > > > >
> > > > >    DEBUG ((
> > > > >      DEBUG_INFO,
> > > > > -    "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> > > > > +    "PciBus: Discovered %s @ [%02x|%02x|%02x]  [VID = 0x%x, DID
> > > > > + =
> > > > > 0x%0x]\n",
> > > > >      IS_PCI_BRIDGE (Pci) ?     L"PPB" :
> > > > >      IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
> > > > >      L"PCI",
> > > > >      Bus,
> > > > >      Device,
> > > > > -    Func
> > > > > +    Func,
> > > > > +    Pci->Hdr.VendorId,
> > > > > +    Pci->Hdr.DeviceId
> > > > >      ));
> > > > >
> > > > >    if (!IS_PCI_BRIDGE (Pci)) {
> > > > > --
> > > > > 2.37.1.windows.1
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> >
> >
> > 
> >


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100205): https://edk2.groups.io/g/devel/message/100205
Mute This Topic: https://groups.io/mt/96217383/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.