[edk2-devel] [edk2-platforms][PATCH v2 00/11] Ext4Pkg: Code correctness and security improvements

Savva Mitrofanov posted 11 patches 1 year, 4 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
Features/Ext4Pkg/Ext4Pkg.dsc          |  2 +-
Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h   | 17 +++++--
Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    | 42 +++++++++++++++-
Features/Ext4Pkg/Ext4Dxe/BlockGroup.c |  5 ++
Features/Ext4Pkg/Ext4Dxe/Directory.c  | 51 ++++++++++++--------
Features/Ext4Pkg/Ext4Dxe/DiskUtil.c   |  8 +--
Features/Ext4Pkg/Ext4Dxe/File.c       | 23 ++++++---
Features/Ext4Pkg/Ext4Dxe/Inode.c      |  2 +-
Features/Ext4Pkg/Ext4Dxe/Superblock.c | 16 ++++--
9 files changed, 125 insertions(+), 41 deletions(-)
[edk2-devel] [edk2-platforms][PATCH v2 00/11] Ext4Pkg: Code correctness and security improvements
Posted by Savva Mitrofanov 1 year, 4 months ago
Hi all,

In v2 I corrected remarks from Pedro Falcato. Also I added 'Fixes' tag to track
which exactly state of driver is fixed by this patchset.

This patchset fixes several code problems found by fuzzing Ext4Dxe like
buffer and integer overflows, memory leaks, logic bugs and so on.

REF: https://github.com/savvamitrofanov/edk2-platforms/tree/master

Cc: Marvin Häuser <mhaeuser@posteo.de>
Cc: Pedro Falcato <pedro.falcato@gmail.com>
Cc: Vitaly Cheptsov <vit9696@protonmail.com>

Savva Mitrofanov (11):
  Ext4Pkg: Fix memory leak in Ext4RetrieveDirent
  Ext4Pkg: Move EXT4_NAME_MAX definition to Ext4Disk.h
  Ext4Pkg: Fix global buffer overflow in Ext4ReadDir
  Ext4Pkg: Fix incorrect checksum metadata feature check
  Ext4Pkg: Fix division by zero by adding check for s_inodes_per_group
  Ext4Pkg: Add inode number validity check
  Ext4Pkg: Fix shift out of bounds in Ext4OpenSuperblock
  Ext4Pkg: Corrects integer overflow check logic in DiskUtil
  Ext4Pkg: Check that source file is directory in Ext4OpenInternal
  Ext4Pkg: Check VolumeName allocation correctness in Ext4GetVolumeName
  Ext4Pkg: Add missing exit Status in Ext4OpenDirent

 Features/Ext4Pkg/Ext4Pkg.dsc          |  2 +-
 Features/Ext4Pkg/Ext4Dxe/Ext4Disk.h   | 17 +++++--
 Features/Ext4Pkg/Ext4Dxe/Ext4Dxe.h    | 42 +++++++++++++++-
 Features/Ext4Pkg/Ext4Dxe/BlockGroup.c |  5 ++
 Features/Ext4Pkg/Ext4Dxe/Directory.c  | 51 ++++++++++++--------
 Features/Ext4Pkg/Ext4Dxe/DiskUtil.c   |  8 +--
 Features/Ext4Pkg/Ext4Dxe/File.c       | 23 ++++++---
 Features/Ext4Pkg/Ext4Dxe/Inode.c      |  2 +-
 Features/Ext4Pkg/Ext4Dxe/Superblock.c | 16 ++++--
 9 files changed, 125 insertions(+), 41 deletions(-)

-- 
2.38.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97260): https://edk2.groups.io/g/devel/message/97260
Mute This Topic: https://groups.io/mt/95622327/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-