1. Patchew
  2. EDK2
  3. [edk2-devel] [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9
  4. View patch

[edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event

Robert Phelps via groups.io posted 2 patches 3 years, 3 months ago
[edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event
Posted by Robert Phelps via groups.io 3 years, 3 months ago 
This code signals the Before Exit Boot Services event at the beginning
of the ExitBootServices() function.  This gives all the rest of the
code to prepare for the ExitBootServices event.

Cc: Dandan Bi <dandan.bi@intel.com> [dandanbi]
Cc: Liming Gao <gaoliming@byosoft.com.cn> [lgao4]

Signed-off-by: Robert Phelps <robert@ami.com>
---
 MdeModulePkg/Core/Dxe/DxeMain.inf       | 1 +
 MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/MdeModulePkg/Core/Dxe/DxeMain.inf b/MdeModulePkg/Core/Dxe/DxeMain.inf
index e4bca89577..346bfa7e89 100644
--- a/MdeModulePkg/Core/Dxe/DxeMain.inf
+++ b/MdeModulePkg/Core/Dxe/DxeMain.inf
@@ -122,6 +122,7 @@
   gEfiMemoryAttributesTableGuid                 ## SOMETIMES_PRODUCES   ## SystemTable
   gEfiEndOfDxeEventGroupGuid                    ## SOMETIMES_CONSUMES   ## Event
   gEfiHobMemoryAllocStackGuid                   ## SOMETIMES_CONSUMES   ## SystemTable
+  gEfiEventBeforeExitBootServicesGuid           ## PRODUCES   ## Event

 [Ppis]
   gEfiVectorHandoffInfoPpiGuid                  ## UNDEFINED # HOB
diff --git a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
index 5733f0c8ec..1417f0eaa8 100644
--- a/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
+++ b/MdeModulePkg/Core/Dxe/DxeMain/DxeMain.c
@@ -763,6 +763,8 @@ CoreExitBootServices (
 {
   EFI_STATUS  Status;

+  // Before-exit-boot-services event
+  CoreNotifySignalList (&gEfiEventBeforeExitBootServicesGuid);
   //
   // Disable Timer
   //
--
2.36.1.windows.1
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96103): https://edk2.groups.io/g/devel/message/96103
Mute This Topic: https://groups.io/mt/94899157/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event
Posted by Dionna Glaze via groups.io 3 years, 3 months ago 
>
> This code signals the Before Exit Boot Services event at the beginning
> of the ExitBootServices() function.  This gives all the rest of the
> code to prepare for the ExitBootServices event.
>

Hi Robert, I think we're both trying to do this at the same time. See
the patch series "SEV-SNP accepted memory and BeforeExitBootServices"
which suppose now is not appropriately titled since Michael asked me
to add the AfterReadyToBoot event.

-- 
-Dionna Glaze, PhD (she/her)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96122): https://edk2.groups.io/g/devel/message/96122
Mute This Topic: https://groups.io/mt/94899157/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event
Posted by Robert Phelps via groups.io 3 years, 3 months ago 
Dionna,

So how should we want to handle this.  Leave yours in or leave mine in.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96135): https://edk2.groups.io/g/devel/message/96135
Mute This Topic: https://groups.io/mt/94899157/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event
Posted by Dionna Glaze via groups.io 3 years, 3 months ago 
> So how should we want to handle this.  Leave yours in or leave mine in.

Given that I'm not particularly confident in how I've implemented the
after_ready_to_boot spec, and you haven't implemented it, I'm not
sure. I'm pursuing the before_exit_boot_services implementation to
solve a problem in confidential compute as part of my job, so I think
I have the motivation to keep pushing on this. Let's go with mine
since it's further along. I'd appreciate a Reviewed-by if you agree
with the implementations.

-- 
-Dionna Glaze, PhD (she/her)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96138): https://edk2.groups.io/g/devel/message/96138
Mute This Topic: https://groups.io/mt/94899157/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event
Posted by Michael D Kinney 3 years, 3 months ago 
I am confused.  I see patches related to ReadyToBoot and ExitBootServices and they mix what is in description and what is in code.

I recommend you coordinate and put together a clean set of patches for these topics.

Thanks,

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dionna Glaze via groups.io
> Sent: Wednesday, November 9, 2022 8:22 AM
> To: Robert Phelps <robert@ami.com>
> Cc: devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event
> 
> > So how should we want to handle this.  Leave yours in or leave mine in.
> 
> Given that I'm not particularly confident in how I've implemented the
> after_ready_to_boot spec, and you haven't implemented it, I'm not
> sure. I'm pursuing the before_exit_boot_services implementation to
> solve a problem in confidential compute as part of my job, so I think
> I have the motivation to keep pushing on this. Let's go with mine
> since it's further along. I'd appreciate a Reviewed-by if you agree
> with the implementations.
> 
> --
> -Dionna Glaze, PhD (she/her)
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96140): https://edk2.groups.io/g/devel/message/96140
Mute This Topic: https://groups.io/mt/94899157/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event
Posted by Dionna Glaze via groups.io 3 years, 3 months ago 
>
> I am confused.  I see patches related to ReadyToBoot and ExitBootServices and they mix what is in description and what is in code.
>

Will you please comment on the patches in question where the error is?
I don't follow what you're saying.

> I recommend you coordinate and put together a clean set of patches for these topics.
>

Sounds good.


-- 
-Dionna Glaze, PhD (she/her)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96141): https://edk2.groups.io/g/devel/message/96141
Mute This Topic: https://groups.io/mt/94899157/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event
Posted by Robert Phelps via groups.io 3 years, 3 months ago 
Dionna,

I can create a new patch that contains, the two Event definitions and the code that signals both events.  I can use my patches that I already have and then add the code from your submission that signals the After Ready to Boot event to that.

Rob


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96145): https://edk2.groups.io/g/devel/message/96145
Mute This Topic: https://groups.io/mt/94899157/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH 2/2] MdeModulePkg: Added call to signal New Event
Posted by Dionna Glaze via groups.io 3 years, 3 months ago 
>
> I can create a new patch that contains, the two Event definitions and the code that signals both events.  I can use my patches that I already have and then add the code from your submission that signals the After Ready to Boot event to that.
>
> Rob

I think since Jiewen and Ard already acked my patches for
before_exit_boot_services, you might be better served by just rebasing
your after_ready_to_boot changes on my v1 series, since Michael has
said he doesn't want the after_ready_to_boot changes I had in v2.

-- 
-Dionna Glaze, PhD (she/her)


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96163): https://edk2.groups.io/g/devel/message/96163
Mute This Topic: https://groups.io/mt/94899157/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.