1. Patchew
  2. EDK2
  3. View series

[edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes

Judah Vang posted 2 patches 1 year, 5 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf    |  2 +-
CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf    |  2 +-
CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 ++++++++++-
CryptoPkg/Readme.md                               | 26 +++++++++++---------
4 files changed, 29 insertions(+), 15 deletions(-)
[edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
Posted by Judah Vang 1 year, 5 months ago 
https://bugzilla.tianocore.org/show_bug.cgi?id=3991
https://bugzilla.tianocore.org/show_bug.cgi?id=3992

There is a #define to deprecate Sha1 functions but not
all the Sha1 function are wrapped around this #define causing
a build error. The fix is to wrap all Sha1 functions with
the #define.

Need crypto AES to be supported for PEI phase and need
crypto KDF to be supported for SMM phase. Update Readme
to show AES and HKDF defaults.

Judah Vang (2):
  CryptoPkg: Sha1 functions causing build errors
  CryptoPkg: Need to enable crypto functions

 CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf    |  2 +-
 CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf    |  2 +-
 CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 ++++++++++-
 CryptoPkg/Readme.md                               | 26 +++++++++++---------
 4 files changed, 29 insertions(+), 15 deletions(-)

-- 
2.35.1.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96040): https://edk2.groups.io/g/devel/message/96040
Mute This Topic: https://groups.io/mt/94873522/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
Posted by Yao, Jiewen 1 year, 5 months ago 
Hey
Would you please split this patch set to two different one? They are two different HSDs.

Please aware that we are in software freeze phase now.

I suggest we include 3991 in this release, because it is an important bug fix.

I suggest we defer 3992 to next release, because it is feature enhancement.

Comment is welcome!

Thank you
Yao, Jiewen


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Judah
> Vang
> Sent: Tuesday, November 8, 2022 2:37 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=3991
> https://bugzilla.tianocore.org/show_bug.cgi?id=3992
> 
> There is a #define to deprecate Sha1 functions but not
> all the Sha1 function are wrapped around this #define causing
> a build error. The fix is to wrap all Sha1 functions with
> the #define.
> 
> Need crypto AES to be supported for PEI phase and need
> crypto KDF to be supported for SMM phase. Update Readme
> to show AES and HKDF defaults.
> 
> Judah Vang (2):
>   CryptoPkg: Sha1 functions causing build errors
>   CryptoPkg: Need to enable crypto functions
> 
>  CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf    |  2 +-
>  CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf    |  2 +-
>  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 ++++++++++-
>  CryptoPkg/Readme.md                               | 26 +++++++++++---------
>  4 files changed, 29 insertions(+), 15 deletions(-)
> 
> --
> 2.35.1.windows.2
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96043): https://edk2.groups.io/g/devel/message/96043
Mute This Topic: https://groups.io/mt/94873522/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
Posted by Judah Vang 1 year, 5 months ago 
Sure, I can do that.  I will resubmit as separate patches.

-----Original Message-----
From: Yao, Jiewen <jiewen.yao@intel.com> 
Sent: Monday, November 7, 2022 10:42 AM
To: devel@edk2.groups.io; Vang, Judah <judah.vang@intel.com>
Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes

Hey
Would you please split this patch set to two different one? They are two different HSDs.

Please aware that we are in software freeze phase now.

I suggest we include 3991 in this release, because it is an important bug fix.

I suggest we defer 3992 to next release, because it is feature enhancement.

Comment is welcome!

Thank you
Yao, Jiewen


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Judah 
> Vang
> Sent: Tuesday, November 8, 2022 2:37 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=3991
> https://bugzilla.tianocore.org/show_bug.cgi?id=3992
> 
> There is a #define to deprecate Sha1 functions but not all the Sha1 
> function are wrapped around this #define causing a build error. The 
> fix is to wrap all Sha1 functions with the #define.
> 
> Need crypto AES to be supported for PEI phase and need crypto KDF to 
> be supported for SMM phase. Update Readme to show AES and HKDF 
> defaults.
> 
> Judah Vang (2):
>   CryptoPkg: Sha1 functions causing build errors
>   CryptoPkg: Need to enable crypto functions
> 
>  CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf    |  2 +-
>  CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf    |  2 +-
>  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 ++++++++++-
>  CryptoPkg/Readme.md                               | 26 +++++++++++---------
>  4 files changed, 29 insertions(+), 15 deletions(-)
> 
> --
> 2.35.1.windows.2
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96045): https://edk2.groups.io/g/devel/message/96045
Mute This Topic: https://groups.io/mt/94873522/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
Posted by Yao, Jiewen 1 year, 5 months ago 
Also, please ensure your patch can pass tiano CI.

I cannot find the PR to CI for those features. Would you please point to me?

Thank you
Yao Jiewen


> -----Original Message-----
> From: Vang, Judah <judah.vang@intel.com>
> Sent: Tuesday, November 8, 2022 2:45 AM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
> Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
> 
> Sure, I can do that.  I will resubmit as separate patches.
> 
> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Monday, November 7, 2022 10:42 AM
> To: devel@edk2.groups.io; Vang, Judah <judah.vang@intel.com>
> Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
> 
> Hey
> Would you please split this patch set to two different one? They are two
> different HSDs.
> 
> Please aware that we are in software freeze phase now.
> 
> I suggest we include 3991 in this release, because it is an important bug fix.
> 
> I suggest we defer 3992 to next release, because it is feature enhancement.
> 
> Comment is welcome!
> 
> Thank you
> Yao, Jiewen
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Judah
> > Vang
> > Sent: Tuesday, November 8, 2022 2:37 AM
> > To: devel@edk2.groups.io
> > Subject: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=3991
> > https://bugzilla.tianocore.org/show_bug.cgi?id=3992
> >
> > There is a #define to deprecate Sha1 functions but not all the Sha1
> > function are wrapped around this #define causing a build error. The
> > fix is to wrap all Sha1 functions with the #define.
> >
> > Need crypto AES to be supported for PEI phase and need crypto KDF to
> > be supported for SMM phase. Update Readme to show AES and HKDF
> > defaults.
> >
> > Judah Vang (2):
> >   CryptoPkg: Sha1 functions causing build errors
> >   CryptoPkg: Need to enable crypto functions
> >
> >  CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf    |  2 +-
> >  CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf    |  2 +-
> >  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 ++++++++++-
> >  CryptoPkg/Readme.md                               | 26 +++++++++++---------
> >  4 files changed, 29 insertions(+), 15 deletions(-)
> >
> > --
> > 2.35.1.windows.2
> >
> >
> >
> > 
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96046): https://edk2.groups.io/g/devel/message/96046
Mute This Topic: https://groups.io/mt/94873522/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
Posted by Judah Vang 1 year, 5 months ago 
Jiewen,

Thanks.  Running the CI now.
https://github.com/tianocore/edk2/pull/3609

Judah

-----Original Message-----
From: Yao, Jiewen <jiewen.yao@intel.com> 
Sent: Monday, November 7, 2022 10:48 AM
To: Vang, Judah <judah.vang@intel.com>; devel@edk2.groups.io
Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes

Also, please ensure your patch can pass tiano CI.

I cannot find the PR to CI for those features. Would you please point to me?

Thank you
Yao Jiewen


> -----Original Message-----
> From: Vang, Judah <judah.vang@intel.com>
> Sent: Tuesday, November 8, 2022 2:45 AM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
> Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
> 
> Sure, I can do that.  I will resubmit as separate patches.
> 
> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Monday, November 7, 2022 10:42 AM
> To: devel@edk2.groups.io; Vang, Judah <judah.vang@intel.com>
> Subject: RE: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
> 
> Hey
> Would you please split this patch set to two different one? They are 
> two different HSDs.
> 
> Please aware that we are in software freeze phase now.
> 
> I suggest we include 3991 in this release, because it is an important bug fix.
> 
> I suggest we defer 3992 to next release, because it is feature enhancement.
> 
> Comment is welcome!
> 
> Thank you
> Yao, Jiewen
> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Judah 
> > Vang
> > Sent: Tuesday, November 8, 2022 2:37 AM
> > To: devel@edk2.groups.io
> > Subject: [edk2-devel] [PATCH v2 0/2] CryptoPkg bug fixes
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=3991
> > https://bugzilla.tianocore.org/show_bug.cgi?id=3992
> >
> > There is a #define to deprecate Sha1 functions but not all the Sha1 
> > function are wrapped around this #define causing a build error. The 
> > fix is to wrap all Sha1 functions with the #define.
> >
> > Need crypto AES to be supported for PEI phase and need crypto KDF to 
> > be supported for SMM phase. Update Readme to show AES and HKDF 
> > defaults.
> >
> > Judah Vang (2):
> >   CryptoPkg: Sha1 functions causing build errors
> >   CryptoPkg: Need to enable crypto functions
> >
> >  CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf    |  2 +-
> >  CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf    |  2 +-
> >  CryptoPkg/Library/BaseHashApiLib/BaseHashApiLib.c | 14 ++++++++++-
> >  CryptoPkg/Readme.md                               | 26 +++++++++++---------
> >  4 files changed, 29 insertions(+), 15 deletions(-)
> >
> > --
> > 2.35.1.windows.2
> >
> >
> >
> > 
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#96047): https://edk2.groups.io/g/devel/message/96047
Mute This Topic: https://groups.io/mt/94873522/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.