Add CpuExceptionHandlerTest.h in EccCheck IgnoreFiles of
UefiCpuPkg/UefiCpuPkg.ci.yaml to pass ECC check. The
GENERAL_REGISTER.R8 in this file triggers EccCheck failure
since no lower case characters in R8/R9/R10.

Signed-off-by: Dun Tan <dun.tan@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
---
 UefiCpuPkg/UefiCpuPkg.ci.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml b/UefiCpuPkg/UefiCpuPkg.ci.yaml
index bbdc44a45b..1acc6daa76 100644
--- a/UefiCpuPkg/UefiCpuPkg.ci.yaml
+++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml
@@ -19,6 +19,7 @@
         ],
         ## Both file path and directory path are accepted.
         "IgnoreFiles": [
+            "CpuExceptionHandlerUnitTest/CpuExceptionHandlerTest.h"
         ]
     },
     "CompilerPlugin": {
-- 
2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95203): https://edk2.groups.io/g/devel/message/95203
Mute This Topic: https://groups.io/mt/94323062/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Can we use BaseTools/Source/Python/Ecc/exception.xml to mark exceptions of R8/R9/etc.
instead of ignoring the entire H file?

Thanks,
ray

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Friday, October 14, 2022 5:20 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>
> Subject: [Patch V3 4/4] UefiCpuPkg: Add CpuExceptionHandlerTest.h in ECC IgnoreFile
> 
> Add CpuExceptionHandlerTest.h in EccCheck IgnoreFiles of
> UefiCpuPkg/UefiCpuPkg.ci.yaml to pass ECC check. The
> GENERAL_REGISTER.R8 in this file triggers EccCheck failure
> since no lower case characters in R8/R9/R10.
> 
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.ci.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml b/UefiCpuPkg/UefiCpuPkg.ci.yaml
> index bbdc44a45b..1acc6daa76 100644
> --- a/UefiCpuPkg/UefiCpuPkg.ci.yaml
> +++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml
> @@ -19,6 +19,7 @@
>          ],
>          ## Both file path and directory path are accepted.
>          "IgnoreFiles": [
> +            "CpuExceptionHandlerUnitTest/CpuExceptionHandlerTest.h"
>          ]
>      },
>      "CompilerPlugin": {
> --
> 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95204): https://edk2.groups.io/g/devel/message/95204
Mute This Topic: https://groups.io/mt/94323062/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Ok, I'll try to add this format code for R8/R9/etc.
"ExceptionList": [
          "<ErrorID>", "<KeyWord>"
        ],

Thanks,
Dun
-----Original Message-----
From: Ni, Ray <ray.ni@intel.com> 
Sent: Friday, October 14, 2022 5:40 PM
To: Tan, Dun <dun.tan@intel.com>; devel@edk2.groups.io
Cc: Dong, Eric <eric.dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>
Subject: RE: [Patch V3 4/4] UefiCpuPkg: Add CpuExceptionHandlerTest.h in ECC IgnoreFile

Can we use BaseTools/Source/Python/Ecc/exception.xml to mark exceptions of R8/R9/etc.
instead of ignoring the entire H file?

Thanks,
ray

> -----Original Message-----
> From: Tan, Dun <dun.tan@intel.com>
> Sent: Friday, October 14, 2022 5:20 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; 
> Kumar, Rahul R <rahul.r.kumar@intel.com>
> Subject: [Patch V3 4/4] UefiCpuPkg: Add CpuExceptionHandlerTest.h in 
> ECC IgnoreFile
> 
> Add CpuExceptionHandlerTest.h in EccCheck IgnoreFiles of 
> UefiCpuPkg/UefiCpuPkg.ci.yaml to pass ECC check. The
> GENERAL_REGISTER.R8 in this file triggers EccCheck failure since no 
> lower case characters in R8/R9/R10.
> 
> Signed-off-by: Dun Tan <dun.tan@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> ---
>  UefiCpuPkg/UefiCpuPkg.ci.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml 
> b/UefiCpuPkg/UefiCpuPkg.ci.yaml index bbdc44a45b..1acc6daa76 100644
> --- a/UefiCpuPkg/UefiCpuPkg.ci.yaml
> +++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml
> @@ -19,6 +19,7 @@
>          ],
>          ## Both file path and directory path are accepted.
>          "IgnoreFiles": [
> +            "CpuExceptionHandlerUnitTest/CpuExceptionHandlerTest.h"
>          ]
>      },
>      "CompilerPlugin": {
> --
> 2.31.1.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95205): https://edk2.groups.io/g/devel/message/95205
Mute This Topic: https://groups.io/mt/94323062/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-