Add PCCT generator and various fixes

[edk2-devel] [PATCH 04/14] DynamicTablesPkg: Update CmObjParser for MinorRevision

Posted by PierreGondois 3 years, 4 months ago

From: Pierre Gondois <pierre.gondois@arm.com>

commit 0d23c447d6f5 ("DynamicTablesPkg: Add support to specify FADT
minor revision")
adds new 'MinorRevision' field to CM_STD_OBJ_ACPI_TABLE_INFO.
Reflect the change in this patch to the CmObjectParser.

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
 .../Common/TableHelperLib/ConfigurationManagerObjectParser.c   | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
index 80ebb0708661..f82541240ae0 100644
--- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
+++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
@@ -639,7 +639,8 @@ STATIC CONST CM_OBJ_PARSER  StdObjAcpiTableInfoParser[] = {
   { "TableGeneratorId",   sizeof (ACPI_TABLE_GENERATOR_ID),       "0x%x",   NULL },
   { "AcpiTableData",      sizeof (EFI_ACPI_DESCRIPTION_HEADER *), "0x%p",   NULL },
   { "OemTableId",         8,                                      "0x%LLX", NULL },
-  { "OemRevision",        4,                                      "0x%x",   NULL }
+  { "OemRevision",        4,                                      "0x%x",   NULL },
+  { "MinorRevision",      1,                                      "0x%x",   NULL },
 };
 
 /** A parser for EStdObjSmbiosTableList.
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94885): https://edk2.groups.io/g/devel/message/94885
Mute This Topic: https://groups.io/mt/94232523/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 04/14] DynamicTablesPkg: Update CmObjParser for MinorRevision

Posted by Sami Mujawar 3 years, 3 months ago

Hi Pierre,

Thank you for this patch.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> commit 0d23c447d6f5 ("DynamicTablesPkg: Add support to specify FADT
> minor revision")
> adds new 'MinorRevision' field to CM_STD_OBJ_ACPI_TABLE_INFO.
> Reflect the change in this patch to the CmObjectParser.
>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>   .../Common/TableHelperLib/ConfigurationManagerObjectParser.c   | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
> index 80ebb0708661..f82541240ae0 100644
> --- a/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
> +++ b/DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
> @@ -639,7 +639,8 @@ STATIC CONST CM_OBJ_PARSER  StdObjAcpiTableInfoParser[] = {
>     { "TableGeneratorId",   sizeof (ACPI_TABLE_GENERATOR_ID),       "0x%x",   NULL },
>     { "AcpiTableData",      sizeof (EFI_ACPI_DESCRIPTION_HEADER *), "0x%p",   NULL },
>     { "OemTableId",         8,                                      "0x%LLX", NULL },
> -  { "OemRevision",        4,                                      "0x%x",   NULL }
> +  { "OemRevision",        4,                                      "0x%x",   NULL },
> +  { "MinorRevision",      1,                                      "0x%x",   NULL },
>   };
>   
>   /** A parser for EStdObjSmbiosTableList.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95602): https://edk2.groups.io/g/devel/message/95602
Mute This Topic: https://groups.io/mt/94232523/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-