Add PCCT generator and various fixes

[edk2-devel] [PATCH 14/14] ShellPkg/AcpiView: Update PCCT fields for ACPI 6.5

Posted by PierreGondois 3 years, 4 months ago

From: Pierre Gondois <pierre.gondois@arm.com>

The ACPI specification updated some terms in accordance with:
s1.1.1 Principle of Inclusive Terminology

Update the PCCT parser accordincly with these new terms.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
 .../UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
index 8cffdaaf0716..8ad39090afe3 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
@@ -146,7 +146,7 @@ ValidatePccDoorbellGas (
   IN VOID   *Context
   )
 {
-  // For slave subspaces this field is optional, if not present the field
+  // For responder subspaces this field is optional, if not present the field
   // should just contain zeros.
   if (*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) {
     if (IsZeroBuffer (
@@ -214,7 +214,7 @@ ValidatePccErrStatusGas (
   IN VOID   *Context
   )
 {
-  // This field is ignored by the OSPM on slave channels.
+  // This field is ignored by the OSPM on responder channels.
   if (*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) {
     return;
   }
@@ -237,7 +237,7 @@ ValidatePlatInterrupt (
   IN VOID   *Context
   )
 {
-  // If a slave subspace is present in the PCCT, then the global Platform
+  // If a responder subspace is present in the PCCT, then the global Platform
   // Interrupt flag must be set to 1.
   if ((*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) &&
       ((*PccGlobalFlags & EFI_ACPI_6_4_PCCT_FLAGS_PLATFORM_INTERRUPT) !=
-- 
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94895): https://edk2.groups.io/g/devel/message/94895
Mute This Topic: https://groups.io/mt/94232533/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 14/14] ShellPkg/AcpiView: Update PCCT fields for ACPI 6.5

Posted by Sami Mujawar 3 years, 3 months ago

Hi Pierre,

Thank you for this patch.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

On 10/10/2022 10:20 am, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
>
> The ACPI specification updated some terms in accordance with:
> s1.1.1 Principle of Inclusive Terminology
>
> Update the PCCT parser accordincly with these new terms.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>   .../UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c   | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
> index 8cffdaaf0716..8ad39090afe3 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
> @@ -146,7 +146,7 @@ ValidatePccDoorbellGas (
>     IN VOID   *Context
>     )
>   {
> -  // For slave subspaces this field is optional, if not present the field
> +  // For responder subspaces this field is optional, if not present the field
>     // should just contain zeros.
>     if (*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) {
>       if (IsZeroBuffer (
> @@ -214,7 +214,7 @@ ValidatePccErrStatusGas (
>     IN VOID   *Context
>     )
>   {
> -  // This field is ignored by the OSPM on slave channels.
> +  // This field is ignored by the OSPM on responder channels.
>     if (*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) {
>       return;
>     }
> @@ -237,7 +237,7 @@ ValidatePlatInterrupt (
>     IN VOID   *Context
>     )
>   {
> -  // If a slave subspace is present in the PCCT, then the global Platform
> +  // If a responder subspace is present in the PCCT, then the global Platform
>     // Interrupt flag must be set to 1.
>     if ((*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) &&
>         ((*PccGlobalFlags & EFI_ACPI_6_4_PCCT_FLAGS_PLATFORM_INTERRUPT) !=


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#95593): https://edk2.groups.io/g/devel/message/95593
Mute This Topic: https://groups.io/mt/94232533/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-